Re: [Mesa-dev] [PATCH 10/10] mesa: remove useless assert in _mesa_TextureView()

[Timothy Arceri]

Series:

Reviewed-by: Timothy Arceri 

On 20/07/17 19:53, Samuel Pitoiset wrote:

Already checked in _mesa_choose_texture_format().

Signed-off-by: Samuel Pitoiset 
---
  src/mesa/main/textureview.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/src/mesa/main/textureview.c b/src/mesa/main/textureview.c
index ed66c17958..cef9caff41 100644
--- a/src/mesa/main/textureview.c
+++ b/src/mesa/main/textureview.c
@@ -633,7 +633,6 @@ _mesa_TextureView(GLuint texture, GLenum target, GLuint 
origtexture,
  
 texFormat = _mesa_choose_texture_format(ctx, texObj, target, 0,

 internalformat, GL_NONE, GL_NONE);
-   assert(texFormat != MESA_FORMAT_NONE);
 if (texFormat == MESA_FORMAT_NONE) return;
  
 newViewNumLevels = MIN2(numlevels, origTexObj->NumLevels - minlevel);



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 10/10] mesa: remove useless assert in _mesa_TextureView()

[Samuel Pitoiset]

Already checked in _mesa_choose_texture_format().

Signed-off-by: Samuel Pitoiset 
---
 src/mesa/main/textureview.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/mesa/main/textureview.c b/src/mesa/main/textureview.c
index ed66c17958..cef9caff41 100644
--- a/src/mesa/main/textureview.c
+++ b/src/mesa/main/textureview.c
@@ -633,7 +633,6 @@ _mesa_TextureView(GLuint texture, GLenum target, GLuint 
origtexture,
 
texFormat = _mesa_choose_texture_format(ctx, texObj, target, 0,
internalformat, GL_NONE, GL_NONE);
-   assert(texFormat != MESA_FORMAT_NONE);
if (texFormat == MESA_FORMAT_NONE) return;
 
newViewNumLevels = MIN2(numlevels, origTexObj->NumLevels - minlevel);
-- 
2.13.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev