Re: [Mesa-dev] [PATCH 19/30] mesa/cs: Handle compute shaders in _mesa_use_program().

2014-01-10 Thread Paul Berry 
On 9 January 2014 22:32, Chris Forbes chr...@ijw.co.nz wrote:

 Minor nit, but could CS be done after the ordered pipeline stages, for
 consistency?


Sure, no problem.

In fact, I just realized that if I change the type parameter of
use_shader_program to gl_shader_stage, I can call it in a loop.  I'll do
that in a follow-up patch.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 19/30] mesa/cs: Handle compute shaders in _mesa_use_program().

2014-01-09 Thread Paul Berry 
---
 src/mesa/main/shaderapi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
index 519b200..5188e9c 100644
--- a/src/mesa/main/shaderapi.c
+++ b/src/mesa/main/shaderapi.c
@@ -993,6 +993,7 @@ _mesa_use_program(struct gl_context *ctx, struct 
gl_shader_program *shProg)
 {
use_shader_program(ctx, GL_VERTEX_SHADER, shProg);
use_shader_program(ctx, GL_GEOMETRY_SHADER_ARB, shProg);
+   use_shader_program(ctx, GL_COMPUTE_SHADER, shProg);
use_shader_program(ctx, GL_FRAGMENT_SHADER, shProg);
_mesa_active_program(ctx, shProg, glUseProgram);
 
-- 
1.8.5.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 19/30] mesa/cs: Handle compute shaders in _mesa_use_program().

2014-01-09 Thread Chris Forbes 
Minor nit, but could CS be done after the ordered pipeline stages, for
consistency?

On Fri, Jan 10, 2014 at 3:19 PM, Paul Berry stereotype...@gmail.com wrote:
 ---
  src/mesa/main/shaderapi.c | 1 +
  1 file changed, 1 insertion(+)

 diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
 index 519b200..5188e9c 100644
 --- a/src/mesa/main/shaderapi.c
 +++ b/src/mesa/main/shaderapi.c
 @@ -993,6 +993,7 @@ _mesa_use_program(struct gl_context *ctx, struct 
 gl_shader_program *shProg)
  {
 use_shader_program(ctx, GL_VERTEX_SHADER, shProg);
 use_shader_program(ctx, GL_GEOMETRY_SHADER_ARB, shProg);
 +   use_shader_program(ctx, GL_COMPUTE_SHADER, shProg);
 use_shader_program(ctx, GL_FRAGMENT_SHADER, shProg);
 _mesa_active_program(ctx, shProg, glUseProgram);

 --
 1.8.5.2

 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev