Re: [Mesa-dev] [PATCH 2/2] gallium/util: add some const qualifiers in u_bitmask.c

2019-03-05 Thread Jose Fonseca 

On 05/03/2019 23:56, Brian Paul wrote:

And add/update comments.
---
  src/gallium/auxiliary/util/u_bitmask.c | 16 ++--
  1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/gallium/auxiliary/util/u_bitmask.c 
b/src/gallium/auxiliary/util/u_bitmask.c
index 397b497..433a09d 100644
--- a/src/gallium/auxiliary/util/u_bitmask.c
+++ b/src/gallium/auxiliary/util/u_bitmask.c
@@ -90,7 +90,7 @@ static inline boolean
  util_bitmask_resize(struct util_bitmask *bm,
  unsigned minimum_index)
  {
-   unsigned minimum_size = minimum_index + 1;
+   const unsigned minimum_size = minimum_index + 1;
 unsigned new_size;
 util_bitmask_word *new_words;
  
@@ -131,7 +131,7 @@ util_bitmask_resize(struct util_bitmask *bm,
  
  
  /**

- * Lazily update the filled.
+ * Check if we can increment the filled counter.
   */
  static inline void
  util_bitmask_filled_set(struct util_bitmask *bm,
@@ -146,6 +146,10 @@ util_bitmask_filled_set(struct util_bitmask *bm,
 }
  }
  
+

+/**
+ * Check if we need to decrement the filled counter.
+ */
  static inline void
  util_bitmask_filled_unset(struct util_bitmask *bm,
unsigned index)
@@ -167,7 +171,7 @@ util_bitmask_add(struct util_bitmask *bm)
  
 assert(bm);
  
-   /* linear search for an empty index */

+   /* linear search for an empty index, starting at filled position */
 word = bm->filled / UTIL_BITMASK_BITS_PER_WORD;
 bit  = bm->filled % UTIL_BITMASK_BITS_PER_WORD;
 mask = 1 << bit;
@@ -249,9 +253,9 @@ boolean
  util_bitmask_get(struct util_bitmask *bm,
   unsigned index)
  {
-   unsigned word = index / UTIL_BITMASK_BITS_PER_WORD;
-   unsigned bit  = index % UTIL_BITMASK_BITS_PER_WORD;
-   util_bitmask_word mask = 1 << bit;
+   const unsigned word = index / UTIL_BITMASK_BITS_PER_WORD;
+   const unsigned bit  = index % UTIL_BITMASK_BITS_PER_WORD;
+   const util_bitmask_word mask = 1 << bit;
  
 assert(bm);
  



Series is

Reviewed-by: Jose Fonseca 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] gallium/util: add some const qualifiers in u_bitmask.c

2019-03-05 Thread Timothy Arceri 

Series:

Reviewed-by: Timothy Arceri 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] gallium/util: add some const qualifiers in u_bitmask.c

2019-03-05 Thread Brian Paul 
And add/update comments.
---
 src/gallium/auxiliary/util/u_bitmask.c | 16 ++--
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/gallium/auxiliary/util/u_bitmask.c 
b/src/gallium/auxiliary/util/u_bitmask.c
index 397b497..433a09d 100644
--- a/src/gallium/auxiliary/util/u_bitmask.c
+++ b/src/gallium/auxiliary/util/u_bitmask.c
@@ -90,7 +90,7 @@ static inline boolean
 util_bitmask_resize(struct util_bitmask *bm,
 unsigned minimum_index)
 {
-   unsigned minimum_size = minimum_index + 1;
+   const unsigned minimum_size = minimum_index + 1;
unsigned new_size;
util_bitmask_word *new_words;
 
@@ -131,7 +131,7 @@ util_bitmask_resize(struct util_bitmask *bm,
 
 
 /**
- * Lazily update the filled.
+ * Check if we can increment the filled counter.
  */
 static inline void
 util_bitmask_filled_set(struct util_bitmask *bm,
@@ -146,6 +146,10 @@ util_bitmask_filled_set(struct util_bitmask *bm,
}
 }
 
+
+/**
+ * Check if we need to decrement the filled counter.
+ */
 static inline void
 util_bitmask_filled_unset(struct util_bitmask *bm,
   unsigned index)
@@ -167,7 +171,7 @@ util_bitmask_add(struct util_bitmask *bm)
 
assert(bm);
 
-   /* linear search for an empty index */
+   /* linear search for an empty index, starting at filled position */
word = bm->filled / UTIL_BITMASK_BITS_PER_WORD;
bit  = bm->filled % UTIL_BITMASK_BITS_PER_WORD;
mask = 1 << bit;
@@ -249,9 +253,9 @@ boolean
 util_bitmask_get(struct util_bitmask *bm,
  unsigned index)
 {
-   unsigned word = index / UTIL_BITMASK_BITS_PER_WORD;
-   unsigned bit  = index % UTIL_BITMASK_BITS_PER_WORD;
-   util_bitmask_word mask = 1 << bit;
+   const unsigned word = index / UTIL_BITMASK_BITS_PER_WORD;
+   const unsigned bit  = index % UTIL_BITMASK_BITS_PER_WORD;
+   const util_bitmask_word mask = 1 << bit;
 
assert(bm);
 
-- 
1.8.5.6

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev