Re: [Mesa-dev] [PATCH 2/2] radv: make vk_format_description structures static

2018-03-10 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen 

for the series.

On Sat, Mar 10, 2018 at 8:28 PM, Grazvydas Ignotas  wrote:
> No need to bother the linker about them.
> ---
>  src/amd/vulkan/vk_format_table.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/vk_format_table.py 
> b/src/amd/vulkan/vk_format_table.py
> index c33a4ce..cd1af62 100644
> --- a/src/amd/vulkan/vk_format_table.py
> +++ b/src/amd/vulkan/vk_format_table.py
> @@ -123,11 +123,11 @@ def write_format_table(formats):
>  comment = 'ignored'
>  print "  %s%s\t/* %s */" % (swizzle_map[swizzle], sep, 
> comment)
>  print "   },"
>
>  for format in formats:
> -print 'const struct vk_format_description'
> +print 'static const struct vk_format_description'
>  print 'vk_format_%s_description = {' % (format.short_name(),)
>  print "   %s," % (format.name,)
>  print "   \"%s\"," % (format.name,)
>  print "   \"%s\"," % (format.short_name(),)
>  print "   {%u, %u, %u},\t/* block */" % (format.block_width, 
> format.block_height, format.block_size())
> --
> 2.7.4
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 2/2] radv: make vk_format_description structures static

2018-03-10 Thread Grazvydas Ignotas
No need to bother the linker about them.
---
 src/amd/vulkan/vk_format_table.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/vk_format_table.py 
b/src/amd/vulkan/vk_format_table.py
index c33a4ce..cd1af62 100644
--- a/src/amd/vulkan/vk_format_table.py
+++ b/src/amd/vulkan/vk_format_table.py
@@ -123,11 +123,11 @@ def write_format_table(formats):
 comment = 'ignored'
 print "  %s%s\t/* %s */" % (swizzle_map[swizzle], sep, comment)
 print "   },"
 
 for format in formats:
-print 'const struct vk_format_description'
+print 'static const struct vk_format_description'
 print 'vk_format_%s_description = {' % (format.short_name(),)
 print "   %s," % (format.name,)
 print "   \"%s\"," % (format.name,)
 print "   \"%s\"," % (format.short_name(),)
 print "   {%u, %u, %u},\t/* block */" % (format.block_width, 
format.block_height, format.block_size())
-- 
2.7.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev