Re: [Mesa-dev] [PATCH 2/2] targets/xvmc: export only necessary symbols

2013-11-17 Thread Christian König

Am 16.11.2013 23:29, schrieb Ilia Mirkin:

On Sat, Nov 16, 2013 at 4:39 PM, Emil Velikov emil.l.veli...@gmail.com wrote:

Export only XvMC* symbols for the xvmc targets.

Signed-off-by: Emil Velikov emil.l.veli...@gmail.com

Tested-by: Ilia Mirkin imir...@alum.mit.edu

Works fine on my NV42, the vl_screen* and nouveau_drm_screen_create
symbols are indeed gone.


Haven't tested it, but it sounds like a good idea to me as well. Patch is:

Reviewed-by: Christian König christian.koe...@amd.com


---
  src/gallium/Automake.inc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/Automake.inc b/src/gallium/Automake.inc
index b6b9b36..1e4a34f 100644
--- a/src/gallium/Automake.inc
+++ b/src/gallium/Automake.inc
@@ -65,11 +65,11 @@ GALLIUM_VDPAU_LINKER_FLAGS = \
 -shared \
 -no-undefined

-# TODO: add -export-symbols-regex
  GALLIUM_XVMC_LINKER_FLAGS = \
 -module \
 -version-number $(XVMC_MAJOR):$(XVMC_MINOR) \
 -shared \
+   -export-symbols-regex '^XvMC' \
 -no-undefined

  GALLIUM_VDPAU_LIB_DEPS = \
--
1.8.4.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 2/2] targets/xvmc: export only necessary symbols

2013-11-16 Thread Emil Velikov
Export only XvMC* symbols for the xvmc targets.

Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
 src/gallium/Automake.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/Automake.inc b/src/gallium/Automake.inc
index b6b9b36..1e4a34f 100644
--- a/src/gallium/Automake.inc
+++ b/src/gallium/Automake.inc
@@ -65,11 +65,11 @@ GALLIUM_VDPAU_LINKER_FLAGS = \
-shared \
-no-undefined
 
-# TODO: add -export-symbols-regex
 GALLIUM_XVMC_LINKER_FLAGS = \
-module \
-version-number $(XVMC_MAJOR):$(XVMC_MINOR) \
-shared \
+   -export-symbols-regex '^XvMC' \
-no-undefined
 
 GALLIUM_VDPAU_LIB_DEPS = \
-- 
1.8.4.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 2/2] targets/xvmc: export only necessary symbols

2013-11-16 Thread Ilia Mirkin
On Sat, Nov 16, 2013 at 4:39 PM, Emil Velikov emil.l.veli...@gmail.com wrote:
 Export only XvMC* symbols for the xvmc targets.

 Signed-off-by: Emil Velikov emil.l.veli...@gmail.com

Tested-by: Ilia Mirkin imir...@alum.mit.edu

Works fine on my NV42, the vl_screen* and nouveau_drm_screen_create
symbols are indeed gone.

 ---
  src/gallium/Automake.inc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/src/gallium/Automake.inc b/src/gallium/Automake.inc
 index b6b9b36..1e4a34f 100644
 --- a/src/gallium/Automake.inc
 +++ b/src/gallium/Automake.inc
 @@ -65,11 +65,11 @@ GALLIUM_VDPAU_LINKER_FLAGS = \
 -shared \
 -no-undefined

 -# TODO: add -export-symbols-regex
  GALLIUM_XVMC_LINKER_FLAGS = \
 -module \
 -version-number $(XVMC_MAJOR):$(XVMC_MINOR) \
 -shared \
 +   -export-symbols-regex '^XvMC' \
 -no-undefined

  GALLIUM_VDPAU_LIB_DEPS = \
 --
 1.8.4.2

 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev