Re: [Mesa-dev] [PATCH 2/3] Autotools: Add passes.h to sources so it will be included in the tarball

2018-04-23 Thread Dylan Baker 
Quoting Kyriazis, George (2018-04-23 07:52:23)
> I agree on the commit message wording.
> 
> Sorry about missing passes.h in the original check-in.
> 

No worries, most (all?) of us forget about it. I guess it's just one more thing
that meson will improve in our workflow :)

Dylan


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] Autotools: Add passes.h to sources so it will be included in the tarball

2018-04-23 Thread Kyriazis, George 
I agree on the commit message wording.

Sorry about missing passes.h in the original check-in.

Reviewed-by: George Kyriazis 
>

On Apr 20, 2018, at 10:00 PM, Kenneth Graunke 
> wrote:

On Friday, April 20, 2018 7:19:50 PM PDT Dylan Baker wrote:
Signed-off-by: Dylan Baker 
>
---
src/gallium/drivers/swr/Makefile.sources | 1 +
1 file changed, 1 insertion(+)

diff --git a/src/gallium/drivers/swr/Makefile.sources 
b/src/gallium/drivers/swr/Makefile.sources
index dd815dcb581..a06d1d7b929 100644
--- a/src/gallium/drivers/swr/Makefile.sources
+++ b/src/gallium/drivers/swr/Makefile.sources
@@ -155,6 +155,7 @@ JITTER_CXX_SOURCES := \
rasterizer/jitter/streamout_jit.cpp \
rasterizer/jitter/streamout_jit.h \
rasterizer/jitter/shader_lib/DebugOutput.cpp \
+ rasterizer/jitter/functionpasses/passes.h \
rasterizer/jitter/functionpasses/lower_x86.cpp

MEMORY_CXX_SOURCES := \


I would add the following to the commit message:

This was introduced in commit 8f848ada8a42d9aaa8136afa1bafe32281a0fb48
but not added to the sources list, which is necessary for it to be
included in release tarballs.

Fixes: 8f848ada8a42d9aaa8136afa1bafe32281a0fb48 (swr/rast: Start refactoring of 
builder/packetizer.)
Reviewed-by: Kenneth Graunke 
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] Autotools: Add passes.h to sources so it will be included in the tarball

2018-04-20 Thread Kenneth Graunke 
On Friday, April 20, 2018 7:19:50 PM PDT Dylan Baker wrote:
> Signed-off-by: Dylan Baker 
> ---
>  src/gallium/drivers/swr/Makefile.sources | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/gallium/drivers/swr/Makefile.sources 
> b/src/gallium/drivers/swr/Makefile.sources
> index dd815dcb581..a06d1d7b929 100644
> --- a/src/gallium/drivers/swr/Makefile.sources
> +++ b/src/gallium/drivers/swr/Makefile.sources
> @@ -155,6 +155,7 @@ JITTER_CXX_SOURCES := \
>   rasterizer/jitter/streamout_jit.cpp \
>   rasterizer/jitter/streamout_jit.h \
>   rasterizer/jitter/shader_lib/DebugOutput.cpp \
> + rasterizer/jitter/functionpasses/passes.h \
>   rasterizer/jitter/functionpasses/lower_x86.cpp
>  
>  MEMORY_CXX_SOURCES := \
> 

I would add the following to the commit message:

This was introduced in commit 8f848ada8a42d9aaa8136afa1bafe32281a0fb48 
but not added to the sources list, which is necessary for it to be
included in release tarballs.

Fixes: 8f848ada8a42d9aaa8136afa1bafe32281a0fb48 (swr/rast: Start refactoring of 
builder/packetizer.)
Reviewed-by: Kenneth Graunke 


signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/3] Autotools: Add passes.h to sources so it will be included in the tarball

2018-04-20 Thread Dylan Baker 
Signed-off-by: Dylan Baker 
---
 src/gallium/drivers/swr/Makefile.sources | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gallium/drivers/swr/Makefile.sources 
b/src/gallium/drivers/swr/Makefile.sources
index dd815dcb581..a06d1d7b929 100644
--- a/src/gallium/drivers/swr/Makefile.sources
+++ b/src/gallium/drivers/swr/Makefile.sources
@@ -155,6 +155,7 @@ JITTER_CXX_SOURCES := \
rasterizer/jitter/streamout_jit.cpp \
rasterizer/jitter/streamout_jit.h \
rasterizer/jitter/shader_lib/DebugOutput.cpp \
+   rasterizer/jitter/functionpasses/passes.h \
rasterizer/jitter/functionpasses/lower_x86.cpp
 
 MEMORY_CXX_SOURCES := \
-- 
2.17.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev