Re: [Mesa-dev] [PATCH 2/6] configure.ac: Fix error message in radeon_llvm_check().

2017-03-06 Thread Tobias Droste
Oops... :-)

Reviewed-by: Tobias Droste 

Am Montag, 6. März 2017, 20:06:07 CET schrieb Matt Turner:
> It printed the version of LLVM ($1):
> 
>configure: error: 3.6.0 requires libelf when using llvm
> 
> instead of the driver name ($2):
> 
>configure: error: r600 requires libelf when using llvm
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 99ff4df..de54f38 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1013,7 +1013,7 @@ radeon_llvm_check() {
>  llvm_add_component "ipo" $2
> 
>  if test "x$have_libelf" != xyes; then
> -   AC_MSG_ERROR([$1 requires libelf when using llvm])
> +   AC_MSG_ERROR([$2 requires libelf when using llvm])
>  fi
>  }
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 2/6] configure.ac: Fix error message in radeon_llvm_check().

2017-03-06 Thread Marek Olšák
Reviewed-by: Marek Olšák 

Marek

On Mon, Mar 6, 2017 at 8:06 PM, Matt Turner  wrote:
> It printed the version of LLVM ($1):
>
>configure: error: 3.6.0 requires libelf when using llvm
>
> instead of the driver name ($2):
>
>configure: error: r600 requires libelf when using llvm
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 99ff4df..de54f38 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1013,7 +1013,7 @@ radeon_llvm_check() {
>  llvm_add_component "ipo" $2
>
>  if test "x$have_libelf" != xyes; then
> -   AC_MSG_ERROR([$1 requires libelf when using llvm])
> +   AC_MSG_ERROR([$2 requires libelf when using llvm])
>  fi
>  }
>
> --
> 2.10.2
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 2/6] configure.ac: Fix error message in radeon_llvm_check().

2017-03-06 Thread Matt Turner
It printed the version of LLVM ($1):

   configure: error: 3.6.0 requires libelf when using llvm

instead of the driver name ($2):

   configure: error: r600 requires libelf when using llvm
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 99ff4df..de54f38 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1013,7 +1013,7 @@ radeon_llvm_check() {
 llvm_add_component "ipo" $2
 
 if test "x$have_libelf" != xyes; then
-   AC_MSG_ERROR([$1 requires libelf when using llvm])
+   AC_MSG_ERROR([$2 requires libelf when using llvm])
 fi
 }
 
-- 
2.10.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev