Re: [Mesa-dev] [PATCH 3/4] meson: fix formatting and add extra_files to i965
On Tue, 2018-10-23 at 15:56 -0700, Dylan Baker wrote: > extra_files is just a nice way to to tell certain IDE's (and those > reading the file) that this file is also a dependency. Meson will use > the .d file generated by the compiler to figure out what the target > actually depends on. Reviewed-by: Juan A. Suarez > --- > src/mesa/drivers/dri/i965/meson.build | 22 -- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/meson.build > b/src/mesa/drivers/dri/i965/meson.build > index bf366a6c157..24172955e9b 100644 > --- a/src/mesa/drivers/dri/i965/meson.build > +++ b/src/mesa/drivers/dri/i965/meson.build > @@ -191,20 +191,22 @@ intel_tiled_memcpy = static_library( > inc_common, inc_intel, inc_dri_common, inc_drm_uapi, >], >c_args : [c_vis_args, no_override_init_args, '-msse2'], > + extra_files : ['intel_tiled_memcpy.c'] > ) > > if with_sse41 > -intel_tiled_memcpy_sse41 = static_library( > - 'intel_tiled_memcpy_sse41', > - [files_intel_tiled_memcpy_sse41], > - include_directories : [ > -inc_common, inc_intel, inc_dri_common, inc_drm_uapi, > - ], > - link_args : [ '-Wl,--exclude-libs=ALL' ], > - c_args : [c_vis_args, no_override_init_args, '-Wl,--exclude-libs=ALL', > '-msse2', sse41_args], > -) > + intel_tiled_memcpy_sse41 = static_library( > +'intel_tiled_memcpy_sse41', > +[files_intel_tiled_memcpy_sse41], > +include_directories : [ > + inc_common, inc_intel, inc_dri_common, inc_drm_uapi, > +], > +link_args : ['-Wl,--exclude-libs=ALL'], > +c_args : [c_vis_args, no_override_init_args, '-Wl,--exclude-libs=ALL', > '-msse2', sse41_args], > +extra_files : ['intel_tiled_memcpy.c'] > + ) > else > -intel_tiled_memcpy_sse41 = [] > + intel_tiled_memcpy_sse41 = [] > endif > > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 3/4] meson: fix formatting and add extra_files to i965
Reviewed-by: Tapani Pälli On 10/24/18 1:56 AM, Dylan Baker wrote: extra_files is just a nice way to to tell certain IDE's (and those reading the file) that this file is also a dependency. Meson will use the .d file generated by the compiler to figure out what the target actually depends on. --- src/mesa/drivers/dri/i965/meson.build | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/meson.build b/src/mesa/drivers/dri/i965/meson.build index bf366a6c157..24172955e9b 100644 --- a/src/mesa/drivers/dri/i965/meson.build +++ b/src/mesa/drivers/dri/i965/meson.build @@ -191,20 +191,22 @@ intel_tiled_memcpy = static_library( inc_common, inc_intel, inc_dri_common, inc_drm_uapi, ], c_args : [c_vis_args, no_override_init_args, '-msse2'], + extra_files : ['intel_tiled_memcpy.c'] ) if with_sse41 -intel_tiled_memcpy_sse41 = static_library( - 'intel_tiled_memcpy_sse41', - [files_intel_tiled_memcpy_sse41], - include_directories : [ -inc_common, inc_intel, inc_dri_common, inc_drm_uapi, - ], - link_args : [ '-Wl,--exclude-libs=ALL' ], - c_args : [c_vis_args, no_override_init_args, '-Wl,--exclude-libs=ALL', '-msse2', sse41_args], -) + intel_tiled_memcpy_sse41 = static_library( +'intel_tiled_memcpy_sse41', +[files_intel_tiled_memcpy_sse41], +include_directories : [ + inc_common, inc_intel, inc_dri_common, inc_drm_uapi, +], +link_args : ['-Wl,--exclude-libs=ALL'], +c_args : [c_vis_args, no_override_init_args, '-Wl,--exclude-libs=ALL', '-msse2', sse41_args], +extra_files : ['intel_tiled_memcpy.c'] + ) else -intel_tiled_memcpy_sse41 = [] + intel_tiled_memcpy_sse41 = [] endif ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 3/4] meson: fix formatting and add extra_files to i965
extra_files is just a nice way to to tell certain IDE's (and those reading the file) that this file is also a dependency. Meson will use the .d file generated by the compiler to figure out what the target actually depends on. --- src/mesa/drivers/dri/i965/meson.build | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/meson.build b/src/mesa/drivers/dri/i965/meson.build index bf366a6c157..24172955e9b 100644 --- a/src/mesa/drivers/dri/i965/meson.build +++ b/src/mesa/drivers/dri/i965/meson.build @@ -191,20 +191,22 @@ intel_tiled_memcpy = static_library( inc_common, inc_intel, inc_dri_common, inc_drm_uapi, ], c_args : [c_vis_args, no_override_init_args, '-msse2'], + extra_files : ['intel_tiled_memcpy.c'] ) if with_sse41 -intel_tiled_memcpy_sse41 = static_library( - 'intel_tiled_memcpy_sse41', - [files_intel_tiled_memcpy_sse41], - include_directories : [ -inc_common, inc_intel, inc_dri_common, inc_drm_uapi, - ], - link_args : [ '-Wl,--exclude-libs=ALL' ], - c_args : [c_vis_args, no_override_init_args, '-Wl,--exclude-libs=ALL', '-msse2', sse41_args], -) + intel_tiled_memcpy_sse41 = static_library( +'intel_tiled_memcpy_sse41', +[files_intel_tiled_memcpy_sse41], +include_directories : [ + inc_common, inc_intel, inc_dri_common, inc_drm_uapi, +], +link_args : ['-Wl,--exclude-libs=ALL'], +c_args : [c_vis_args, no_override_init_args, '-Wl,--exclude-libs=ALL', '-msse2', sse41_args], +extra_files : ['intel_tiled_memcpy.c'] + ) else -intel_tiled_memcpy_sse41 = [] + intel_tiled_memcpy_sse41 = [] endif -- 2.19.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
