Re: [Mesa-dev] [PATCH 3.5/4] st/mesa: get on-disk shader cache

2017-02-20 Thread Timothy Arceri



On 21/02/17 13:20, Michel Dänzer wrote:

On 21/02/17 08:23 AM, Timothy Arceri wrote:

---
 src/mesa/state_tracker/st_context.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/mesa/state_tracker/st_context.c 
b/src/mesa/state_tracker/st_context.c
index f4ad6d8..153f01c 100644
--- a/src/mesa/state_tracker/st_context.c
+++ b/src/mesa/state_tracker/st_context.c
@@ -538,6 +538,8 @@ struct st_context *st_create_context(gl_api api, struct 
pipe_context *pipe,
   return NULL;
}

+   ctx->Cache = pipe->screen->get_disk_shader_cache(pipe->screen);


You probably want to guard this by

   if (pipe->screen->get_disk_shader_cache)


Of course. Thanks.



otherwise you'd need to make sure that every driver sets
pipe_screen::get_disk_shader_cache.


Speaking of which, you probably need to add a get_disk_shader_cache
implementation to all the wrapper drivers (ddebug, rbug, trace).



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 3.5/4] st/mesa: get on-disk shader cache

2017-02-20 Thread Michel Dänzer
On 21/02/17 08:23 AM, Timothy Arceri wrote:
> ---
>  src/mesa/state_tracker/st_context.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/mesa/state_tracker/st_context.c 
> b/src/mesa/state_tracker/st_context.c
> index f4ad6d8..153f01c 100644
> --- a/src/mesa/state_tracker/st_context.c
> +++ b/src/mesa/state_tracker/st_context.c
> @@ -538,6 +538,8 @@ struct st_context *st_create_context(gl_api api, struct 
> pipe_context *pipe,
>return NULL;
> }
>  
> +   ctx->Cache = pipe->screen->get_disk_shader_cache(pipe->screen);

You probably want to guard this by

   if (pipe->screen->get_disk_shader_cache)

otherwise you'd need to make sure that every driver sets
pipe_screen::get_disk_shader_cache.


Speaking of which, you probably need to add a get_disk_shader_cache
implementation to all the wrapper drivers (ddebug, rbug, trace).


-- 
Earthling Michel Dänzer   |   http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 3.5/4] st/mesa: get on-disk shader cache

2017-02-20 Thread Timothy Arceri
---
 src/mesa/state_tracker/st_context.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/mesa/state_tracker/st_context.c 
b/src/mesa/state_tracker/st_context.c
index f4ad6d8..153f01c 100644
--- a/src/mesa/state_tracker/st_context.c
+++ b/src/mesa/state_tracker/st_context.c
@@ -538,6 +538,8 @@ struct st_context *st_create_context(gl_api api, struct 
pipe_context *pipe,
   return NULL;
}
 
+   ctx->Cache = pipe->screen->get_disk_shader_cache(pipe->screen);
+
st_init_driver_flags(>DriverFlags);
 
/* XXX: need a capability bit in gallium to query if the pipe
-- 
2.9.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev