Re: [Mesa-dev] [PATCH 4/7 v2] configure.ac: Introduce HAVE_ARM_ASM/HAVE_AARCH64_ASM and the -D flags.

[Eric Anholt]

Emil Velikov  writes:

> Hi Eric,
>
> On 10 August 2017 at 23:43, Eric Anholt  wrote:
>
>> +aarch64)
>> +DEFINES="$DEFINES -DUSE_AARCH64_ASM"
> I cannot see any places where the define is used.
>
> Am I missing something or there isn't any? Do you have some WIP
> patches that make use of it?

There is no current user, but I think being consistent with the other
asm defines/conditionals is best.


signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/7 v2] configure.ac: Introduce HAVE_ARM_ASM/HAVE_AARCH64_ASM and the -D flags.

[Emil Velikov]

Hi Eric,

On 10 August 2017 at 23:43, Eric Anholt  wrote:

> +aarch64)
> +DEFINES="$DEFINES -DUSE_AARCH64_ASM"
I cannot see any places where the define is used.

Am I missing something or there isn't any? Do you have some WIP
patches that make use of it?

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/7 v2] configure.ac: Introduce HAVE_ARM_ASM/HAVE_AARCH64_ASM and the -D flags.

[Rob Herring]

On Thu, Aug 10, 2017 at 5:43 PM, Eric Anholt  wrote:
> I've been trying to get away without these conditionals in vc4's NEON
> code, but it meant compiling extra unused code on x86, and build failing
> on ARMv6.
>
> v2: Use the _arm/_arm64 flags to simplify detection (suggested by Rob),
> but hide the _arm version under ARCH_ARM_HAVE_NEON to keep from trying
> to build this stuff for armv5te.
> ---
>  Android.common.mk |  4 
>  configure.ac  | 24 
>  2 files changed, 28 insertions(+)

For Android:

Tested-by: Rob Herring 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 4/7 v2] configure.ac: Introduce HAVE_ARM_ASM/HAVE_AARCH64_ASM and the -D flags.

[Eric Anholt]

I've been trying to get away without these conditionals in vc4's NEON
code, but it meant compiling extra unused code on x86, and build failing
on ARMv6.

v2: Use the _arm/_arm64 flags to simplify detection (suggested by Rob),
but hide the _arm version under ARCH_ARM_HAVE_NEON to keep from trying
to build this stuff for armv5te.
---
 Android.common.mk |  4 
 configure.ac  | 24 
 2 files changed, 28 insertions(+)

diff --git a/Android.common.mk b/Android.common.mk
index 6bd30816bc41..e5416c4e3839 100644
--- a/Android.common.mk
+++ b/Android.common.mk
@@ -88,6 +88,10 @@ LOCAL_CFLAGS += \
 
 endif
 endif
+ifeq ($(ARCH_ARM_HAVE_NEON),true)
+LOCAL_CFLAGS_arm += -DUSE_ARM_ASM
+endif
+LOCAL_CFLAGS_arm64 += -DUSE_AARCH64_ASM
 
 ifneq ($(LOCAL_IS_HOST_MODULE),true)
 LOCAL_CFLAGS += -DHAVE_LIBDRM
diff --git a/configure.ac b/configure.ac
index 5b12dd8506a5..d4f36898ba5b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -773,6 +773,20 @@ if test "x$enable_asm" = xyes; then
 ;;
 esac
 ;;
+aarch64)
+case "$host_os" in
+linux*)
+asm_arch=aarch64
+;;
+esac
+;;
+arm)
+case "$host_os" in
+linux*)
+asm_arch=arm
+;;
+esac
+;;
 esac
 
 case "$asm_arch" in
@@ -792,6 +806,14 @@ if test "x$enable_asm" = xyes; then
 DEFINES="$DEFINES -DUSE_PPC64LE_ASM"
 AC_MSG_RESULT([yes, ppc64le])
 ;;
+aarch64)
+DEFINES="$DEFINES -DUSE_AARCH64_ASM"
+AC_MSG_RESULT([yes, aarch64])
+;;
+arm)
+DEFINES="$DEFINES -DUSE_ARM_ASM"
+AC_MSG_RESULT([yes, arm])
+;;
 *)
 AC_MSG_RESULT([no, platform not supported])
 ;;
@@ -2729,6 +2751,8 @@ AM_CONDITIONAL(HAVE_X86_ASM, test "x$asm_arch" = xx86 -o 
"x$asm_arch" = xx86_64)
 AM_CONDITIONAL(HAVE_X86_64_ASM, test "x$asm_arch" = xx86_64)
 AM_CONDITIONAL(HAVE_SPARC_ASM, test "x$asm_arch" = xsparc)
 AM_CONDITIONAL(HAVE_PPC64LE_ASM, test "x$asm_arch" = xppc64le)
+AM_CONDITIONAL(HAVE_AARCH64_ASM, test "x$asm_arch" = xaarch64)
+AM_CONDITIONAL(HAVE_ARM_ASM, test "x$asm_arch" = xarm)
 
 AC_SUBST([NINE_MAJOR], 1)
 AC_SUBST([NINE_MINOR], 0)
-- 
2.13.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev