Re: [Mesa-dev] [PATCH 9/9] panfrost: Enable sRGB
> Actually, I think this is the commit that introduced these regressions: > > panfrost: Figure out job requirements in pan_job.c ...Hmm. signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 9/9] panfrost: Enable sRGB
On Wed, 19 Jun 2019 at 07:44, Tomeu Vizoso wrote: > > On Tue, 18 Jun 2019 at 17:00, Alyssa Rosenzweig > wrote: > > > > Now that sRGB formats are supported for both rendering and sampling, > > advertise support. > > > > Signed-off-by: Alyssa Rosenzweig > > Hi there, > > this patch seems to have caused the following regressions: > > dEQP-GLES2.functional.fbo.render.recreate_colorbuffer.no_rebind_rbo_rgb565 > dEQP-GLES2.functional.fbo.render.resize.tex2d_rgb > > For more details, see > https://gitlab.freedesktop.org/tomeu/mesa/pipelines/43396 > > Should we revert it for now? Actually, I think this is the commit that introduced these regressions: panfrost: Figure out job requirements in pan_job.c Cheers, Tomeu > Cheers, > > Tomeu > > > --- > > src/gallium/drivers/panfrost/pan_screen.c | 4 > > 1 file changed, 4 deletions(-) > > > > diff --git a/src/gallium/drivers/panfrost/pan_screen.c > > b/src/gallium/drivers/panfrost/pan_screen.c > > index 9cd98cd9051..70bff565930 100644 > > --- a/src/gallium/drivers/panfrost/pan_screen.c > > +++ b/src/gallium/drivers/panfrost/pan_screen.c > > @@ -450,10 +450,6 @@ panfrost_is_format_supported( struct pipe_screen > > *screen, > > if (sample_count > 1) > > return FALSE; > > > > - /* sRGB colorspace is not supported (yet?) */ > > - if (format_desc->colorspace == UTIL_FORMAT_COLORSPACE_SRGB) > > - return FALSE; > > - > > /* Format wishlist */ > > if (format == PIPE_FORMAT_Z24X8_UNORM || format == > > PIPE_FORMAT_X8Z24_UNORM) > > return FALSE; > > -- > > 2.20.1 > > > > ___ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 9/9] panfrost: Enable sRGB
On Tue, 18 Jun 2019 at 17:00, Alyssa Rosenzweig wrote: > > Now that sRGB formats are supported for both rendering and sampling, > advertise support. > > Signed-off-by: Alyssa Rosenzweig Hi there, this patch seems to have caused the following regressions: dEQP-GLES2.functional.fbo.render.recreate_colorbuffer.no_rebind_rbo_rgb565 dEQP-GLES2.functional.fbo.render.resize.tex2d_rgb For more details, see https://gitlab.freedesktop.org/tomeu/mesa/pipelines/43396 Should we revert it for now? Cheers, Tomeu > --- > src/gallium/drivers/panfrost/pan_screen.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/src/gallium/drivers/panfrost/pan_screen.c > b/src/gallium/drivers/panfrost/pan_screen.c > index 9cd98cd9051..70bff565930 100644 > --- a/src/gallium/drivers/panfrost/pan_screen.c > +++ b/src/gallium/drivers/panfrost/pan_screen.c > @@ -450,10 +450,6 @@ panfrost_is_format_supported( struct pipe_screen *screen, > if (sample_count > 1) > return FALSE; > > - /* sRGB colorspace is not supported (yet?) */ > - if (format_desc->colorspace == UTIL_FORMAT_COLORSPACE_SRGB) > - return FALSE; > - > /* Format wishlist */ > if (format == PIPE_FORMAT_Z24X8_UNORM || format == > PIPE_FORMAT_X8Z24_UNORM) > return FALSE; > -- > 2.20.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 9/9] panfrost: Enable sRGB
Now that sRGB formats are supported for both rendering and sampling, advertise support. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_screen.c | 4 1 file changed, 4 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_screen.c b/src/gallium/drivers/panfrost/pan_screen.c index 9cd98cd9051..70bff565930 100644 --- a/src/gallium/drivers/panfrost/pan_screen.c +++ b/src/gallium/drivers/panfrost/pan_screen.c @@ -450,10 +450,6 @@ panfrost_is_format_supported( struct pipe_screen *screen, if (sample_count > 1) return FALSE; - /* sRGB colorspace is not supported (yet?) */ - if (format_desc->colorspace == UTIL_FORMAT_COLORSPACE_SRGB) - return FALSE; - /* Format wishlist */ if (format == PIPE_FORMAT_Z24X8_UNORM || format == PIPE_FORMAT_X8Z24_UNORM) return FALSE; -- 2.20.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
