Re: [Mesa-dev] [PATCH 9/9] radv: enable shaderInt16 capability

2018-09-14 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen 

for the series.
On Fri, Sep 14, 2018 at 12:51 PM Samuel Pitoiset
 wrote:
>
> Not sure if this is all wired up. CTS does pass and the Tangrams
> demo seems to work (though with a local hack that is unrelated
> to 16-bit integer).
>
> Signed-off-by: Samuel Pitoiset 
> ---
>  src/amd/vulkan/radv_device.c | 2 +-
>  src/amd/vulkan/radv_shader.c | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index 8989ec3553..af7754bea3 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -734,7 +734,7 @@ void radv_GetPhysicalDeviceFeatures(
> .shaderCullDistance   = true,
> .shaderFloat64= true,
> .shaderInt64  = true,
> -   .shaderInt16  = false,
> +   .shaderInt16  = true,
> .sparseBinding= true,
> .variableMultisampleRate  = true,
> .inheritedQueries = true,
> diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c
> index e05961339c..fc2033d6a9 100644
> --- a/src/amd/vulkan/radv_shader.c
> +++ b/src/amd/vulkan/radv_shader.c
> @@ -210,6 +210,7 @@ radv_shader_compile_to_nir(struct radv_device *device,
> .image_write_without_format = true,
> .tessellation = true,
> .int64 = true,
> +   .int16 = true,
> .multiview = true,
> .subgroup_ballot = true,
> .subgroup_basic = true,
> --
> 2.19.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 9/9] radv: enable shaderInt16 capability

2018-09-14 Thread Samuel Pitoiset
Not sure if this is all wired up. CTS does pass and the Tangrams
demo seems to work (though with a local hack that is unrelated
to 16-bit integer).

Signed-off-by: Samuel Pitoiset 
---
 src/amd/vulkan/radv_device.c | 2 +-
 src/amd/vulkan/radv_shader.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 8989ec3553..af7754bea3 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -734,7 +734,7 @@ void radv_GetPhysicalDeviceFeatures(
.shaderCullDistance   = true,
.shaderFloat64= true,
.shaderInt64  = true,
-   .shaderInt16  = false,
+   .shaderInt16  = true,
.sparseBinding= true,
.variableMultisampleRate  = true,
.inheritedQueries = true,
diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c
index e05961339c..fc2033d6a9 100644
--- a/src/amd/vulkan/radv_shader.c
+++ b/src/amd/vulkan/radv_shader.c
@@ -210,6 +210,7 @@ radv_shader_compile_to_nir(struct radv_device *device,
.image_write_without_format = true,
.tessellation = true,
.int64 = true,
+   .int16 = true,
.multiview = true,
.subgroup_ballot = true,
.subgroup_basic = true,
-- 
2.19.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev