Re: [Mesa-dev] [PATCH V3] i965/cnl: Add l3 configuration for Cannonlake

[Francisco Jerez]

Anuj Phogat  writes:

> From: Ben Widawsky 
>
> V2 (Anuj):
> Squash the changes in one patch rebase on master.
> Address the review comments made by Francisco Jerez.
> Do the URB allocation per slice (not per bank).
>
> V3 (Anuj):
> Update the comment.
> Format the table as other l3 config tables.
>
> Signed-off-by: Ben Widawsky 
> Signed-off-by: Anuj Phogat 

Reviewed-by: Francisco Jerez 

> Cc: Francisco Jerez 
> ---
> V1 was sent out with the heading:
> "i965/cnl: Properly handle l3 configuration"
> ---
>  src/intel/common/gen_l3_config.c | 21 -
>  1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/src/intel/common/gen_l3_config.c 
> b/src/intel/common/gen_l3_config.c
> index 21ee5ca..aff13c0 100644
> --- a/src/intel/common/gen_l3_config.c
> +++ b/src/intel/common/gen_l3_config.c
> @@ -116,6 +116,23 @@ static const struct gen_l3_config bxt_2x6_l3_configs[] = 
> {
>  };
>  
>  /**
> + * CNL validated L3 configurations.  \sa ivb_l3_configs.
> + */
> +static const struct gen_l3_config cnl_l3_configs[] = {
> +   /* SLM URB ALL DC  RO  IS   C   T */
> +   {{  0, 64, 64,  0,  0,  0,  0,  0 }},
> +   {{  0, 64,  0, 16, 48,  0,  0,  0 }},
> +   {{  0, 48,  0, 16, 64,  0,  0,  0 }},
> +   {{  0, 32,  0,  0, 96,  0,  0,  0 }},
> +   {{  0, 32, 96,  0,  0,  0,  0,  0 }},
> +   {{  0, 32,  0, 16, 80,  0,  0,  0 }},
> +   {{ 32, 16, 80,  0,  0,  0,  0,  0 }},
> +   {{ 32, 16,  0, 64, 16,  0,  0,  0 }},
> +   {{ 32,  0, 96,  0,  0,  0,  0,  0 }},
> +   {{ 0 }}
> +};
> +
> +/**
>   * Return a zero-terminated array of validated L3 configurations for the
>   * specified device.
>   */
> @@ -130,11 +147,13 @@ get_l3_configs(const struct gen_device_info *devinfo)
>return (devinfo->is_cherryview ? chv_l3_configs : bdw_l3_configs);
>  
> case 9:
> -   case 10:
>if (devinfo->l3_banks == 1)
>   return bxt_2x6_l3_configs;
>return chv_l3_configs;
>  
> +   case 10:
> +  return cnl_l3_configs;
> +
> default:
>unreachable("Not implemented");
> }
> -- 
> 2.9.4


signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH V3] i965/cnl: Add l3 configuration for Cannonlake

[Anuj Phogat]

From: Ben Widawsky 

V2 (Anuj):
Squash the changes in one patch rebase on master.
Address the review comments made by Francisco Jerez.
Do the URB allocation per slice (not per bank).

V3 (Anuj):
Update the comment.
Format the table as other l3 config tables.

Signed-off-by: Ben Widawsky 
Signed-off-by: Anuj Phogat 
Cc: Francisco Jerez 
---
V1 was sent out with the heading:
"i965/cnl: Properly handle l3 configuration"
---
 src/intel/common/gen_l3_config.c | 21 -
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/src/intel/common/gen_l3_config.c b/src/intel/common/gen_l3_config.c
index 21ee5ca..aff13c0 100644
--- a/src/intel/common/gen_l3_config.c
+++ b/src/intel/common/gen_l3_config.c
@@ -116,6 +116,23 @@ static const struct gen_l3_config bxt_2x6_l3_configs[] = {
 };
 
 /**
+ * CNL validated L3 configurations.  \sa ivb_l3_configs.
+ */
+static const struct gen_l3_config cnl_l3_configs[] = {
+   /* SLM URB ALL DC  RO  IS   C   T */
+   {{  0, 64, 64,  0,  0,  0,  0,  0 }},
+   {{  0, 64,  0, 16, 48,  0,  0,  0 }},
+   {{  0, 48,  0, 16, 64,  0,  0,  0 }},
+   {{  0, 32,  0,  0, 96,  0,  0,  0 }},
+   {{  0, 32, 96,  0,  0,  0,  0,  0 }},
+   {{  0, 32,  0, 16, 80,  0,  0,  0 }},
+   {{ 32, 16, 80,  0,  0,  0,  0,  0 }},
+   {{ 32, 16,  0, 64, 16,  0,  0,  0 }},
+   {{ 32,  0, 96,  0,  0,  0,  0,  0 }},
+   {{ 0 }}
+};
+
+/**
  * Return a zero-terminated array of validated L3 configurations for the
  * specified device.
  */
@@ -130,11 +147,13 @@ get_l3_configs(const struct gen_device_info *devinfo)
   return (devinfo->is_cherryview ? chv_l3_configs : bdw_l3_configs);
 
case 9:
-   case 10:
   if (devinfo->l3_banks == 1)
  return bxt_2x6_l3_configs;
   return chv_l3_configs;
 
+   case 10:
+  return cnl_l3_configs;
+
default:
   unreachable("Not implemented");
}
-- 
2.9.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev