Re: [Mesa-dev] [PATCH kmscube 1/2] common: use %llx to print modifier

2017-04-29 Thread Rob Clark 
On Sat, Apr 29, 2017 at 5:00 AM, Lucas Stach  wrote:
> Am Freitag, den 28.04.2017, 14:17 -0400 schrieb Rob Clark:
>> I guess this applies on top of one of Ben's in-flight patches?
>> Perhaps it can be squashed into that?  (Otherwise remind me about
>> this
>> when the modifiers patchset is merged)
>
> It applies on top of what is currently in FDO mesa/kmscube. It seems
> the modifier patchset has been merged there.

my bad.. seems I should rename my remotes, since "origin" is still my
old github tree.. I was looking in the wrong place ;-)
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH kmscube 1/2] common: use %llx to print modifier

2017-04-29 Thread Lucas Stach 
Am Freitag, den 28.04.2017, 14:17 -0400 schrieb Rob Clark:
> I guess this applies on top of one of Ben's in-flight patches?
> Perhaps it can be squashed into that?  (Otherwise remind me about
> this
> when the modifiers patchset is merged)

It applies on top of what is currently in FDO mesa/kmscube. It seems
the modifier patchset has been merged there.

Regards,
Lucas

> BR,
> -R
> 
> On Fri, Apr 28, 2017 at 12:18 PM, Lucas Stach  > wrote:
> > Use long long format when printing the format modifier, as a simple
> > long is only 4 bytes on 32bit systems.
> > 
> > Signed-off-by: Lucas Stach 
> > ---
> >  drm-common.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drm-common.c b/drm-common.c
> > index 2f2c918596a4..fb4ec7f4389e 100644
> > --- a/drm-common.c
> > +++ b/drm-common.c
> > @@ -73,7 +73,7 @@ struct drm_fb * drm_fb_get_from_bo(struct gbm_bo
> > *bo)
> > 
> > if (modifiers[0]) {
> > flags = DRM_MODE_FB_MODIFIERS;
> > -   printf("Using modifier %lx\n", modifiers[0]);
> > +   printf("Using modifier %llx\n", modifiers[0]);
> > }
> > 
> > ret = drmModeAddFB2WithModifiers(drm_fd, width, height,
> > --
> > 2.11.0
> > 
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH kmscube 1/2] common: use %llx to print modifier

2017-04-28 Thread Ben Widawsky 

Fix kmscube -A on i915 :P

On 17-04-28 14:17:34, Rob Clark wrote:

I guess this applies on top of one of Ben's in-flight patches?
Perhaps it can be squashed into that?  (Otherwise remind me about this
when the modifiers patchset is merged)

BR,
-R

On Fri, Apr 28, 2017 at 12:18 PM, Lucas Stach  wrote:

Use long long format when printing the format modifier, as a simple
long is only 4 bytes on 32bit systems.

Signed-off-by: Lucas Stach 
---
 drm-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drm-common.c b/drm-common.c
index 2f2c918596a4..fb4ec7f4389e 100644
--- a/drm-common.c
+++ b/drm-common.c
@@ -73,7 +73,7 @@ struct drm_fb * drm_fb_get_from_bo(struct gbm_bo *bo)

if (modifiers[0]) {
flags = DRM_MODE_FB_MODIFIERS;
-   printf("Using modifier %lx\n", modifiers[0]);
+   printf("Using modifier %llx\n", modifiers[0]);
}

ret = drmModeAddFB2WithModifiers(drm_fd, width, height,
--
2.11.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH kmscube 1/2] common: use %llx to print modifier

2017-04-28 Thread Rob Clark 
I guess this applies on top of one of Ben's in-flight patches?
Perhaps it can be squashed into that?  (Otherwise remind me about this
when the modifiers patchset is merged)

BR,
-R

On Fri, Apr 28, 2017 at 12:18 PM, Lucas Stach  wrote:
> Use long long format when printing the format modifier, as a simple
> long is only 4 bytes on 32bit systems.
>
> Signed-off-by: Lucas Stach 
> ---
>  drm-common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drm-common.c b/drm-common.c
> index 2f2c918596a4..fb4ec7f4389e 100644
> --- a/drm-common.c
> +++ b/drm-common.c
> @@ -73,7 +73,7 @@ struct drm_fb * drm_fb_get_from_bo(struct gbm_bo *bo)
>
> if (modifiers[0]) {
> flags = DRM_MODE_FB_MODIFIERS;
> -   printf("Using modifier %lx\n", modifiers[0]);
> +   printf("Using modifier %llx\n", modifiers[0]);
> }
>
> ret = drmModeAddFB2WithModifiers(drm_fd, width, height,
> --
> 2.11.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH kmscube 1/2] common: use %llx to print modifier

2017-04-28 Thread Lucas Stach 
Use long long format when printing the format modifier, as a simple
long is only 4 bytes on 32bit systems.

Signed-off-by: Lucas Stach 
---
 drm-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drm-common.c b/drm-common.c
index 2f2c918596a4..fb4ec7f4389e 100644
--- a/drm-common.c
+++ b/drm-common.c
@@ -73,7 +73,7 @@ struct drm_fb * drm_fb_get_from_bo(struct gbm_bo *bo)
 
if (modifiers[0]) {
flags = DRM_MODE_FB_MODIFIERS;
-   printf("Using modifier %lx\n", modifiers[0]);
+   printf("Using modifier %llx\n", modifiers[0]);
}
 
ret = drmModeAddFB2WithModifiers(drm_fd, width, height,
-- 
2.11.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev