Re: [Mesa-dev] [PATCH mesa] egl: remove duplicate 0 assignment

2017-02-14 Thread Tapani Pälli

Reviewed-by: Tapani Pälli 

On 02/15/2017 12:21 AM, Eric Engestrom wrote:

From: Eric Engestrom 

The memset on the line before already takes care of this.

Signed-off-by: Eric Engestrom 
---
  src/egl/main/eglimage.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/src/egl/main/eglimage.c b/src/egl/main/eglimage.c
index 818b5975cd..d062cbfe01 100644
--- a/src/egl/main/eglimage.c
+++ b/src/egl/main/eglimage.c
@@ -46,9 +46,6 @@ _eglParseImageAttribList(_EGLImageAttribs *attrs, _EGLDisplay 
*dpy,
 (void) dpy;
  
 memset(attrs, 0, sizeof(*attrs));

-   attrs->ImagePreserved = EGL_FALSE;
-   attrs->GLTextureLevel = 0;
-   attrs->GLTextureZOffset = 0;
  
 if (!attrib_list)

return err;



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH mesa] egl: remove duplicate 0 assignment

2017-02-14 Thread Eric Engestrom
From: Eric Engestrom 

The memset on the line before already takes care of this.

Signed-off-by: Eric Engestrom 
---
 src/egl/main/eglimage.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/egl/main/eglimage.c b/src/egl/main/eglimage.c
index 818b5975cd..d062cbfe01 100644
--- a/src/egl/main/eglimage.c
+++ b/src/egl/main/eglimage.c
@@ -46,9 +46,6 @@ _eglParseImageAttribList(_EGLImageAttribs *attrs, _EGLDisplay 
*dpy,
(void) dpy;
 
memset(attrs, 0, sizeof(*attrs));
-   attrs->ImagePreserved = EGL_FALSE;
-   attrs->GLTextureLevel = 0;
-   attrs->GLTextureZOffset = 0;
 
if (!attrib_list)
   return err;
-- 
Cheers,
  Eric
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev