Re: [Mesa-dev] [PATCH mesa] i965: add missing `const` in function signature

[Ben Widawsky]

On 17-08-24 11:01:34, Matt Turner wrote:

Reviewed-by: Matt Turner 


I'm blaming this one on someone else's rebase ;-)
Reviewed-by: Ben Widawsky 


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH mesa] i965: add missing `const` in function signature

[Matt Turner]

Reviewed-by: Matt Turner 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH mesa] i965: add missing `const` in function signature

[Eric Engestrom]

Gets rid of a few warnings of the form:
  src/mesa/drivers/dri/i965/intel_screen.c:918:49: warning: passing argument 2 
of ‘modifier_is_supported’ discards ‘const’ qualifier from pointer target type 
[-Wdiscarded-qualifiers]
  !modifier_is_supported(>devinfo, f, 0, modifier))
   ^
  src/mesa/drivers/dri/i965/intel_screen.c:301:1: note: expected ‘struct 
intel_image_format *’ but argument is of type ‘const struct intel_image_format 
*’

Fixes: 1efd73df39b39589d26f "i965: Advertise the CCS modifier"
Cc: Ben Widawsky 
Signed-off-by: Eric Engestrom 
---
 src/mesa/drivers/dri/i965/intel_screen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/intel_screen.c 
b/src/mesa/drivers/dri/i965/intel_screen.c
index 579554f4ba..f98475997d 100644
--- a/src/mesa/drivers/dri/i965/intel_screen.c
+++ b/src/mesa/drivers/dri/i965/intel_screen.c
@@ -299,7 +299,7 @@ static const struct {
 
 static bool
 modifier_is_supported(const struct gen_device_info *devinfo,
-  struct intel_image_format *fmt, int dri_format,
+  const struct intel_image_format *fmt, int dri_format,
   uint64_t modifier)
 {
const struct isl_drm_modifier_info *modinfo =
-- 
Cheers,
  Eric

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev