Re: [Mesa-dev] [PATCH mesa] radv: drop unused variable

2018-12-05 Thread Samuel Pitoiset 
So my compiler doesn't want to show me warnings? That's something I 
would need to fix up. Anyways,


Reviewed-by: Samuel Pitoiset 

On 12/5/18 4:44 PM, Eric Engestrom wrote:

Added in 824cfc1ee5e0aba15b676 "radv: rework the TC-compat HTILE
hardware bug with COND_EXEC", but it is unused.

Signed-off-by: Eric Engestrom 
---
  src/amd/vulkan/radv_cmd_buffer.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 23909a0f7dda537bf9a1..945442d7b97974f780b2 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -1278,7 +1278,6 @@ radv_update_tc_compat_zrange_metadata(struct 
radv_cmd_buffer *cmd_buffer,
  struct radv_image *image,
  VkClearDepthStencilValue ds_clear_value)
  {
-   struct radeon_cmdbuf *cs = cmd_buffer->cs;
uint64_t va = radv_buffer_get_va(image->bo);
va += image->offset + image->tc_compat_zrange_offset;
uint32_t cond_val;


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH mesa] radv: drop unused variable

2018-12-05 Thread Bas Nieuwenhuizen 
Reviewed-by: Bas Nieuwenhuizen 
On Wed, Dec 5, 2018 at 4:44 PM Eric Engestrom  wrote:
>
> Added in 824cfc1ee5e0aba15b676 "radv: rework the TC-compat HTILE
> hardware bug with COND_EXEC", but it is unused.
>
> Signed-off-by: Eric Engestrom 
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c 
> b/src/amd/vulkan/radv_cmd_buffer.c
> index 23909a0f7dda537bf9a1..945442d7b97974f780b2 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -1278,7 +1278,6 @@ radv_update_tc_compat_zrange_metadata(struct 
> radv_cmd_buffer *cmd_buffer,
>   struct radv_image *image,
>   VkClearDepthStencilValue ds_clear_value)
>  {
> -   struct radeon_cmdbuf *cs = cmd_buffer->cs;
> uint64_t va = radv_buffer_get_va(image->bo);
> va += image->offset + image->tc_compat_zrange_offset;
> uint32_t cond_val;
> --
> Cheers,
>   Eric
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH mesa] radv: drop unused variable

2018-12-05 Thread Eric Engestrom 
Added in 824cfc1ee5e0aba15b676 "radv: rework the TC-compat HTILE
hardware bug with COND_EXEC", but it is unused.

Signed-off-by: Eric Engestrom 
---
 src/amd/vulkan/radv_cmd_buffer.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 23909a0f7dda537bf9a1..945442d7b97974f780b2 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -1278,7 +1278,6 @@ radv_update_tc_compat_zrange_metadata(struct 
radv_cmd_buffer *cmd_buffer,
  struct radv_image *image,
  VkClearDepthStencilValue ds_clear_value)
 {
-   struct radeon_cmdbuf *cs = cmd_buffer->cs;
uint64_t va = radv_buffer_get_va(image->bo);
va += image->offset + image->tc_compat_zrange_offset;
uint32_t cond_val;
-- 
Cheers,
  Eric

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev