Re: [Mesa-dev] [PATCH mesa 7/8] eglapi: make sure list is always sorted

2017-02-21 Thread Eric Engestrom 
On Monday, 2017-02-20 19:49:59 +, Emil Velikov wrote:
> On 19 February 2017 at 23:23, Eric Engestrom  wrote:
> > Starting with the next commit, badly sorting this list will break the
> > eglGetProcAddress().
> >
> > Signed-off-by: Eric Engestrom 
> > ---
> >  src/egl/Makefile.am  | 3 ++-
> >  src/egl/egl-entrypoint-check | 4 
> >  2 files changed, 6 insertions(+), 1 deletion(-)
> >  create mode 100755 src/egl/egl-entrypoint-check
> >
> > diff --git a/src/egl/Makefile.am b/src/egl/Makefile.am
> > index bd8903f666..6c0548d856 100644
> > --- a/src/egl/Makefile.am
> > +++ b/src/egl/Makefile.am
> > @@ -126,7 +126,8 @@ egl_HEADERS = \
> > $(top_srcdir)/include/EGL/eglmesaext.h \
> > $(top_srcdir)/include/EGL/eglplatform.h
> >
> > -TESTS = egl-symbols-check
> > +TESTS = egl-symbols-check \
> > +   egl-entrypoint-check
> >
> >  EXTRA_DIST = \
> > egl-symbols-check \
> Maybe:
> 
> - egl-symbols-check \
> +$(TESTS) \

Coming as a separate patch.

> 
> > diff --git a/src/egl/egl-entrypoint-check b/src/egl/egl-entrypoint-check
> > new file mode 100755
> > index 00..d3757aae3c
> > --- /dev/null
> > +++ b/src/egl/egl-entrypoint-check
> > @@ -0,0 +1,4 @@
> > +#!/bin/bash
> Please add a blank line.
> 
> > +entrypoints=$(grep EGL_ENTRYPOINT "$srcdir"/main/eglentrypoint.def)
> > +sorted=$(sort <<< "$entrypoints")
> > +test "$entrypoints" = "$sorted"
> Cannot spot any bashisms here. checkbashisms also cannot find any.
> s|bash|sh| in the shebang ?

Fixed locally; I'll send a v2 later.

> 
> Thanks to the cleanup Eric !
> Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH mesa 7/8] eglapi: make sure list is always sorted

2017-02-20 Thread Emil Velikov 
On 19 February 2017 at 23:23, Eric Engestrom  wrote:
> Starting with the next commit, badly sorting this list will break the
> eglGetProcAddress().
>
> Signed-off-by: Eric Engestrom 
> ---
>  src/egl/Makefile.am  | 3 ++-
>  src/egl/egl-entrypoint-check | 4 
>  2 files changed, 6 insertions(+), 1 deletion(-)
>  create mode 100755 src/egl/egl-entrypoint-check
>
> diff --git a/src/egl/Makefile.am b/src/egl/Makefile.am
> index bd8903f666..6c0548d856 100644
> --- a/src/egl/Makefile.am
> +++ b/src/egl/Makefile.am
> @@ -126,7 +126,8 @@ egl_HEADERS = \
> $(top_srcdir)/include/EGL/eglmesaext.h \
> $(top_srcdir)/include/EGL/eglplatform.h
>
> -TESTS = egl-symbols-check
> +TESTS = egl-symbols-check \
> +   egl-entrypoint-check
>
>  EXTRA_DIST = \
> egl-symbols-check \
Maybe:

- egl-symbols-check \
+$(TESTS) \

> diff --git a/src/egl/egl-entrypoint-check b/src/egl/egl-entrypoint-check
> new file mode 100755
> index 00..d3757aae3c
> --- /dev/null
> +++ b/src/egl/egl-entrypoint-check
> @@ -0,0 +1,4 @@
> +#!/bin/bash
Please add a blank line.

> +entrypoints=$(grep EGL_ENTRYPOINT "$srcdir"/main/eglentrypoint.def)
> +sorted=$(sort <<< "$entrypoints")
> +test "$entrypoints" = "$sorted"
Cannot spot any bashisms here. checkbashisms also cannot find any.
s|bash|sh| in the shebang ?

Thanks to the cleanup Eric !
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH mesa 7/8] eglapi: make sure list is always sorted

2017-02-19 Thread Eric Engestrom 
Starting with the next commit, badly sorting this list will break the
eglGetProcAddress().

Signed-off-by: Eric Engestrom 
---
 src/egl/Makefile.am  | 3 ++-
 src/egl/egl-entrypoint-check | 4 
 2 files changed, 6 insertions(+), 1 deletion(-)
 create mode 100755 src/egl/egl-entrypoint-check

diff --git a/src/egl/Makefile.am b/src/egl/Makefile.am
index bd8903f666..6c0548d856 100644
--- a/src/egl/Makefile.am
+++ b/src/egl/Makefile.am
@@ -126,7 +126,8 @@ egl_HEADERS = \
$(top_srcdir)/include/EGL/eglmesaext.h \
$(top_srcdir)/include/EGL/eglplatform.h
 
-TESTS = egl-symbols-check
+TESTS = egl-symbols-check \
+   egl-entrypoint-check
 
 EXTRA_DIST = \
egl-symbols-check \
diff --git a/src/egl/egl-entrypoint-check b/src/egl/egl-entrypoint-check
new file mode 100755
index 00..d3757aae3c
--- /dev/null
+++ b/src/egl/egl-entrypoint-check
@@ -0,0 +1,4 @@
+#!/bin/bash
+entrypoints=$(grep EGL_ENTRYPOINT "$srcdir"/main/eglentrypoint.def)
+sorted=$(sort <<< "$entrypoints")
+test "$entrypoints" = "$sorted"
-- 
Cheers,
  Eric

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev