Re: [Mesa-dev] [PATCH v1] i965/batch/debug: Allow log be dumped before assert

2018-11-05 Thread Kenneth Graunke 
On Monday, November 5, 2018 5:02:49 AM PST Sergii Romantsov wrote:
> Message that may show the culprit of assert now will
> be dumped before that for debug purposes.
> 
> CC: Kenneth Graunke 
> CC: Lionel G Landwerlin 
> Signed-off-by: Sergii Romantsov 
> ---
>  src/mesa/drivers/dri/i965/intel_batchbuffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c 
> b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
> index 8b769ea..353fcba 100644
> --- a/src/mesa/drivers/dri/i965/intel_batchbuffer.c
> +++ b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
> @@ -725,10 +725,10 @@ execbuffer(int fd,
>  
>/* Update brw_bo::gtt_offset */
>if (batch->validation_list[i].offset != bo->gtt_offset) {
> - assert(!(bo->kflags & EXEC_OBJECT_PINNED));
>   DBG("BO %d migrated: 0x%" PRIx64 " -> 0x%llx\n",
>   bo->gem_handle, bo->gtt_offset,
>   batch->validation_list[i].offset);
> + assert(!(bo->kflags & EXEC_OBJECT_PINNED));
>   bo->gtt_offset = batch->validation_list[i].offset;
>}
> }
> 

Pushed, thank you!


signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v1] i965/batch/debug: Allow log be dumped before assert

2018-11-05 Thread Lionel Landwerlin 

Reviewed-by: Lionel Landwerlin 

On 05/11/2018 14:02, Sergii Romantsov wrote:

Message that may show the culprit of assert now will
be dumped before that for debug purposes.

CC: Kenneth Graunke 
CC: Lionel G Landwerlin 
Signed-off-by: Sergii Romantsov 
---
  src/mesa/drivers/dri/i965/intel_batchbuffer.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c 
b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
index 8b769ea..353fcba 100644
--- a/src/mesa/drivers/dri/i965/intel_batchbuffer.c
+++ b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
@@ -725,10 +725,10 @@ execbuffer(int fd,
  
/* Update brw_bo::gtt_offset */

if (batch->validation_list[i].offset != bo->gtt_offset) {
- assert(!(bo->kflags & EXEC_OBJECT_PINNED));
   DBG("BO %d migrated: 0x%" PRIx64 " -> 0x%llx\n",
   bo->gem_handle, bo->gtt_offset,
   batch->validation_list[i].offset);
+ assert(!(bo->kflags & EXEC_OBJECT_PINNED));
   bo->gtt_offset = batch->validation_list[i].offset;
}
 }



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v1] i965/batch/debug: Allow log be dumped before assert

2018-11-05 Thread Sergii Romantsov 
Message that may show the culprit of assert now will
be dumped before that for debug purposes.

CC: Kenneth Graunke 
CC: Lionel G Landwerlin 
Signed-off-by: Sergii Romantsov 
---
 src/mesa/drivers/dri/i965/intel_batchbuffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c 
b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
index 8b769ea..353fcba 100644
--- a/src/mesa/drivers/dri/i965/intel_batchbuffer.c
+++ b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
@@ -725,10 +725,10 @@ execbuffer(int fd,
 
   /* Update brw_bo::gtt_offset */
   if (batch->validation_list[i].offset != bo->gtt_offset) {
- assert(!(bo->kflags & EXEC_OBJECT_PINNED));
  DBG("BO %d migrated: 0x%" PRIx64 " -> 0x%llx\n",
  bo->gem_handle, bo->gtt_offset,
  batch->validation_list[i].offset);
+ assert(!(bo->kflags & EXEC_OBJECT_PINNED));
  bo->gtt_offset = batch->validation_list[i].offset;
   }
}
-- 
2.7.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev