Re: [Mesa-dev] [PATCH v2] autotools: library-dependency when no sse and 32-bit

2018-11-01 Thread Dylan Baker 
Please feel free to CC me on the meson patch.

Quoting Sergii Romantsov (2018-11-01 03:46:46)
> Hi,
> meson doesn't fail, but, probably, better to add for sure.
> Will do soon.
> 
> On Thu, Nov 1, 2018 at 12:25 PM Lionel Landwerlin <
> lionel.g.landwer...@intel.com> wrote:
> 
> Hi Sergii,
> 
> Do we need the same fix in meson?
> 
> Thanks,
> 
> -
> Lionel
> 
> On 01/11/2018 07:25, Sergii Romantsov wrote:
> 
> Thanks, Dylan.
> Could, please, somebody push it?
> 
> On Tue, Oct 30, 2018 at 5:30 PM Dylan Baker 
> wrote:
> 
> Reviewed-by: Dylan Baker 
> 
> Quoting Sergii Romantsov (2018-10-30 02:45:14)
> > Building of 32bit Mesa may fail if __SSE__ is not specified.
> > Added missed dependency from libm.
> >
> > CC: Dylan Baker 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560
> > Signed-off-by: Sergii Romantsov 
>  >
> > ---
> >  src/util/Makefile.am | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/util/Makefile.am b/src/util/Makefile.am
> > index d79f2b3..85c7553 100644
> > --- a/src/util/Makefile.am
> > +++ b/src/util/Makefile.am
> > @@ -60,7 +60,8 @@ libmesautil_la_LIBADD = \
> >         $(PTHREAD_LIBS) \
> >         $(CLOCK_LIB) \
> >         $(ZLIB_LIBS) \
> > -       $(LIBATOMIC_LIBS)
> > +       $(LIBATOMIC_LIBS) \
> > +       -lm
> > 
> >  libxmlconfig_la_SOURCES = $(XMLCONFIG_FILES)
> >  libxmlconfig_la_CFLAGS = \
> > --
> > 2.7.4
> >
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> 
> 
> --
> Sergii Romantsov
> GlobalLogic Inc.
> www.globallogic.com
> 
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> 
> 
> 
> 
> --
> Sergii Romantsov
> GlobalLogic Inc.
> www.globallogic.com


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] autotools: library-dependency when no sse and 32-bit

2018-11-01 Thread Sergii Romantsov 
Hi,
meson doesn't fail, but, probably, better to add for sure.
Will do soon.

On Thu, Nov 1, 2018 at 12:25 PM Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:

> Hi Sergii,
>
> Do we need the same fix in meson?
>
> Thanks,
>
> -
> Lionel
>
> On 01/11/2018 07:25, Sergii Romantsov wrote:
>
> Thanks, Dylan.
> Could, please, somebody push it?
>
> On Tue, Oct 30, 2018 at 5:30 PM Dylan Baker  wrote:
>
>> Reviewed-by: Dylan Baker 
>>
>> Quoting Sergii Romantsov (2018-10-30 02:45:14)
>> > Building of 32bit Mesa may fail if __SSE__ is not specified.
>> > Added missed dependency from libm.
>> >
>> > CC: Dylan Baker 
>> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560
>> > Signed-off-by: Sergii Romantsov 
>> > ---
>> >  src/util/Makefile.am | 3 ++-
>> >  1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/src/util/Makefile.am b/src/util/Makefile.am
>> > index d79f2b3..85c7553 100644
>> > --- a/src/util/Makefile.am
>> > +++ b/src/util/Makefile.am
>> > @@ -60,7 +60,8 @@ libmesautil_la_LIBADD = \
>> > $(PTHREAD_LIBS) \
>> > $(CLOCK_LIB) \
>> > $(ZLIB_LIBS) \
>> > -   $(LIBATOMIC_LIBS)
>> > +   $(LIBATOMIC_LIBS) \
>> > +   -lm
>> >
>> >  libxmlconfig_la_SOURCES = $(XMLCONFIG_FILES)
>> >  libxmlconfig_la_CFLAGS = \
>> > --
>> > 2.7.4
>> >
>> ___
>> mesa-dev mailing list
>> mesa-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
>
>
> --
> Sergii Romantsov
> GlobalLogic Inc.
> www.globallogic.com
>
> ___
> mesa-dev mailing 
> listmesa-dev@lists.freedesktop.orghttps://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>
>

-- 
Sergii Romantsov
GlobalLogic Inc.
www.globallogic.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] autotools: library-dependency when no sse and 32-bit

2018-11-01 Thread Lionel Landwerlin 

Hi Sergii,

Do we need the same fix in meson?

Thanks,

-
Lionel

On 01/11/2018 07:25, Sergii Romantsov wrote:

Thanks, Dylan.
Could, please, somebody push it?

On Tue, Oct 30, 2018 at 5:30 PM Dylan Baker > wrote:


Reviewed-by: Dylan Baker mailto:dy...@pnwbakers.com>>

Quoting Sergii Romantsov (2018-10-30 02:45:14)
> Building of 32bit Mesa may fail if __SSE__ is not specified.
> Added missed dependency from libm.
>
> CC: Dylan Baker mailto:dy...@pnwbakers.com>>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560
> Signed-off-by: Sergii Romantsov
mailto:sergii.romant...@globallogic.com>>
> ---
>  src/util/Makefile.am | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/util/Makefile.am b/src/util/Makefile.am
> index d79f2b3..85c7553 100644
> --- a/src/util/Makefile.am
> +++ b/src/util/Makefile.am
> @@ -60,7 +60,8 @@ libmesautil_la_LIBADD = \
>         $(PTHREAD_LIBS) \
>         $(CLOCK_LIB) \
>         $(ZLIB_LIBS) \
> -       $(LIBATOMIC_LIBS)
> +       $(LIBATOMIC_LIBS) \
> +       -lm
>
>  libxmlconfig_la_SOURCES = $(XMLCONFIG_FILES)
>  libxmlconfig_la_CFLAGS = \
> --
> 2.7.4
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org 
https://lists.freedesktop.org/mailman/listinfo/mesa-dev



--
Sergii Romantsov
GlobalLogic Inc.
www.globallogic.com 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] autotools: library-dependency when no sse and 32-bit

2018-11-01 Thread Sergii Romantsov 
Thanks, Dylan.
Could, please, somebody push it?

On Tue, Oct 30, 2018 at 5:30 PM Dylan Baker  wrote:

> Reviewed-by: Dylan Baker 
>
> Quoting Sergii Romantsov (2018-10-30 02:45:14)
> > Building of 32bit Mesa may fail if __SSE__ is not specified.
> > Added missed dependency from libm.
> >
> > CC: Dylan Baker 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560
> > Signed-off-by: Sergii Romantsov 
> > ---
> >  src/util/Makefile.am | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/util/Makefile.am b/src/util/Makefile.am
> > index d79f2b3..85c7553 100644
> > --- a/src/util/Makefile.am
> > +++ b/src/util/Makefile.am
> > @@ -60,7 +60,8 @@ libmesautil_la_LIBADD = \
> > $(PTHREAD_LIBS) \
> > $(CLOCK_LIB) \
> > $(ZLIB_LIBS) \
> > -   $(LIBATOMIC_LIBS)
> > +   $(LIBATOMIC_LIBS) \
> > +   -lm
> >
> >  libxmlconfig_la_SOURCES = $(XMLCONFIG_FILES)
> >  libxmlconfig_la_CFLAGS = \
> > --
> > 2.7.4
> >
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>


-- 
Sergii Romantsov
GlobalLogic Inc.
www.globallogic.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] autotools: library-dependency when no sse and 32-bit

2018-10-30 Thread Dylan Baker 
Reviewed-by: Dylan Baker 

Quoting Sergii Romantsov (2018-10-30 02:45:14)
> Building of 32bit Mesa may fail if __SSE__ is not specified.
> Added missed dependency from libm.
> 
> CC: Dylan Baker 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560
> Signed-off-by: Sergii Romantsov 
> ---
>  src/util/Makefile.am | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/util/Makefile.am b/src/util/Makefile.am
> index d79f2b3..85c7553 100644
> --- a/src/util/Makefile.am
> +++ b/src/util/Makefile.am
> @@ -60,7 +60,8 @@ libmesautil_la_LIBADD = \
> $(PTHREAD_LIBS) \
> $(CLOCK_LIB) \
> $(ZLIB_LIBS) \
> -   $(LIBATOMIC_LIBS)
> +   $(LIBATOMIC_LIBS) \
> +   -lm
>  
>  libxmlconfig_la_SOURCES = $(XMLCONFIG_FILES)
>  libxmlconfig_la_CFLAGS = \
> -- 
> 2.7.4
> 


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2] autotools: library-dependency when no sse and 32-bit

2018-10-30 Thread Sergii Romantsov 
Building of 32bit Mesa may fail if __SSE__ is not specified.
Added missed dependency from libm.

CC: Dylan Baker 
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560
Signed-off-by: Sergii Romantsov 
---
 src/util/Makefile.am | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/util/Makefile.am b/src/util/Makefile.am
index d79f2b3..85c7553 100644
--- a/src/util/Makefile.am
+++ b/src/util/Makefile.am
@@ -60,7 +60,8 @@ libmesautil_la_LIBADD = \
$(PTHREAD_LIBS) \
$(CLOCK_LIB) \
$(ZLIB_LIBS) \
-   $(LIBATOMIC_LIBS)
+   $(LIBATOMIC_LIBS) \
+   -lm
 
 libxmlconfig_la_SOURCES = $(XMLCONFIG_FILES)
 libxmlconfig_la_CFLAGS = \
-- 
2.7.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev