Re: [Mesa-dev] [PATCH v2] i915, i965: Fix memory leak in intel_miptree_create_for_bo.

[Chad Versace]

On 09/27/2013 10:20 PM, Vinson Lee wrote:

Fixes Resource leak defects reported by Coverity.

Signed-off-by: Vinson Lee v...@freedesktop.org


Thanks. Committed.

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2] i915, i965: Fix memory leak in intel_miptree_create_for_bo.

[Vinson Lee]

Fixes Resource leak defects reported by Coverity.

Signed-off-by: Vinson Lee v...@freedesktop.org
---
 src/mesa/drivers/dri/i915/intel_mipmap_tree.c | 4 +++-
 src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i915/intel_mipmap_tree.c 
b/src/mesa/drivers/dri/i915/intel_mipmap_tree.c
index 8432b6d..984eeaa 100644
--- a/src/mesa/drivers/dri/i915/intel_mipmap_tree.c
+++ b/src/mesa/drivers/dri/i915/intel_mipmap_tree.c
@@ -264,8 +264,10 @@ intel_miptree_create_for_bo(struct intel_context *intel,
 0, 0,
 width, height, 1,
 true);
-   if (!mt)
+   if (!mt) {
+  free(region);
   return mt;
+   }
 
region-cpp = mt-cpp;
region-width = width;
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c 
b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
index 36a080f..6cdd6b5 100644
--- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
+++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
@@ -626,8 +626,10 @@ intel_miptree_create_for_bo(struct brw_context *brw,
 0, 0,
 width, height, 1,
 true, 0 /* num_samples */);
-   if (!mt)
+   if (!mt) {
+  free(region);
   return mt;
+   }
 
region-cpp = mt-cpp;
region-width = width;
-- 
1.8.3.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2] i915, i965: Fix memory leak in intel_miptree_create_for_bo.

[Vinson Lee]

Fixes Resource leak defects reported by Coverity.

Signed-off-by: Vinson Lee v...@freedesktop.org
---
 src/mesa/drivers/dri/i915/intel_mipmap_tree.c | 4 +++-
 src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i915/intel_mipmap_tree.c 
b/src/mesa/drivers/dri/i915/intel_mipmap_tree.c
index 8432b6d..984eeaa 100644
--- a/src/mesa/drivers/dri/i915/intel_mipmap_tree.c
+++ b/src/mesa/drivers/dri/i915/intel_mipmap_tree.c
@@ -264,8 +264,10 @@ intel_miptree_create_for_bo(struct intel_context *intel,
 0, 0,
 width, height, 1,
 true);
-   if (!mt)
+   if (!mt) {
+  free(region);
   return mt;
+   }
 
region-cpp = mt-cpp;
region-width = width;
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c 
b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
index 36a080f..6cdd6b5 100644
--- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
+++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
@@ -626,8 +626,10 @@ intel_miptree_create_for_bo(struct brw_context *brw,
 0, 0,
 width, height, 1,
 true, 0 /* num_samples */);
-   if (!mt)
+   if (!mt) {
+  free(region);
   return mt;
+   }
 
region-cpp = mt-cpp;
region-width = width;
-- 
1.8.3.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2] i915, i965: Fix memory leak in intel_miptree_create_for_bo.

[Vinson Lee]

Fixes Resource leak defects reported by coverity.

Signed-off-by: Vinson Lee v...@freedesktop.org
---
 src/mesa/drivers/dri/i915/intel_mipmap_tree.c | 4 +++-
 src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i915/intel_mipmap_tree.c 
b/src/mesa/drivers/dri/i915/intel_mipmap_tree.c
index 8432b6d..984eeaa 100644
--- a/src/mesa/drivers/dri/i915/intel_mipmap_tree.c
+++ b/src/mesa/drivers/dri/i915/intel_mipmap_tree.c
@@ -264,8 +264,10 @@ intel_miptree_create_for_bo(struct intel_context *intel,
 0, 0,
 width, height, 1,
 true);
-   if (!mt)
+   if (!mt) {
+  free(region);
   return mt;
+   }
 
region-cpp = mt-cpp;
region-width = width;
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c 
b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
index 36a080f..6cdd6b5 100644
--- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
+++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
@@ -626,8 +626,10 @@ intel_miptree_create_for_bo(struct brw_context *brw,
 0, 0,
 width, height, 1,
 true, 0 /* num_samples */);
-   if (!mt)
+   if (!mt) {
+  free(region);
   return mt;
+   }
 
region-cpp = mt-cpp;
region-width = width;
-- 
1.8.3.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev