Re: [Mesa-dev] [PATCH v2] mesa: Avoid set comprehension.

2017-07-05 Thread Dylan Baker
Reviewed-by: Dylan Baker 

Quoting Vinson Lee (2017-07-05 11:38:36)
> Fix build error on CentOS 6.9 with Python 2.6.
> 
>   GENmain/format_fallback.c
>   File "./main/format_fallback.py", line 42
> names = {fmt.name for fmt in formats}
> ^
> SyntaxError: invalid syntax
> 
> Fixes: a1983223d883 ("mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]")
> Signed-off-by: Vinson Lee 
> ---
>  src/mesa/main/format_fallback.py |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/mesa/main/format_fallback.py 
> b/src/mesa/main/format_fallback.py
> index e3b9916..da88bd5 100644
> --- a/src/mesa/main/format_fallback.py
> +++ b/src/mesa/main/format_fallback.py
> @@ -39,7 +39,7 @@ def parse_args():
>  return p.parse_args()
>  
>  def get_rgbx_to_rgba_map(formats):
> -names = {fmt.name for fmt in formats}
> +names = set(fmt.name for fmt in formats)
>  
>  for fmt in formats:
>  if not fmt.has_channel('r') or not fmt.has_channel('x'):
> -- 
> 1.7.1
> 


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH v2] mesa: Avoid set comprehension.

2017-07-05 Thread Vinson Lee
Fix build error on CentOS 6.9 with Python 2.6.

  GENmain/format_fallback.c
  File "./main/format_fallback.py", line 42
names = {fmt.name for fmt in formats}
^
SyntaxError: invalid syntax

Fixes: a1983223d883 ("mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]")
Signed-off-by: Vinson Lee 
---
 src/mesa/main/format_fallback.py |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mesa/main/format_fallback.py b/src/mesa/main/format_fallback.py
index e3b9916..da88bd5 100644
--- a/src/mesa/main/format_fallback.py
+++ b/src/mesa/main/format_fallback.py
@@ -39,7 +39,7 @@ def parse_args():
 return p.parse_args()
 
 def get_rgbx_to_rgba_map(formats):
-names = {fmt.name for fmt in formats}
+names = set(fmt.name for fmt in formats)
 
 for fmt in formats:
 if not fmt.has_channel('r') or not fmt.has_channel('x'):
-- 
1.7.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev