Re: [Mesa-dev] [PATCH v2 00/11] Initial glsl + i965 barrier support
On Saturday, April 25, 2015 09:45:49 PM Jordan Justen wrote: git://people.freedesktop.org/~jljusten/mesa i965-barrier-v2 This series had a fair amount of comments r-b from v1. Patches 9 10 probably would be the most import to look at. Chris Forbes (2): glsl: Add ir node for barrier glsl: Add builtin barrier() function Jordan Justen (9): nir: Add barrier intrinsic function i965: Add GATEWAY_SFID definitions i965/inst: Add gateway_notify and gateway_subfuncid fields i965: Disassemble Gateway SEND messages i965: Add notification register i965: Add brw_WAIT to emit wait instruction i965: Add brw_barrier to emit a Gateway Barrier SEND i965/fs: Implement support for ir_barrier i965/nir: Support barrier intrinsic function I skimmed this series and it looks good to me. It looks like Chris already reviewed most of it, and Ben and Matt reviewed a few patches as well - that's totally sufficient in my book, so I'm going to skip looking at the details. :) signature.asc Description: This is a digitally signed message part. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH v2 00/11] Initial glsl + i965 barrier support
git://people.freedesktop.org/~jljusten/mesa i965-barrier-v2 This series had a fair amount of comments r-b from v1. Patches 9 10 probably would be the most import to look at. Chris Forbes (2): glsl: Add ir node for barrier glsl: Add builtin barrier() function Jordan Justen (9): nir: Add barrier intrinsic function i965: Add GATEWAY_SFID definitions i965/inst: Add gateway_notify and gateway_subfuncid fields i965: Disassemble Gateway SEND messages i965: Add notification register i965: Add brw_WAIT to emit wait instruction i965: Add brw_barrier to emit a Gateway Barrier SEND i965/fs: Implement support for ir_barrier i965/nir: Support barrier intrinsic function src/glsl/builtin_functions.cpp | 29 +++ src/glsl/ir.h | 24 src/glsl/ir_hierarchical_visitor.cpp | 9 + src/glsl/ir_hierarchical_visitor.h | 1 + src/glsl/ir_hv_accept.cpp | 6 +++ src/glsl/ir_print_visitor.cpp | 5 +++ src/glsl/ir_print_visitor.h| 1 + src/glsl/ir_visitor.h | 2 + src/glsl/nir/glsl_to_nir.cpp | 9 + src/glsl/nir/nir_intrinsics.h | 1 + src/mesa/drivers/dri/i965/brw_defines.h| 13 +++ src/mesa/drivers/dri/i965/brw_disasm.c | 16 src/mesa/drivers/dri/i965/brw_eu.h | 4 ++ src/mesa/drivers/dri/i965/brw_eu_emit.c| 51 ++ src/mesa/drivers/dri/i965/brw_fs.h | 4 ++ src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 11 ++ src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 4 ++ src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 31 src/mesa/drivers/dri/i965/brw_inst.h | 14 +-- src/mesa/drivers/dri/i965/brw_reg.h| 16 src/mesa/drivers/dri/i965/brw_shader.cpp | 3 ++ src/mesa/drivers/dri/i965/brw_vec4.h | 1 + src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 6 +++ src/mesa/program/ir_to_mesa.cpp| 7 src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 7 25 files changed, 272 insertions(+), 3 deletions(-) -- 2.1.4 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
