Re: [Mesa-dev] [PATCH v2 00/20] i965 basic CS program generation support
On Monday, April 27, 2015 05:44:48 PM Kenneth Graunke wrote: > On Friday, April 24, 2015 04:32:52 PM Jordan Justen wrote: > > git://people.freedesktop.org/~jljusten/mesa i965-cs-prog-v2 > > > > These patches could use review: > > * [08/20] i965/fs: Add emit_cs_terminate to emit CS_OPCODE_CS_TERMINATE > > * [10/20] i965/cs: Add generator support for CS_OPCODE_CS_TERMINATE > > * [13/20] i965/fs: Support compute programs in fs_visitor > > * [14/20] i965/cs: Add max_cs_threads > > * [15/20] i965/cs: Emit compute shader code and upload programs > > * [16/20] i965: Add brw_setup_tex_for_precompile. Use in VS, GS & FS. > > * [17/20] i965/cs: Support CS program precompile > > * [18/20] i965: Remove comment about chv device numbers relating to hsw gt1 > > * [19/20] i965/cs: Upload brw_cs_state > > * [20/20] i965/fs: Add CS shader time support > > Patch 19 is Acked-by, the rest are Reviewed-by, assuming you incorporate > my suggestions. Nice work as usual! Thanks Jordan! Oh, sorry, I didn't actually review the thread count patch. I'm not completely following how that's used in order to verify the values. signature.asc Description: This is a digitally signed message part. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v2 00/20] i965 basic CS program generation support
On Friday, April 24, 2015 04:32:52 PM Jordan Justen wrote: > git://people.freedesktop.org/~jljusten/mesa i965-cs-prog-v2 > > These patches could use review: > * [08/20] i965/fs: Add emit_cs_terminate to emit CS_OPCODE_CS_TERMINATE > * [10/20] i965/cs: Add generator support for CS_OPCODE_CS_TERMINATE > * [13/20] i965/fs: Support compute programs in fs_visitor > * [14/20] i965/cs: Add max_cs_threads > * [15/20] i965/cs: Emit compute shader code and upload programs > * [16/20] i965: Add brw_setup_tex_for_precompile. Use in VS, GS & FS. > * [17/20] i965/cs: Support CS program precompile > * [18/20] i965: Remove comment about chv device numbers relating to hsw gt1 > * [19/20] i965/cs: Upload brw_cs_state > * [20/20] i965/fs: Add CS shader time support Patch 19 is Acked-by, the rest are Reviewed-by, assuming you incorporate my suggestions. Nice work as usual! Thanks Jordan! signature.asc Description: This is a digitally signed message part. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH v2 00/20] i965 basic CS program generation support
git://people.freedesktop.org/~jljusten/mesa i965-cs-prog-v2 These patches could use review: * [08/20] i965/fs: Add emit_cs_terminate to emit CS_OPCODE_CS_TERMINATE * [10/20] i965/cs: Add generator support for CS_OPCODE_CS_TERMINATE * [13/20] i965/fs: Support compute programs in fs_visitor * [14/20] i965/cs: Add max_cs_threads * [15/20] i965/cs: Emit compute shader code and upload programs * [16/20] i965: Add brw_setup_tex_for_precompile. Use in VS, GS & FS. * [17/20] i965/cs: Support CS program precompile * [18/20] i965: Remove comment about chv device numbers relating to hsw gt1 * [19/20] i965/cs: Upload brw_cs_state * [20/20] i965/fs: Add CS shader time support v2: * Incorporate feedback from v1 * Dropped "i965/cs: Emit gen code for CS_OPCODE_CS_TERMINATE" and instead move into use "i965/fs: Add emit_cs_terminate to emit CS_OPCODE_CS_TERMINATE" and "i965/cs: Add generator support for CS_OPCODE_CS_TERMINATE" * Fixed/verified scratch memory * Implemented/verified shader time Jordan Justen (14): i965/cs: Add BRW_NEW_CS_PROG_DATA and BRW_CACHE_CS_PROG i965/cs: Add CS_OPCODE_CS_TERMINATE i965/fs: Add emit_cs_terminate to emit CS_OPCODE_CS_TERMINATE i965/cs: Mark g0 as used by CS_OPCODE_CS_TERMINATE i965/cs: Add generator support for CS_OPCODE_CS_TERMINATE i965/cache: Add support for CS in program state cache i965/fs: Support compute programs in fs_visitor i965/cs: Add max_cs_threads i965/cs: Emit compute shader code and upload programs i965: Add brw_setup_tex_for_precompile. Use in VS, GS & FS. i965/cs: Support CS program precompile i965: Remove comment about chv device numbers relating to hsw gt1 i965/cs: Upload brw_cs_state i965/fs: Add CS shader time support Paul Berry (6): i965/cs: Add BRW_NEW_COMPUTE_PROGRAM state flag. mesa/cs: Add inline functions for dealing with compute shaders. mesa/cs: Update program.c for compute shaders. mesa/cs: Add compute support to update_program(). i965: Add an INTEL_DEBUG=cs option. i965/cs: Add brw_cs_prog_data, brw_cs_prog_key and brw_context::cs. src/mesa/drivers/dri/i965/Makefile.sources| 1 + src/mesa/drivers/dri/i965/brw_context.c | 3 + src/mesa/drivers/dri/i965/brw_context.h | 33 ++ src/mesa/drivers/dri/i965/brw_cs.cpp | 388 ++ src/mesa/drivers/dri/i965/brw_cs.h| 48 +++ src/mesa/drivers/dri/i965/brw_defines.h | 8 + src/mesa/drivers/dri/i965/brw_device_info.c | 16 +- src/mesa/drivers/dri/i965/brw_device_info.h | 1 + src/mesa/drivers/dri/i965/brw_fs.cpp | 104 +- src/mesa/drivers/dri/i965/brw_fs.h| 15 + src/mesa/drivers/dri/i965/brw_fs_generator.cpp| 35 ++ src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 4 + src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 42 +++ src/mesa/drivers/dri/i965/brw_program.c | 13 +- src/mesa/drivers/dri/i965/brw_shader.cpp | 6 + src/mesa/drivers/dri/i965/brw_shader.h| 3 + src/mesa/drivers/dri/i965/brw_state.h | 1 + src/mesa/drivers/dri/i965/brw_state_cache.c | 3 + src/mesa/drivers/dri/i965/brw_state_dump.c| 3 + src/mesa/drivers/dri/i965/brw_state_upload.c | 12 + src/mesa/drivers/dri/i965/brw_vec4.cpp| 13 +- src/mesa/drivers/dri/i965/intel_debug.c | 3 +- src/mesa/drivers/dri/i965/intel_debug.h | 1 + src/mesa/main/state.c | 21 ++ src/mesa/program/program.c| 3 + src/mesa/program/program.h| 22 ++ 26 files changed, 768 insertions(+), 34 deletions(-) create mode 100644 src/mesa/drivers/dri/i965/brw_cs.cpp create mode 100644 src/mesa/drivers/dri/i965/brw_cs.h -- 2.1.4 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
