Re: [Mesa-dev] [PATCH v2 02/15] i965/fs: Don't force MASK_DISABLE on INDIRECT_MOV instructions

[Jason Ekstrand]

On Thu, Apr 7, 2016 at 2:16 PM, Matt Turner  wrote:

> On Tue, Mar 22, 2016 at 3:33 PM, Jason Ekstrand 
> wrote:
> > It should work fine without it and the visitor can set it if it wants.
> > ---
>
> Does this need to be a separate patch? Ease of testing or something?
>

Mostly that it's conceptually different from the patch that does the rest
of the reworks and I wanted it to be bisectable.
--Jason
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 02/15] i965/fs: Don't force MASK_DISABLE on INDIRECT_MOV instructions

[Matt Turner]

On Tue, Mar 22, 2016 at 3:33 PM, Jason Ekstrand  wrote:
> It should work fine without it and the visitor can set it if it wants.
> ---

Does this need to be a separate patch? Ease of testing or something?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2 02/15] i965/fs: Don't force MASK_DISABLE on INDIRECT_MOV instructions

[Jason Ekstrand]

It should work fine without it and the visitor can set it if it wants.
---
 src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp 
b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
index c883fe3..35400cb 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
@@ -366,7 +366,6 @@ fs_generator::generate_mov_indirect(fs_inst *inst,
assert(inst->exec_size == 8 || devinfo->gen >= 8);
 
brw_MOV(p, addr, indirect_byte_offset);
-   brw_inst_set_mask_control(devinfo, brw_last_inst, BRW_MASK_DISABLE);
brw_MOV(p, dst, retype(brw_VxH_indirect(0, imm_byte_offset), dst.type));
 }
 
-- 
2.5.0.400.gff86faf

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev