Re: [Mesa-dev] [PATCH v2 03/15] i965/fs: Fix regs_read() for MOV_INDIRECT with a non-zero subnr

2016-04-07 Thread Jason Ekstrand 
On Thu, Apr 7, 2016 at 2:30 PM, Matt Turner  wrote:

> On Tue, Mar 22, 2016 at 3:33 PM, Jason Ekstrand 
> wrote:
> > The subnr field is in bytes so we don't need to multiply by type_sz.
> > ---
> >  src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
> b/src/mesa/drivers/dri/i965/brw_fs.cpp
> > index 7d15794..d41c8a8 100644
> > --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
> > +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
> > @@ -870,7 +870,7 @@ fs_inst::regs_read(int arg) const
> >   * unread portion at the beginning.
> >   */
> >  if (src[0].subnr)
> > -   region_length += src[0].subnr * type_sz(src[0].type);
> > +   region_length += src[0].subnr;
>
> Looks correct... so is this code just unused today?
>

I think so.  The uses of MOV_INDIRECT are pretty simple today.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 03/15] i965/fs: Fix regs_read() for MOV_INDIRECT with a non-zero subnr

2016-04-07 Thread Matt Turner 
On Tue, Mar 22, 2016 at 3:33 PM, Jason Ekstrand  wrote:
> The subnr field is in bytes so we don't need to multiply by type_sz.
> ---
>  src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp 
> b/src/mesa/drivers/dri/i965/brw_fs.cpp
> index 7d15794..d41c8a8 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
> @@ -870,7 +870,7 @@ fs_inst::regs_read(int arg) const
>   * unread portion at the beginning.
>   */
>  if (src[0].subnr)
> -   region_length += src[0].subnr * type_sz(src[0].type);
> +   region_length += src[0].subnr;

Looks correct... so is this code just unused today?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2 03/15] i965/fs: Fix regs_read() for MOV_INDIRECT with a non-zero subnr

2016-03-22 Thread Jason Ekstrand 
The subnr field is in bytes so we don't need to multiply by type_sz.
---
 src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp 
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 7d15794..d41c8a8 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
@@ -870,7 +870,7 @@ fs_inst::regs_read(int arg) const
  * unread portion at the beginning.
  */
 if (src[0].subnr)
-   region_length += src[0].subnr * type_sz(src[0].type);
+   region_length += src[0].subnr;
 
 return DIV_ROUND_UP(region_length, REG_SIZE);
  } else {
-- 
2.5.0.400.gff86faf

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev