Re: [Mesa-dev] [PATCH v2 19/32] vulkan/wsi: Only wait on semaphores on the first swapchain

2017-12-01 Thread Chad Versace
On Tue 28 Nov 2017, Jason Ekstrand wrote:
> ---
>  src/vulkan/wsi/wsi_common.c | 9 +++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

Smart. I was expecting a patch like this after reading patch 17.
Reviewed-by: Chad Versace 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH v2 19/32] vulkan/wsi: Only wait on semaphores on the first swapchain

2017-11-28 Thread Jason Ekstrand
---
 src/vulkan/wsi/wsi_common.c | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/vulkan/wsi/wsi_common.c b/src/vulkan/wsi/wsi_common.c
index f149846..4f6648f 100644
--- a/src/vulkan/wsi/wsi_common.c
+++ b/src/vulkan/wsi/wsi_common.c
@@ -541,9 +541,14 @@ wsi_common_queue_present(const struct wsi_device *wsi,
   VkSubmitInfo submit_info = {
  .sType = VK_STRUCTURE_TYPE_SUBMIT_INFO,
  .pNext = NULL,
- .waitSemaphoreCount = pPresentInfo->waitSemaphoreCount,
- .pWaitSemaphores = pPresentInfo->pWaitSemaphores,
   };
+  if (i == 0) {
+ /* We only need/want to wait on semaphores once.  After that, we're
+  * guaranteed ordering since it all happens on the same queue.
+  */
+ submit_info.waitSemaphoreCount = pPresentInfo->waitSemaphoreCount,
+ submit_info.pWaitSemaphores = pPresentInfo->pWaitSemaphores,
+  }
   result = wsi->QueueSubmit(queue, 1, _info, swapchain->fences[0]);
   if (result != VK_SUCCESS)
  goto fail_present;
-- 
2.5.0.400.gff86faf

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev