Re: [Mesa-dev] [PATCH v2 5/5] panfrost: Print errors from kernel

2019-08-07 Thread Tomeu Vizoso 
On Thu, 8 Aug 2019 at 00:52, Rob Herring  wrote:
>
> On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso  
> wrote:
> >
> > Signed-off-by: Tomeu Vizoso 
> > Reviewed-by: Alyssa Rosenzweig 
> > ---
> >  src/gallium/drivers/panfrost/pan_drm.c | 10 +-
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/src/gallium/drivers/panfrost/pan_drm.c 
> > b/src/gallium/drivers/panfrost/pan_drm.c
> > index 71eda2d1e328..36a6b975680a 100644
> > --- a/src/gallium/drivers/panfrost/pan_drm.c
> > +++ b/src/gallium/drivers/panfrost/pan_drm.c
> > @@ -49,14 +49,14 @@ panfrost_drm_mmap_bo(struct panfrost_screen *screen, 
> > struct panfrost_bo *bo)
> >
> >  ret = drmIoctl(screen->fd, DRM_IOCTL_PANFROST_MMAP_BO, _bo);
> >  if (ret) {
> > -fprintf(stderr, "DRM_IOCTL_PANFROST_MMAP_BO failed: %d\n", 
> > ret);
> > +fprintf(stderr, "DRM_IOCTL_PANFROST_MMAP_BO failed: %m\n");
>
> Is this going to work on Android and bionic?

Yep: 
https://android.googlesource.com/platform/bionic/+/refs/heads/master/libc/stdio/vfprintf.cpp#455

Musl and uClibc also support it.

Cheers,

Tomeu

> stderr goes to /dev/null
> anyways on Android, so probably not a big deal.
>
> Rob
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 5/5] panfrost: Print errors from kernel

2019-08-07 Thread Alyssa Rosenzweig 
> Is this going to work on Android and bionic? stderr goes to /dev/null
> anyways on Android, so probably not a big deal.

Tomeu said yes.


signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 5/5] panfrost: Print errors from kernel

2019-08-07 Thread Rob Herring 
On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso  wrote:
>
> Signed-off-by: Tomeu Vizoso 
> Reviewed-by: Alyssa Rosenzweig 
> ---
>  src/gallium/drivers/panfrost/pan_drm.c | 10 +-
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/gallium/drivers/panfrost/pan_drm.c 
> b/src/gallium/drivers/panfrost/pan_drm.c
> index 71eda2d1e328..36a6b975680a 100644
> --- a/src/gallium/drivers/panfrost/pan_drm.c
> +++ b/src/gallium/drivers/panfrost/pan_drm.c
> @@ -49,14 +49,14 @@ panfrost_drm_mmap_bo(struct panfrost_screen *screen, 
> struct panfrost_bo *bo)
>
>  ret = drmIoctl(screen->fd, DRM_IOCTL_PANFROST_MMAP_BO, _bo);
>  if (ret) {
> -fprintf(stderr, "DRM_IOCTL_PANFROST_MMAP_BO failed: %d\n", 
> ret);
> +fprintf(stderr, "DRM_IOCTL_PANFROST_MMAP_BO failed: %m\n");

Is this going to work on Android and bionic? stderr goes to /dev/null
anyways on Android, so probably not a big deal.

Rob
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2 5/5] panfrost: Print errors from kernel

2019-08-07 Thread Tomeu Vizoso 
Signed-off-by: Tomeu Vizoso 
Reviewed-by: Alyssa Rosenzweig 
---
 src/gallium/drivers/panfrost/pan_drm.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/gallium/drivers/panfrost/pan_drm.c 
b/src/gallium/drivers/panfrost/pan_drm.c
index 71eda2d1e328..36a6b975680a 100644
--- a/src/gallium/drivers/panfrost/pan_drm.c
+++ b/src/gallium/drivers/panfrost/pan_drm.c
@@ -49,14 +49,14 @@ panfrost_drm_mmap_bo(struct panfrost_screen *screen, struct 
panfrost_bo *bo)
 
 ret = drmIoctl(screen->fd, DRM_IOCTL_PANFROST_MMAP_BO, _bo);
 if (ret) {
-fprintf(stderr, "DRM_IOCTL_PANFROST_MMAP_BO failed: %d\n", 
ret);
+fprintf(stderr, "DRM_IOCTL_PANFROST_MMAP_BO failed: %m\n");
 assert(0);
 }
 
 bo->cpu = os_mmap(NULL, bo->size, PROT_READ | PROT_WRITE, MAP_SHARED,
   screen->fd, mmap_bo.offset);
 if (bo->cpu == MAP_FAILED) {
-fprintf(stderr, "mmap failed: %p\n", bo->cpu);
+fprintf(stderr, "mmap failed: %p %m\n", bo->cpu);
 assert(0);
 }
 
@@ -122,7 +122,7 @@ panfrost_drm_create_bo(struct panfrost_screen *screen, 
size_t size,
 
 ret = drmIoctl(screen->fd, DRM_IOCTL_PANFROST_CREATE_BO, 
_bo);
 if (ret) {
-fprintf(stderr, "DRM_IOCTL_PANFROST_CREATE_BO failed: 
%d\n", ret);
+fprintf(stderr, "DRM_IOCTL_PANFROST_CREATE_BO failed: 
%m\n");
 assert(0);
 }
 
@@ -176,7 +176,7 @@ panfrost_drm_release_bo(struct panfrost_screen *screen, 
struct panfrost_bo *bo,
 
 ret = drmIoctl(screen->fd, DRM_IOCTL_GEM_CLOSE, _close);
 if (ret) {
-fprintf(stderr, "DRM_IOCTL_GEM_CLOSE failed: %d\n", ret);
+fprintf(stderr, "DRM_IOCTL_GEM_CLOSE failed: %m\n");
 assert(0);
 }
 
@@ -332,7 +332,7 @@ panfrost_fence_create(struct panfrost_context *ctx)
  */
 drmSyncobjExportSyncFile(screen->fd, ctx->out_sync, >fd);
 if (f->fd == -1) {
-fprintf(stderr, "export failed\n");
+fprintf(stderr, "export failed: %m\n");
 free(f);
 return NULL;
 }
-- 
2.20.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev