Re: [Mesa-dev] [PATCH v3] mesa/meson: 32bit xmlconfig linkage
Quoting Sergii Romantsov (2018-09-09 23:52:04) > Hello, > just reminder for case: don't have push-rights... > > On Fri, Sep 7, 2018 at 8:05 PM, Dylan Baker wrote: > > Quoting Sergii Romantsov (2018-09-07 02:43:41) > > Building of 32bit mesa with meson causes linkage issue: > > "undefined reference to `util_get_process_name'" > > Fixed by adding link-with mesa_util for xmlconfig primary. > > > > v2: Removed '[]', commit message corrected. > > > > v3: Reverted changes in gbm and glx libraries. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107843 > > Fixes: 2e1e6511f76370870b5cd "util: extract get_process_name from > xmlconfig.c" > > Cc: Marek Ol\u0161ák > > Cc: Dylan Baker > > Signed-off-by: Sergii Romantsov > > Reviewed-by: Eric Engestrom > > --- > > src/util/meson.build | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/util/meson.build b/src/util/meson.build > > index a4ff0b9..e3d96b6 100644 > > --- a/src/util/meson.build > > +++ b/src/util/meson.build > > @@ -117,6 +117,7 @@ libxmlconfig = static_library( > > 'xmlconfig', > > files_xmlconfig, > > include_directories : inc_common, > > + link_with : libmesa_util, > > dependencies : [dep_expat, dep_m], > > c_args : [ > > c_msvc_compat_args, c_vis_args, > > -- > > 2.7.4 > > > > Reviewed-by: Dylan Baker > Sorry about that, I'm running a quick build test than I'll push. Dylan signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v3] mesa/meson: 32bit xmlconfig linkage
Hello, just reminder for case: don't have push-rights... On Fri, Sep 7, 2018 at 8:05 PM, Dylan Baker wrote: > Quoting Sergii Romantsov (2018-09-07 02:43:41) > > Building of 32bit mesa with meson causes linkage issue: > > "undefined reference to `util_get_process_name'" > > Fixed by adding link-with mesa_util for xmlconfig primary. > > > > v2: Removed '[]', commit message corrected. > > > > v3: Reverted changes in gbm and glx libraries. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107843 > > Fixes: 2e1e6511f76370870b5cd "util: extract get_process_name from > xmlconfig.c" > > Cc: Marek Ol\u0161ák > > Cc: Dylan Baker > > Signed-off-by: Sergii Romantsov > > Reviewed-by: Eric Engestrom > > --- > > src/util/meson.build | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/util/meson.build b/src/util/meson.build > > index a4ff0b9..e3d96b6 100644 > > --- a/src/util/meson.build > > +++ b/src/util/meson.build > > @@ -117,6 +117,7 @@ libxmlconfig = static_library( > >'xmlconfig', > >files_xmlconfig, > >include_directories : inc_common, > > + link_with : libmesa_util, > >dependencies : [dep_expat, dep_m], > >c_args : [ > > c_msvc_compat_args, c_vis_args, > > -- > > 2.7.4 > > > > Reviewed-by: Dylan Baker > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > -- Sergii Romantsov GlobalLogic Inc. www.globallogic.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v3] mesa/meson: 32bit xmlconfig linkage
Quoting Sergii Romantsov (2018-09-07 02:43:41) > Building of 32bit mesa with meson causes linkage issue: > "undefined reference to `util_get_process_name'" > Fixed by adding link-with mesa_util for xmlconfig primary. > > v2: Removed '[]', commit message corrected. > > v3: Reverted changes in gbm and glx libraries. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107843 > Fixes: 2e1e6511f76370870b5cd "util: extract get_process_name from xmlconfig.c" > Cc: Marek Ol\u0161ák > Cc: Dylan Baker > Signed-off-by: Sergii Romantsov > Reviewed-by: Eric Engestrom > --- > src/util/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/util/meson.build b/src/util/meson.build > index a4ff0b9..e3d96b6 100644 > --- a/src/util/meson.build > +++ b/src/util/meson.build > @@ -117,6 +117,7 @@ libxmlconfig = static_library( >'xmlconfig', >files_xmlconfig, >include_directories : inc_common, > + link_with : libmesa_util, >dependencies : [dep_expat, dep_m], >c_args : [ > c_msvc_compat_args, c_vis_args, > -- > 2.7.4 > Reviewed-by: Dylan Baker signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH v3] mesa/meson: 32bit xmlconfig linkage
Building of 32bit mesa with meson causes linkage issue: "undefined reference to `util_get_process_name'" Fixed by adding link-with mesa_util for xmlconfig primary. v2: Removed '[]', commit message corrected. v3: Reverted changes in gbm and glx libraries. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107843 Fixes: 2e1e6511f76370870b5cd "util: extract get_process_name from xmlconfig.c" Cc: Marek Olšák Cc: Dylan Baker Signed-off-by: Sergii Romantsov Reviewed-by: Eric Engestrom --- src/util/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/meson.build b/src/util/meson.build index a4ff0b9..e3d96b6 100644 --- a/src/util/meson.build +++ b/src/util/meson.build @@ -117,6 +117,7 @@ libxmlconfig = static_library( 'xmlconfig', files_xmlconfig, include_directories : inc_common, + link_with : libmesa_util, dependencies : [dep_expat, dep_m], c_args : [ c_msvc_compat_args, c_vis_args, -- 2.7.4 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
