Re: [Mesa-dev] [PATCH v3 1/6] vulkan: enum generator: align function declarations/prototypes

[Jason Ekstrand]

I went ahead and pushed v2 of the series with some of chad's comments
addressed.  Thanks for reviewing!

On Thu, Sep 21, 2017 at 5:14 PM, Chad Versace 
wrote:

> On Thu 21 Sep 2017, Jason Ekstrand wrote:
> > From: Lionel Landwerlin 
> >
> > Signed-off-by: Lionel Landwerlin 
> > Acked-by: Jason Ekstrand 
> > ---
> >  src/vulkan/util/gen_enum_to_str.py | 42 +++---
> 
> >  1 file changed, 21 insertions(+), 21 deletions(-)
>
> Patch 1 is
> Reviewed-by: Chad Versace 
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 1/6] vulkan: enum generator: align function declarations/prototypes

[Chad Versace]

On Thu 21 Sep 2017, Jason Ekstrand wrote:
> From: Lionel Landwerlin 
> 
> Signed-off-by: Lionel Landwerlin 
> Acked-by: Jason Ekstrand 
> ---
>  src/vulkan/util/gen_enum_to_str.py | 42 
> +++---
>  1 file changed, 21 insertions(+), 21 deletions(-)

Patch 1 is
Reviewed-by: Chad Versace 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 1/6] vulkan: enum generator: align function declarations/prototypes

[Dylan Baker]

Thanks for updating. For the series:
Reviewed-by: Dylan Baker 

Quoting Jason Ekstrand (2017-09-21 14:19:43)
> From: Lionel Landwerlin 
> 
> Signed-off-by: Lionel Landwerlin 
> Acked-by: Jason Ekstrand 
> ---
>  src/vulkan/util/gen_enum_to_str.py | 42 
> +++---
>  1 file changed, 21 insertions(+), 21 deletions(-)
> 
> diff --git a/src/vulkan/util/gen_enum_to_str.py 
> b/src/vulkan/util/gen_enum_to_str.py
> index df326d0..aa7001e 100644
> --- a/src/vulkan/util/gen_enum_to_str.py
> +++ b/src/vulkan/util/gen_enum_to_str.py
> @@ -64,27 +64,27 @@ C_TEMPLATE = Template(textwrap.dedent(u"""\
>  
>  % for enum in enums:
>  
> -const char *
> -vk_${enum.name[2:]}_to_str(${enum.name} input)
> -{
> -switch(input) {
> -% for v in enum.values:
> -% if v in FOREIGN_ENUM_VALUES:
> -
> -#pragma GCC diagnostic push
> -#pragma GCC diagnostic ignored "-Wswitch"
> -% endif
> -case ${v}:
> -return "${v}";
> -% if v in FOREIGN_ENUM_VALUES:
> -#pragma GCC diagnostic pop
> -
> -% endif
> -% endfor
> -default:
> -unreachable("Undefined enum value.");
> -}
> +const char *
> +vk_${enum.name[2:]}_to_str(${enum.name} input)
> +{
> +switch(input) {
> +% for v in enum.values:
> +% if v in FOREIGN_ENUM_VALUES:
> +
> +#pragma GCC diagnostic push
> +#pragma GCC diagnostic ignored "-Wswitch"
> +% endif
> +case ${v}:
> +return "${v}";
> +% if v in FOREIGN_ENUM_VALUES:
> +#pragma GCC diagnostic pop
> +
> +% endif
> +% endfor
> +default:
> +unreachable("Undefined enum value.");
>  }
> +}
>  %endfor"""),
>  output_encoding='utf-8')
>  
> @@ -102,7 +102,7 @@ H_TEMPLATE = Template(textwrap.dedent(u"""\
>  #include 
>  
>  % for enum in enums:
> -const char * vk_${enum.name[2:]}_to_str(${enum.name} input);
> +const char * vk_${enum.name[2:]}_to_str(${enum.name} input);
>  % endfor
>  
>  #endif"""),
> -- 
> 2.5.0.400.gff86faf
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v3 1/6] vulkan: enum generator: align function declarations/prototypes

[Jason Ekstrand]

From: Lionel Landwerlin 

Signed-off-by: Lionel Landwerlin 
Acked-by: Jason Ekstrand 
---
 src/vulkan/util/gen_enum_to_str.py | 42 +++---
 1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/src/vulkan/util/gen_enum_to_str.py 
b/src/vulkan/util/gen_enum_to_str.py
index df326d0..aa7001e 100644
--- a/src/vulkan/util/gen_enum_to_str.py
+++ b/src/vulkan/util/gen_enum_to_str.py
@@ -64,27 +64,27 @@ C_TEMPLATE = Template(textwrap.dedent(u"""\
 
 % for enum in enums:
 
-const char *
-vk_${enum.name[2:]}_to_str(${enum.name} input)
-{
-switch(input) {
-% for v in enum.values:
-% if v in FOREIGN_ENUM_VALUES:
-
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wswitch"
-% endif
-case ${v}:
-return "${v}";
-% if v in FOREIGN_ENUM_VALUES:
-#pragma GCC diagnostic pop
-
-% endif
-% endfor
-default:
-unreachable("Undefined enum value.");
-}
+const char *
+vk_${enum.name[2:]}_to_str(${enum.name} input)
+{
+switch(input) {
+% for v in enum.values:
+% if v in FOREIGN_ENUM_VALUES:
+
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wswitch"
+% endif
+case ${v}:
+return "${v}";
+% if v in FOREIGN_ENUM_VALUES:
+#pragma GCC diagnostic pop
+
+% endif
+% endfor
+default:
+unreachable("Undefined enum value.");
 }
+}
 %endfor"""),
 output_encoding='utf-8')
 
@@ -102,7 +102,7 @@ H_TEMPLATE = Template(textwrap.dedent(u"""\
 #include 
 
 % for enum in enums:
-const char * vk_${enum.name[2:]}_to_str(${enum.name} input);
+const char * vk_${enum.name[2:]}_to_str(${enum.name} input);
 % endfor
 
 #endif"""),
-- 
2.5.0.400.gff86faf

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev