Re: [Mesa-dev] [PATCH v3 2/6] vulkan: enum generator: sort enums by names

2017-09-21 Thread Chad Versace 
On Thu 21 Sep 2017, Jason Ekstrand wrote:
> From: Lionel Landwerlin 
> 
> Signed-off-by: Lionel Landwerlin 
> Reviewed-by: Jason Ekstrand 
> ---
>  src/vulkan/util/gen_enum_to_str.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/vulkan/util/gen_enum_to_str.py 
> b/src/vulkan/util/gen_enum_to_str.py
> index aa7001e..efe5d4f 100644
> --- a/src/vulkan/util/gen_enum_to_str.py
> +++ b/src/vulkan/util/gen_enum_to_str.py
> @@ -185,13 +185,14 @@ def main():
>  efactory = EnumFactory(VkEnum)
>  for filename in args.xml_files:
>  parse_xml(efactory, filename)
> +enums=sorted(efactory.registry.values(), key=lambda e: e.name)

Minor nit. The above = should have spaces around it.

Reviewed-by: Chad Versace 


>  
>  for template, file_ in [(C_TEMPLATE, os.path.join(args.outdir, 
> 'vk_enum_to_str.c')),
>  (H_TEMPLATE, os.path.join(args.outdir, 
> 'vk_enum_to_str.h'))]:
>  with open(file_, 'wb') as f:
>  f.write(template.render(
>  file=os.path.basename(__file__),
> -enums=efactory.registry.values(),
> +enums=enums,
>  copyright=COPYRIGHT,
>  FOREIGN_ENUM_VALUES=FOREIGN_ENUM_VALUES))
>  
> -- 
> 2.5.0.400.gff86faf
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v3 2/6] vulkan: enum generator: sort enums by names

2017-09-21 Thread Jason Ekstrand 
From: Lionel Landwerlin 

Signed-off-by: Lionel Landwerlin 
Reviewed-by: Jason Ekstrand 
---
 src/vulkan/util/gen_enum_to_str.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/vulkan/util/gen_enum_to_str.py 
b/src/vulkan/util/gen_enum_to_str.py
index aa7001e..efe5d4f 100644
--- a/src/vulkan/util/gen_enum_to_str.py
+++ b/src/vulkan/util/gen_enum_to_str.py
@@ -185,13 +185,14 @@ def main():
 efactory = EnumFactory(VkEnum)
 for filename in args.xml_files:
 parse_xml(efactory, filename)
+enums=sorted(efactory.registry.values(), key=lambda e: e.name)
 
 for template, file_ in [(C_TEMPLATE, os.path.join(args.outdir, 
'vk_enum_to_str.c')),
 (H_TEMPLATE, os.path.join(args.outdir, 
'vk_enum_to_str.h'))]:
 with open(file_, 'wb') as f:
 f.write(template.render(
 file=os.path.basename(__file__),
-enums=efactory.registry.values(),
+enums=enums,
 copyright=COPYRIGHT,
 FOREIGN_ENUM_VALUES=FOREIGN_ENUM_VALUES))
 
-- 
2.5.0.400.gff86faf

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev