Re: [Mesa-dev] [RFC][PATCH 4/5] mesa: implement glGet for AMD_depth_clamp_separate

2018-08-09 Thread Marek Olšák
Note that the spec says:
"Querying DEPTH_CLAMP will return TRUE if DEPTH_CLAMP_NEAR_AMD _or_
DEPTH_CLAMP_FAR_AMD is enabled."

Marek

On Wed, Aug 1, 2018 at 11:31 PM, Sagar Ghuge  wrote:
> Signed-off-by: Sagar Ghuge 
> ---
>  src/mesa/main/get.c  | 1 +
>  src/mesa/main/get_hash_params.py | 5 +
>  2 files changed, 6 insertions(+)
>
> diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
> index db0079beb5..b310f014b7 100644
> --- a/src/mesa/main/get.c
> +++ b/src/mesa/main/get.c
> @@ -468,6 +468,7 @@ EXTRA_EXT(NV_texture_rectangle);
>  EXTRA_EXT(EXT_stencil_two_side);
>  EXTRA_EXT(EXT_depth_bounds_test);
>  EXTRA_EXT(ARB_depth_clamp);
> +EXTRA_EXT(AMD_depth_clamp_separate);
>  EXTRA_EXT(ATI_fragment_shader);
>  EXTRA_EXT(EXT_provoking_vertex);
>  EXTRA_EXT(ARB_fragment_shader);
> diff --git a/src/mesa/main/get_hash_params.py 
> b/src/mesa/main/get_hash_params.py
> index 618e306e50..edf3c982d0 100644
> --- a/src/mesa/main/get_hash_params.py
> +++ b/src/mesa/main/get_hash_params.py
> @@ -982,6 +982,11 @@ descriptor=[
>
>  # GL_ARB_indirect_parameters
>[ "PARAMETER_BUFFER_BINDING_ARB", "LOC_CUSTOM, TYPE_INT, 0, 
> extra_ARB_indirect_parameters" ],
> +
> +# GL 4.1
> +# GL_AMD_depth_clamp_separate
> +  [ "DEPTH_CLAMP_NEAR_AMD", "CONTEXT_BOOL(Transform.DepthClampNear), 
> extra_AMD_depth_clamp_separate" ],
> +  [ "DEPTH_CLAMP_FAR_AMD", "CONTEXT_BOOL(Transform.DepthClampFar), 
> extra_AMD_depth_clamp_separate" ],
>  ]},
>
>  ]
> --
> 2.17.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [RFC][PATCH 4/5] mesa: implement glGet for AMD_depth_clamp_separate

2018-08-02 Thread Ian Romanick
This patch is

Reviewed-by: Ian Romanick 

On 08/01/2018 08:31 PM, Sagar Ghuge wrote:
> Signed-off-by: Sagar Ghuge 
> ---
>  src/mesa/main/get.c  | 1 +
>  src/mesa/main/get_hash_params.py | 5 +
>  2 files changed, 6 insertions(+)
> 
> diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
> index db0079beb5..b310f014b7 100644
> --- a/src/mesa/main/get.c
> +++ b/src/mesa/main/get.c
> @@ -468,6 +468,7 @@ EXTRA_EXT(NV_texture_rectangle);
>  EXTRA_EXT(EXT_stencil_two_side);
>  EXTRA_EXT(EXT_depth_bounds_test);
>  EXTRA_EXT(ARB_depth_clamp);
> +EXTRA_EXT(AMD_depth_clamp_separate);
>  EXTRA_EXT(ATI_fragment_shader);
>  EXTRA_EXT(EXT_provoking_vertex);
>  EXTRA_EXT(ARB_fragment_shader);
> diff --git a/src/mesa/main/get_hash_params.py 
> b/src/mesa/main/get_hash_params.py
> index 618e306e50..edf3c982d0 100644
> --- a/src/mesa/main/get_hash_params.py
> +++ b/src/mesa/main/get_hash_params.py
> @@ -982,6 +982,11 @@ descriptor=[
>  
>  # GL_ARB_indirect_parameters
>[ "PARAMETER_BUFFER_BINDING_ARB", "LOC_CUSTOM, TYPE_INT, 0, 
> extra_ARB_indirect_parameters" ],
> +
> +# GL 4.1
> +# GL_AMD_depth_clamp_separate
> +  [ "DEPTH_CLAMP_NEAR_AMD", "CONTEXT_BOOL(Transform.DepthClampNear), 
> extra_AMD_depth_clamp_separate" ],
> +  [ "DEPTH_CLAMP_FAR_AMD", "CONTEXT_BOOL(Transform.DepthClampFar), 
> extra_AMD_depth_clamp_separate" ],
>  ]},
>  
>  ]
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [RFC][PATCH 4/5] mesa: implement glGet for AMD_depth_clamp_separate

2018-08-01 Thread Sagar Ghuge
Signed-off-by: Sagar Ghuge 
---
 src/mesa/main/get.c  | 1 +
 src/mesa/main/get_hash_params.py | 5 +
 2 files changed, 6 insertions(+)

diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
index db0079beb5..b310f014b7 100644
--- a/src/mesa/main/get.c
+++ b/src/mesa/main/get.c
@@ -468,6 +468,7 @@ EXTRA_EXT(NV_texture_rectangle);
 EXTRA_EXT(EXT_stencil_two_side);
 EXTRA_EXT(EXT_depth_bounds_test);
 EXTRA_EXT(ARB_depth_clamp);
+EXTRA_EXT(AMD_depth_clamp_separate);
 EXTRA_EXT(ATI_fragment_shader);
 EXTRA_EXT(EXT_provoking_vertex);
 EXTRA_EXT(ARB_fragment_shader);
diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py
index 618e306e50..edf3c982d0 100644
--- a/src/mesa/main/get_hash_params.py
+++ b/src/mesa/main/get_hash_params.py
@@ -982,6 +982,11 @@ descriptor=[
 
 # GL_ARB_indirect_parameters
   [ "PARAMETER_BUFFER_BINDING_ARB", "LOC_CUSTOM, TYPE_INT, 0, 
extra_ARB_indirect_parameters" ],
+
+# GL 4.1
+# GL_AMD_depth_clamp_separate
+  [ "DEPTH_CLAMP_NEAR_AMD", "CONTEXT_BOOL(Transform.DepthClampNear), 
extra_AMD_depth_clamp_separate" ],
+  [ "DEPTH_CLAMP_FAR_AMD", "CONTEXT_BOOL(Transform.DepthClampFar), 
extra_AMD_depth_clamp_separate" ],
 ]},
 
 ]
-- 
2.17.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev