Re: [Mesa-dev] [RFC 2/8] mesa: bump required GCC version to 4.1.0
On 2014-12-14 09:22, kallisti5 wrote: On 2014-12-14 08:45, Emil Velikov wrote: On 12/12/14 11:46, Timothy Arceri wrote: Signed-off-by: Timothy Arceri --- Its been just under 5 years since the required version of GCC was set at 3.3.0 at the time it was 7 years old. I'm proposing bumping it to 4.1.0 which is almost 9 years old since its used in RHEL 5 which is still supported. For the record if it was set to 4.3.0 there would be very few version checks needed at all. Nicely done Timothy. Can we just get a confirmation from Alexander von Gluck IV. IIRC he is/was building mesa with gcc 3. Alexander, what were the details about the gcc 3 build ? I take it that you'll be ok with moving to gcc 4.1.0+ ? We'll be fine :-), we're using GCC 4.8.3 on our modern builds. We are using GCC 2.9x for the "BeOS ABI compatible" builds, but we forked Mesa 7.9.2 which seems to be the absolute last version of Mesa that will compile under GCC 2.9x :-) https://github.com/haiku/mesa_legacy Also, I sent an email about removing the SUNPRO C version checks, but it seems like it was never delivered: Nevermind, I just saw Timothy's response to that :-) -- Alex ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [RFC 2/8] mesa: bump required GCC version to 4.1.0
On 2014-12-14 08:45, Emil Velikov wrote: On 12/12/14 11:46, Timothy Arceri wrote: Signed-off-by: Timothy Arceri --- Its been just under 5 years since the required version of GCC was set at 3.3.0 at the time it was 7 years old. I'm proposing bumping it to 4.1.0 which is almost 9 years old since its used in RHEL 5 which is still supported. For the record if it was set to 4.3.0 there would be very few version checks needed at all. Nicely done Timothy. Can we just get a confirmation from Alexander von Gluck IV. IIRC he is/was building mesa with gcc 3. Alexander, what were the details about the gcc 3 build ? I take it that you'll be ok with moving to gcc 4.1.0+ ? We'll be fine :-), we're using GCC 4.8.3 on our modern builds. We are using GCC 2.9x for the "BeOS ABI compatible" builds, but we forked Mesa 7.9.2 which seems to be the absolute last version of Mesa that will compile under GCC 2.9x :-) https://github.com/haiku/mesa_legacy Also, I sent an email about removing the SUNPRO C version checks, but it seems like it was never delivered: " Why not also drop the SUNPRO_C version check? # if defined(__GNUC__) || defined(__SUNPRO_C) I downloaded SunStudio 12 (circa 2007) and __SUNPRO_C is set to 0x590. If we drop support for GCC 4.1 (2007), might as well drop older sun compilers. -- Alex #include int main() { printf("0x%X\n", __SUNPRO_C); return 0; } user@desktop bin :) $ ./cc test.c user@desktop bin :) $ ./a.out 0x590 user@desktop bin :) $ " -- Alex ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [RFC 2/8] mesa: bump required GCC version to 4.1.0
On 12/12/14 11:46, Timothy Arceri wrote: > Signed-off-by: Timothy Arceri > --- > > Its been just under 5 years since the required version > of GCC was set at 3.3.0 at the time it was 7 years old. > > I'm proposing bumping it to 4.1.0 which is almost 9 years > old since its used in RHEL 5 which is still supported. > > For the record if it was set to 4.3.0 there would be > very few version checks needed at all. > Nicely done Timothy. Can we just get a confirmation from Alexander von Gluck IV. IIRC he is/was building mesa with gcc 3. Alexander, what were the details about the gcc 3 build ? I take it that you'll be ok with moving to gcc 4.1.0+ ? Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [RFC 2/8] mesa: bump required GCC version to 4.1.0
Signed-off-by: Timothy Arceri --- Its been just under 5 years since the required version of GCC was set at 3.3.0 at the time it was 7 years old. I'm proposing bumping it to 4.1.0 which is almost 9 years old since its used in RHEL 5 which is still supported. For the record if it was set to 4.3.0 there would be very few version checks needed at all. configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 4bdf75d..cce279f 100644 --- a/configure.ac +++ b/configure.ac @@ -102,7 +102,7 @@ AC_COMPILE_IFELSE( AC_MSG_RESULT([$acv_mesa_CLANG]) -dnl If we're using GCC, make sure that it is at least version 3.3.0. Older +dnl If we're using GCC, make sure that it is at least version 4.1.0. Older dnl versions are explictly not supported. GEN_ASM_OFFSETS=no if test "x$GCC" = xyes -a "x$acv_mesa_CLANG" = xno; then @@ -116,9 +116,9 @@ if test "x$GCC" = xyes -a "x$acv_mesa_CLANG" = xno; then GCC_VERSION_MINOR=`echo $GCC_VERSION | cut -d. -f2` fi -if test $GCC_VERSION_MAJOR -lt 3 -o $GCC_VERSION_MAJOR -eq 3 -a $GCC_VERSION_MINOR -lt 3 ; then +if test $GCC_VERSION_MAJOR -lt 4 -o $GCC_VERSION_MAJOR -eq 4 -a $GCC_VERSION_MINOR -lt 1 ; then AC_MSG_RESULT([no]) -AC_MSG_ERROR([If using GCC, version 3.3.0 or later is required.]) +AC_MSG_ERROR([If using GCC, version 4.1.0 or later is required.]) else AC_MSG_RESULT([yes]) fi -- 2.1.0 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev