Re: [Mesa-dev] Mesa (master): lavapipe: bump maxMemoryAllocationCount

2021-03-18 Thread Mike Blumenkrantz 
This is mostly to deal with zink atm because there's no
allocator/suballocator in use, meaning every resource gets its own alloc.
There's a ticket (https://gitlab.freedesktop.org/mesa/mesa/-/issues/4293)
for implementing aux/pb, but I don't have a timeline for that right now.


Mike

On Wed, Mar 17, 2021 at 10:25 PM Brian Paul  wrote:

> On 3/17/21 6:12 PM, GitLab Mirror wrote:
> > Module: Mesa
> > Branch: master
> > Commit: 23100f3b6531d7055ae4d42e07bda09d991ea438
> > URL:
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcgit.freedesktop.org%2Fmesa%2Fmesa%2Fcommit%2F%3Fid%3D23100f3b6531d7055ae4d42e07bda09d991ea438data=04%7C01%7Cbrianp%40vmware.com%7Cd05b2a74f4bd48bf385208d8e9a28db1%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C637516231677082505%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=d3Ypjgh4TYqFsQDUbFCY956sLSv1hpqG4NP2OwP4it4%3Dreserved=0
> >
> > Author: Dave Airlie 
> > Date:   Wed Mar 17 13:33:14 2021 +1000
> >
> > lavapipe: bump maxMemoryAllocationCount
> >
> > not sure why this was so low
>
> 4096 is the minimum maximum that Vulkan supports.  I believe that's what
> Nvidia and AMD's Windows Vulkan drivers say.
>
> If you want your Vulkan app to be really cross-platform it's a limit to
> be aware of.
>
> -Brian
>
>
> >
> > Reviewed-By: Mike Blumenkrantz 
> > Reviewed-by: Adam Jackson 
> > Part-of: <
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fmesa%2Fmesa%2F-%2Fmerge_requests%2F9644data=04%7C01%7Cbrianp%40vmware.com%7Cd05b2a74f4bd48bf385208d8e9a28db1%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C637516231677082505%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=uzbWE3%2FG6AupVIc0kOYl8n5XcKw%2FcufKmK3tDEzhTyE%3Dreserved=0
> >
> >
> > ---
> >
> >   src/gallium/frontends/lavapipe/lvp_device.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/gallium/frontends/lavapipe/lvp_device.c
> b/src/gallium/frontends/lavapipe/lvp_device.c
> > index 61edf15dd0a..b087e2a7d68 100644
> > --- a/src/gallium/frontends/lavapipe/lvp_device.c
> > +++ b/src/gallium/frontends/lavapipe/lvp_device.c
> > @@ -574,7 +574,7 @@ VKAPI_ATTR void VKAPI_CALL
> lvp_GetPhysicalDeviceProperties(VkPhysicalDevice phys
> > .maxUniformBufferRange=
> pdevice->pscreen->get_shader_param(pdevice->pscreen, PIPE_SHADER_FRAGMENT,
> PIPE_SHADER_CAP_MAX_CONST_BUFFER_SIZE),
> > .maxStorageBufferRange=
> pdevice->pscreen->get_param(pdevice->pscreen,
> PIPE_CAP_MAX_SHADER_BUFFER_SIZE),
> > .maxPushConstantsSize =
> MAX_PUSH_CONSTANTS_SIZE,
> > -  .maxMemoryAllocationCount = 4096,
> > +  .maxMemoryAllocationCount = UINT32_MAX,
> > .maxSamplerAllocationCount= 32 * 1024,
> > .bufferImageGranularity   = 64, /* A cache line
> */
> > .sparseAddressSpaceSize   = 0,
> >
> > ___
> > mesa-commit mailing list
> > mesa-com...@lists.freedesktop.org
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-commitdata=04%7C01%7Cbrianp%40vmware.com%7Cd05b2a74f4bd48bf385208d8e9a28db1%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C637516231677082505%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=j0T9KnefIkBponHxMLxgKi8xBIMHYAydsEWV9ESBsSQ%3Dreserved=0
> >
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Mesa (master): lavapipe: bump maxMemoryAllocationCount

2021-03-17 Thread Brian Paul 

On 3/17/21 6:12 PM, GitLab Mirror wrote:

Module: Mesa
Branch: master
Commit: 23100f3b6531d7055ae4d42e07bda09d991ea438
URL:
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcgit.freedesktop.org%2Fmesa%2Fmesa%2Fcommit%2F%3Fid%3D23100f3b6531d7055ae4d42e07bda09d991ea438data=04%7C01%7Cbrianp%40vmware.com%7Cd05b2a74f4bd48bf385208d8e9a28db1%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C637516231677082505%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=d3Ypjgh4TYqFsQDUbFCY956sLSv1hpqG4NP2OwP4it4%3Dreserved=0

Author: Dave Airlie 
Date:   Wed Mar 17 13:33:14 2021 +1000

lavapipe: bump maxMemoryAllocationCount

not sure why this was so low


4096 is the minimum maximum that Vulkan supports.  I believe that's what 
Nvidia and AMD's Windows Vulkan drivers say.


If you want your Vulkan app to be really cross-platform it's a limit to 
be aware of.


-Brian




Reviewed-By: Mike Blumenkrantz 
Reviewed-by: Adam Jackson 
Part-of: 


---

  src/gallium/frontends/lavapipe/lvp_device.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/frontends/lavapipe/lvp_device.c 
b/src/gallium/frontends/lavapipe/lvp_device.c
index 61edf15dd0a..b087e2a7d68 100644
--- a/src/gallium/frontends/lavapipe/lvp_device.c
+++ b/src/gallium/frontends/lavapipe/lvp_device.c
@@ -574,7 +574,7 @@ VKAPI_ATTR void VKAPI_CALL 
lvp_GetPhysicalDeviceProperties(VkPhysicalDevice phys
.maxUniformBufferRange= 
pdevice->pscreen->get_shader_param(pdevice->pscreen, PIPE_SHADER_FRAGMENT, 
PIPE_SHADER_CAP_MAX_CONST_BUFFER_SIZE),
.maxStorageBufferRange= 
pdevice->pscreen->get_param(pdevice->pscreen, PIPE_CAP_MAX_SHADER_BUFFER_SIZE),
.maxPushConstantsSize = MAX_PUSH_CONSTANTS_SIZE,
-  .maxMemoryAllocationCount = 4096,
+  .maxMemoryAllocationCount = UINT32_MAX,
.maxSamplerAllocationCount= 32 * 1024,
.bufferImageGranularity   = 64, /* A cache line */
.sparseAddressSpaceSize   = 0,

___
mesa-commit mailing list
mesa-com...@lists.freedesktop.org
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-commitdata=04%7C01%7Cbrianp%40vmware.com%7Cd05b2a74f4bd48bf385208d8e9a28db1%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C637516231677082505%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=j0T9KnefIkBponHxMLxgKi8xBIMHYAydsEWV9ESBsSQ%3Dreserved=0



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev