Re: [Mesa-dev] Mesa 17.2.4 release candidate
On Mon, Oct 30, 2017 at 12:43 PM, Andres Gomez wrote: > On Mon, 2017-10-30 at 11:39 -0400, Ilia Mirkin wrote: >> On Mon, Oct 30, 2017 at 11:29 AM, Emil Velikov >> wrote: >> > On 28 October 2017 at 21:35, Andres Gomez wrote: >> > > On Fri, 2017-10-27 at 14:14 -0400, Ilia Mirkin wrote: >> > > > On Fri, Oct 27, 2017 at 1:43 PM, Andres Gomez >> > > > wrote: >> > > > > Rejected (6) >> > > > > >> > > > > >> > > > > Ilia Mirkin (1): >> > > > > glsl: fix derived cs variables >> > > > > >> > > > > Reason: Commit is too big for stable at this point. >> > > > >> > > > The issue it fixes in regular compute shaders is slightly difficult to >> > > > hit (but there are piglits that do now), however the issue it hits >> > > > with ARB_compute_variable_group_size is fairly trivial to encounter. >> > > > >> > > > It seems silly to put out releases with known bugs when a fix is >> > > > easily available and apply-able, with negligible risk of messing >> > > > things up. >> > > > >> > > > Note that this all only affects nouveau and radeonsi, as those are the >> > > > only drivers that make use of the lowering. >> > > >> > > Ilia, I understood by your answer [1] when I asked about your opinion >> > > regarding 17.2.4 inclusion that it was OK to omit in this series but >> > > that it should definitely be included in 17.3. >> > > >> > > Maybe I didn't make it clear that I was asking for the 17.2 queue and I >> > > misunderstood your answer (?). >> > > >> > > Let's leave it as it is for this release and will see if we can include >> > > it for the next one. >> > > >> > >> > I'm inclined to agree with Andres - let's leave the patch out of 17.2.x. >> > >> > 17.3.x on the other hand is still fairly fresh, so I've pulled the >> > patch for 17.3.0-rc2. >> >> In that case you should definitely remove >> GL_ARB_compute_variable_group_size support from that release series. > > In that case, can we get? > > * A specific less invasive solution for the 17.2 queue (don't know if >that's even possible). Invasive is in the eye of the beholder. I don't think my change is invasive at all. (But even if it were, that still shouldn't cause it to not be backported into a stable release at developer request.) > > or > > * A patch to disable the mentioned extension in the affected drivers. Feel free to do that yourself, or find someone to do it for you. Doing that will still have some bugs with regular compute shaders which piglit will run into, although it's less clear that real applications will hit it. I think at this point, I will do what I originally said I'd do last time this kind of issue came up -- stop caring about stable releases. From now on, I will no longer mark patches for stable (since doing so only seems to cause me heartache), and make sure that anyone who's trying to get help for mesa issues starts with git master, since the stable releases aren't interested in all bug fixes. (And I certainly don't have the time to re-debug issues that have already been fixed, especially ones like this which I would never have figured out in a full application, if it wasn't for the simple test case provided in the referenced bug.) Cheers, -ilia ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Mesa 17.2.4 release candidate
On Mon, 2017-10-30 at 11:39 -0400, Ilia Mirkin wrote: > On Mon, Oct 30, 2017 at 11:29 AM, Emil Velikov > wrote: > > On 28 October 2017 at 21:35, Andres Gomez wrote: > > > On Fri, 2017-10-27 at 14:14 -0400, Ilia Mirkin wrote: > > > > On Fri, Oct 27, 2017 at 1:43 PM, Andres Gomez wrote: > > > > > Rejected (6) > > > > > > > > > > > > > > > Ilia Mirkin (1): > > > > > glsl: fix derived cs variables > > > > > > > > > > Reason: Commit is too big for stable at this point. > > > > > > > > The issue it fixes in regular compute shaders is slightly difficult to > > > > hit (but there are piglits that do now), however the issue it hits > > > > with ARB_compute_variable_group_size is fairly trivial to encounter. > > > > > > > > It seems silly to put out releases with known bugs when a fix is > > > > easily available and apply-able, with negligible risk of messing > > > > things up. > > > > > > > > Note that this all only affects nouveau and radeonsi, as those are the > > > > only drivers that make use of the lowering. > > > > > > Ilia, I understood by your answer [1] when I asked about your opinion > > > regarding 17.2.4 inclusion that it was OK to omit in this series but > > > that it should definitely be included in 17.3. > > > > > > Maybe I didn't make it clear that I was asking for the 17.2 queue and I > > > misunderstood your answer (?). > > > > > > Let's leave it as it is for this release and will see if we can include > > > it for the next one. > > > > > > > I'm inclined to agree with Andres - let's leave the patch out of 17.2.x. > > > > 17.3.x on the other hand is still fairly fresh, so I've pulled the > > patch for 17.3.0-rc2. > > In that case you should definitely remove > GL_ARB_compute_variable_group_size support from that release series. In that case, can we get? * A specific less invasive solution for the 17.2 queue (don't know if that's even possible). or * A patch to disable the mentioned extension in the affected drivers. Thanks. -- Br, Andres ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Mesa 17.2.4 release candidate
On Mon, Oct 30, 2017 at 11:29 AM, Emil Velikov wrote: > On 28 October 2017 at 21:35, Andres Gomez wrote: >> On Fri, 2017-10-27 at 14:14 -0400, Ilia Mirkin wrote: >>> On Fri, Oct 27, 2017 at 1:43 PM, Andres Gomez wrote: >>> > Rejected (6) >>> > >>> > >>> > Ilia Mirkin (1): >>> > glsl: fix derived cs variables >>> > >>> > Reason: Commit is too big for stable at this point. >>> >>> The issue it fixes in regular compute shaders is slightly difficult to >>> hit (but there are piglits that do now), however the issue it hits >>> with ARB_compute_variable_group_size is fairly trivial to encounter. >>> >>> It seems silly to put out releases with known bugs when a fix is >>> easily available and apply-able, with negligible risk of messing >>> things up. >>> >>> Note that this all only affects nouveau and radeonsi, as those are the >>> only drivers that make use of the lowering. >> >> Ilia, I understood by your answer [1] when I asked about your opinion >> regarding 17.2.4 inclusion that it was OK to omit in this series but >> that it should definitely be included in 17.3. >> >> Maybe I didn't make it clear that I was asking for the 17.2 queue and I >> misunderstood your answer (?). >> >> Let's leave it as it is for this release and will see if we can include >> it for the next one. >> > I'm inclined to agree with Andres - let's leave the patch out of 17.2.x. > > 17.3.x on the other hand is still fairly fresh, so I've pulled the > patch for 17.3.0-rc2. In that case you should definitely remove GL_ARB_compute_variable_group_size support from that release series. [As an aside, I have to say this is quite infuriating. I really don't get what problem you're solving with the stable releases if you don't accept direct bug fixes.] -ilia ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Mesa 17.2.4 release candidate
On 28 October 2017 at 21:35, Andres Gomez wrote: > On Fri, 2017-10-27 at 14:14 -0400, Ilia Mirkin wrote: >> On Fri, Oct 27, 2017 at 1:43 PM, Andres Gomez wrote: >> > Rejected (6) >> > >> > >> > Ilia Mirkin (1): >> > glsl: fix derived cs variables >> > >> > Reason: Commit is too big for stable at this point. >> >> The issue it fixes in regular compute shaders is slightly difficult to >> hit (but there are piglits that do now), however the issue it hits >> with ARB_compute_variable_group_size is fairly trivial to encounter. >> >> It seems silly to put out releases with known bugs when a fix is >> easily available and apply-able, with negligible risk of messing >> things up. >> >> Note that this all only affects nouveau and radeonsi, as those are the >> only drivers that make use of the lowering. > > Ilia, I understood by your answer [1] when I asked about your opinion > regarding 17.2.4 inclusion that it was OK to omit in this series but > that it should definitely be included in 17.3. > > Maybe I didn't make it clear that I was asking for the 17.2 queue and I > misunderstood your answer (?). > > Let's leave it as it is for this release and will see if we can include > it for the next one. > I'm inclined to agree with Andres - let's leave the patch out of 17.2.x. 17.3.x on the other hand is still fairly fresh, so I've pulled the patch for 17.3.0-rc2. Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Mesa 17.2.4 release candidate
On Fri, 2017-10-27 at 14:14 -0400, Ilia Mirkin wrote: > On Fri, Oct 27, 2017 at 1:43 PM, Andres Gomez wrote: > > Rejected (6) > > > > > > Ilia Mirkin (1): > > glsl: fix derived cs variables > > > > Reason: Commit is too big for stable at this point. > > The issue it fixes in regular compute shaders is slightly difficult to > hit (but there are piglits that do now), however the issue it hits > with ARB_compute_variable_group_size is fairly trivial to encounter. > > It seems silly to put out releases with known bugs when a fix is > easily available and apply-able, with negligible risk of messing > things up. > > Note that this all only affects nouveau and radeonsi, as those are the > only drivers that make use of the lowering. Ilia, I understood by your answer [1] when I asked about your opinion regarding 17.2.4 inclusion that it was OK to omit in this series but that it should definitely be included in 17.3. Maybe I didn't make it clear that I was asking for the 17.2 queue and I misunderstood your answer (?). Let's leave it as it is for this release and will see if we can include it for the next one. [1] https://lists.freedesktop.org/archives/mesa-stable/2017-October/007313.html -- Br, Andres ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Mesa 17.2.4 release candidate
On Fri, Oct 27, 2017 at 1:43 PM, Andres Gomez wrote: > Rejected (6) > > > Ilia Mirkin (1): > glsl: fix derived cs variables > > Reason: Commit is too big for stable at this point. The issue it fixes in regular compute shaders is slightly difficult to hit (but there are piglits that do now), however the issue it hits with ARB_compute_variable_group_size is fairly trivial to encounter. It seems silly to put out releases with known bugs when a fix is easily available and apply-able, with negligible risk of messing things up. Note that this all only affects nouveau and radeonsi, as those are the only drivers that make use of the lowering. -ilia ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] Mesa 17.2.4 release candidate
Hello list, The candidate for the Mesa 17.2.4 is now available. Currently we have: - 21 queued - 10 nominated (outstanding) - and 6 rejected patches In the current queue we have: In Mesa Core we have included a change to prevent KOTOR from breaking when in combination with the ATI fragment shader extension. Additionally, NIR has also received a correction. Mesa's state tracker has gotten a patch to avoid leaks in certain situations like when resizing a window. Intel drivers have received several fixes. The compiler has gotten a couple, while anv also received one. i965 got a patch to avoid VA-API, Beignet and other contexts in the system to break when in combination with previous versions of Mesa 17.2.x. AMD's compiler has received a couple of fixes while radv has also received another couple, including one to avoid a hang due to an overflow on huge textures. Broadcom's vc4 has corrected a problem when compiling with Android's clang. clover has also seen fixed a problem compiling after a specific clang revision. Vulkan's WSI has gotten plugged a memory leak for X11. Take a look at section "Mesa stable queue" for more information. Testing reports/general approval Any testing reports (or general approval of the state of the branch) will be greatly appreciated. The plan is to have 17.2.4 next Sunday (29th of October), around or shortly after 18:00 GMT. If you have any questions or suggestions - be that about the current patch queue or otherwise, please go ahead. Trivial merge conflicts --- commit 1eb4cbc934afd72ea45521eeac763e43564d972b Author: Dave Airlie radv/image: bump all the offset to uint64_t. (cherry picked from commit 35c66f3e40177a97d74e614e2a324a03e2149c73) commit cbc081b8711a519dd9aa371debbf68aa0add4076 Author: Kenneth Graunke i965: Revert absolute mode for constant buffer pointers. (cherry picked from commit 013d33122028f2492da90a03ae4bc1dab84c3ee9) commit ce725baa7c90420b46e16087a4f201a7e62b23e5 Author: Matthew Nicholls ac/nir: generate correct instruction for atomic min/max on unsigned images (cherry picked from commit 27a0b24bf238342031e0709584e4d71ab228f1ec) commit 74f19032341748ad257a0c2527624b661e2d2e6f Author: Jason Ekstrand anv/pipeline: Call nir_lower_system_valaues after brw_preprocess_nir (cherry picked from commit 279f8fb69cf68d05287e14f60cf67fc025643bc4) Cheers, Andres Mesa stable queue - Nominated (10) = Jason Ekstrand (4): spirv: Claim support for the simple memory model i965/blorp: Use blorp_to_isl_format for src_isl_format in blit_miptrees i965/blorp: Use more temporary isl_format variables i965/miptree: Take an isl_format in render_aux_usage Kenneth Graunke (1): mesa: Accept GL_BACK in get_fb0_attachment with ARB_ES3_1_compatibility. Leo Liu (1): radeon/video: add gfx9 offsets when rejoin the video surface Marek Olšák (2): radeonsi: add a workaround for weird s_buffer_load_dword behavior on SI ac/surface/gfx9: don't allow DCC for the smallest mipmap levels Nicolai Hähnle (1): amd/common/gfx9: workaround DCC corruption more conservatively Tapani Pälli (1): i965: unref push_const_bo in intelDestroyContext Queued (21) === Andres Gomez (7): cherry-ignore: configure.ac: rework llvm detection and handling cherry-ignore: glsl: fix derived cs variables cherry-ignore: added 17.3 nominations. cherry-ignore: radv: Don't use vgpr indexing for outputs on GFX9. cherry-ignore: radv: Disallow indirect outputs for GS on GFX9 as well. cherry-ignore: mesa/bufferobj: don't double negate the range cherry-ignore: broadcom/vc5: Propagate vc4 aliasing fix to vc5. Bas Nieuwenhuizen (1): ac/nir: Fix nir_texop_lod on GFX for 1D arrays. Dave Airlie (1): radv/image: bump all the offset to uint64_t. Henri Verbeet (1): vulkan/wsi: Free the event in x11_manage_fifo_queues(). Jan Vesely (1): clover: Fix compilation after clang r315871 Jason Ekstrand (4): nir/intrinsics: Set the correct num_indices for load_output intel/fs: Handle flag read/write aliasing in needs_src_copy anv/pipeline: Call nir_lower_system_valaues after brw_preprocess_nir intel/eu: Use EXECUTE_1 for JMPI Kenneth Graunke (1): i965: Revert absolute mode for constant buffer pointers. Marek Olšák (1): Revert "mesa: fix texture updates for ATI_fragment_shader" Matthew Nicholls (1): ac/nir: generate correct instruction for atomic min/max on unsigned images Michel Dänzer (1): st/mesa: Initialize textures array in st_framebuffer_validate Squashed with st/osmesa: include u_inlines.h for pipe_resource_reference Samuel Pitoiset (1): radv: add the draw count buffer to the list of buffers Stefan Schake (1): broadcom/vc4: Fix aliasing issue Rejected (6) Emil Velikov
