Re: [Mesa-dev] Patch: typo fixing

2015-04-27 Thread Francisco Jerez
Zoë Blade z...@bytenoise.co.uk writes:

 Hi!

 In this line there is a second typo in degnerate.

 Very well spotted, thank you!

 I've now fixed that particular typo, which appears in two different places:

 src/mesa/drivers/dri/i965/brw_clip_unfilled.c
 src/mesa/vbo/vbo_save_draw.c

 While I was at it, I spotted two more typos, now fixed:

 docs/relnotes/10.0.3.html
 src/gallium/drivers/llvmpipe/lp_scene.h

 I've amended http://bytenoise.co.uk/misc/fix-a-few-typos.patch with these 
 additions.

Thanks, pushed as 05e7f7f4388bde882b7ce74124000a4d435a.


 Thanks,
 Zoë.
 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev


signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] Patch: typo fixing

2015-04-22 Thread Zoë Blade
Hi!

 In this line there is a second typo in degnerate.

Very well spotted, thank you!

I've now fixed that particular typo, which appears in two different places:

src/mesa/drivers/dri/i965/brw_clip_unfilled.c
src/mesa/vbo/vbo_save_draw.c

While I was at it, I spotted two more typos, now fixed:

docs/relnotes/10.0.3.html
src/gallium/drivers/llvmpipe/lp_scene.h

I've amended http://bytenoise.co.uk/misc/fix-a-few-typos.patch with these 
additions.

Thanks,
Zoë.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] Patch: typo fixing

2015-04-22 Thread Zoë Blade
Hi!

I took the liberty of fixing a few typos.  If anyone's interested, you can 
download the Git patch from http://bytenoise.co.uk/misc/fix-a-few-typos.patch . 
 I've never had much luck compiling other people's projects, so this warrants 
vetting by someone smarter than me, I'm afraid.  Still, I hope it's of use to 
you!

All the best,
Zoë.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] Patch: typo fixing

2015-04-22 Thread Francisco Jerez
Zoë Blade z...@bytenoise.co.uk writes:

 Hi!

 I took the liberty of fixing a few typos.  If anyone's interested, you can 
 download the Git patch from http://bytenoise.co.uk/misc/fix-a-few-typos.patch 
 .  I've never had much luck compiling other people's projects, so this 
 warrants vetting by someone smarter than me, I'm afraid.  Still, I hope it's 
 of use to you!


Looks fine to me, just one minor comment.

| diff --git a/src/mesa/drivers/dri/i965/brw_clip_unfilled.c
| b/src/mesa/drivers/dri/i965/brw_clip_unfilled.c
| index 82d7b64..974b61d 100644
| --- a/src/mesa/drivers/dri/i965/brw_clip_unfilled.c
| +++ b/src/mesa/drivers/dri/i965/brw_clip_unfilled.c
| @@ -135,9 +135,9 @@ static void copy_bfc( struct brw_clip_compile *c )
|   brw_clip_have_varying(c, VARYING_SLOT_BFC1)))
|  return;
| 
| -   /* In some wierd degnerate cases we can end up testing the
| +   /* In some weird degnerate cases we can end up testing the

In this line there is a second typo in degnerate.

|  * direction twice, once for culling and once for bfc copying.  Oh
| -* well, that's what you get for setting wierd GL state.
| +* well, that's what you get for setting weird GL state.
|  */

With that fixed,
Reviewed-by: Francisco Jerez curroje...@riseup.net

 All the best,
 Zoë.

Thanks!

 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev


signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev