Re: [Mesa-dev] [PATCH] egl: Do not export private symbols
On 08/06/2013 05:30 PM, Jakob Bornecrantz wrote: On Wed, Aug 7, 2013 at 2:00 AM, Chad Versace chad.vers...@linux.intel.comwrote: On 08/06/2013 03:02 PM, Jakob Bornecrantz wrote: On Wed, Aug 7, 2013 at 12:00 AM, Jakob Bornecrantz wallbra...@gmail.com wrote: On Tue, Aug 6, 2013 at 9:21 PM, Chad Versace chad.vers...@linux.intel.com wrote: libEGL was incorrectly exporting *all* symbols, public and private. This patch adds -fvisibility=hidden to libEGL's linker flags to ensure that only symbols annotated with __attribute__((visibility(** default))) get exported. Sanity-checked on X11/EGL with Piglit, and on Wayland by running weston-gears. You need to test this patch on a non-inbuilt driver, egl_gallium or egl_glx, none of which require you to have any hardware. Or force egl_dri2 to not be built in. Do that and you have my Reviewed-by: Jakob Bornecrantz ja...@vmware.com Ok. I'll run this on egl_gallium or egl_glx, and then report back. Either is fine, tho I have no idea if egl_glx even works. All looks good. I tested es2gears_x11 using egl_gallium with Gallium's swrast driver. I also verified with gdb that those drivers were actually used. I'll commit to master now. By the way, I talked to krh today, and he suggested that we delete egl_glx rather than allow it to bitrot. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] egl: Do not export private symbols
On Tue, Aug 6, 2013 at 9:21 PM, Chad Versace chad.vers...@linux.intel.comwrote: libEGL was incorrectly exporting *all* symbols, public and private. This patch adds -fvisibility=hidden to libEGL's linker flags to ensure that only symbols annotated with __attribute__((visibility(default))) get exported. Sanity-checked on X11/EGL with Piglit, and on Wayland by running weston-gears. You need to test this patch on a non-inbuilt driver, egl_gallium or egl_glx, none of which require you to have any hardware. Or force egl_dri2 to not be built in. Cheers, Jakob. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] egl: Do not export private symbols
On Wed, Aug 7, 2013 at 12:00 AM, Jakob Bornecrantz wallbra...@gmail.comwrote: On Tue, Aug 6, 2013 at 9:21 PM, Chad Versace chad.vers...@linux.intel.com wrote: libEGL was incorrectly exporting *all* symbols, public and private. This patch adds -fvisibility=hidden to libEGL's linker flags to ensure that only symbols annotated with __attribute__((visibility(default))) get exported. Sanity-checked on X11/EGL with Piglit, and on Wayland by running weston-gears. You need to test this patch on a non-inbuilt driver, egl_gallium or egl_glx, none of which require you to have any hardware. Or force egl_dri2 to not be built in. Do that and you have my Reviewed-by: Jakob Bornecrantz ja...@vmware.com Cheers, Jakob. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] egl: Do not export private symbols
On 08/06/2013 03:02 PM, Jakob Bornecrantz wrote: On Wed, Aug 7, 2013 at 12:00 AM, Jakob Bornecrantz wallbra...@gmail.comwrote: On Tue, Aug 6, 2013 at 9:21 PM, Chad Versace chad.vers...@linux.intel.com wrote: libEGL was incorrectly exporting *all* symbols, public and private. This patch adds -fvisibility=hidden to libEGL's linker flags to ensure that only symbols annotated with __attribute__((visibility(default))) get exported. Sanity-checked on X11/EGL with Piglit, and on Wayland by running weston-gears. You need to test this patch on a non-inbuilt driver, egl_gallium or egl_glx, none of which require you to have any hardware. Or force egl_dri2 to not be built in. Do that and you have my Reviewed-by: Jakob Bornecrantz ja...@vmware.com Ok. I'll run this on egl_gallium or egl_glx, and then report back. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] egl: Do not export private symbols
On Wed, Aug 7, 2013 at 2:00 AM, Chad Versace chad.vers...@linux.intel.comwrote: On 08/06/2013 03:02 PM, Jakob Bornecrantz wrote: On Wed, Aug 7, 2013 at 12:00 AM, Jakob Bornecrantz wallbra...@gmail.com wrote: On Tue, Aug 6, 2013 at 9:21 PM, Chad Versace chad.vers...@linux.intel.com wrote: libEGL was incorrectly exporting *all* symbols, public and private. This patch adds -fvisibility=hidden to libEGL's linker flags to ensure that only symbols annotated with __attribute__((visibility(** default))) get exported. Sanity-checked on X11/EGL with Piglit, and on Wayland by running weston-gears. You need to test this patch on a non-inbuilt driver, egl_gallium or egl_glx, none of which require you to have any hardware. Or force egl_dri2 to not be built in. Do that and you have my Reviewed-by: Jakob Bornecrantz ja...@vmware.com Ok. I'll run this on egl_gallium or egl_glx, and then report back. Either is fine, tho I have no idea if egl_glx even works. Cheers, Jakob. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
