Re: [Mesa-dev] [PATCH] util: Fix -Wimplicit-function-declaration for ffs with GCC

2011-12-09 Thread Kai Wasserbäch
Dear mesa-dev list,
Kai Wasserbäch schrieb am 09.12.2011 12:59:
 AFAICS GCC was missed from the last #elif clause. With this patch
 applied the warning is gone.
 
 Signed-off-by: Kai Wasserbäch k...@dev.carbon-project.org
 ---
  There certainly other warnings thrown during a build, but I saw this one
  scrolling by, while checking on a build. Hence I went to fix it.
 
  src/gallium/auxiliary/util/u_math.h |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 [...]

I just noticed, I haven't pointed out, that I don't have commit access for Mesa
and somebody else would need to commit this, if that patch is accepted.

Kind regards,
Kai Wasserbäch



-- 

Kai Wasserbäch (Kai Wasserbaech)

E-Mail: k...@dev.carbon-project.org



signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] util: Fix -Wimplicit-function-declaration for ffs with GCC

2011-12-09 Thread Jose Fonseca


- Original Message -
 Dear mesa-dev list,
 Kai Wasserbäch schrieb am 09.12.2011 12:59:
  AFAICS GCC was missed from the last #elif clause. With this patch
  applied the warning is gone.
  
  Signed-off-by: Kai Wasserbäch k...@dev.carbon-project.org
  ---
   There certainly other warnings thrown during a build, but I saw
   this one
   scrolling by, while checking on a build. Hence I went to fix it.
  
   src/gallium/auxiliary/util/u_math.h |2 +-
   1 files changed, 1 insertions(+), 1 deletions(-)
  
  [...]

The system headers should normally define thi already.

man ffs says it is defined in strings.h

Does adding

  #include strings.h

to u_math.h fixes the issue?


Jose
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] util: Fix -Wimplicit-function-declaration for ffs with GCC

2011-12-09 Thread Kai Wasserbäch
Dear José
Jose Fonseca schrieb am 09.12.2011 19:33:
 - Original Message -
 Dear mesa-dev list,
 Kai Wasserbäch schrieb am 09.12.2011 12:59:
 AFAICS GCC was missed from the last #elif clause. With this patch
 applied the warning is gone.

 Signed-off-by: Kai Wasserbäch k...@dev.carbon-project.org
 ---
  There certainly other warnings thrown during a build, but I saw
  this one
  scrolling by, while checking on a build. Hence I went to fix it.

  src/gallium/auxiliary/util/u_math.h |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

 [...]
 
 The system headers should normally define thi already.
 
 man ffs says it is defined in strings.h
 
 Does adding
 
   #include strings.h
 
 to u_math.h fixes the issue?

yes, that seems to fix this too.

Kind regards,
Kai Wasserbäch



-- 

Kai Wasserbäch (Kai Wasserbaech)

E-Mail: k...@dev.carbon-project.org



signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev