Re: [Mesa-dev] [PATCH 0/3] radv: Support image operations without format.

2017-02-14 Thread Edward O'Callaghan 
This series LGTM,
Reviewed-by: Edward O'Callaghan 

On 02/15/2017 11:36 AM, Bas Nieuwenhuizen wrote:
> No regressions on CTS 1.0.2 mustpass, though I don't think there are
> tests for these extensions. I checked there were no references to the
> format in the nir->LLVM conversion though.
> 
> Bas Nieuwenhuizen (3):
>   radv: Add support for shaderStorageImageWriteWithoutFormat.
>   spirv: Add support for SpvCapabilityStorageImageReadWithoutFormat.
>   radv: Add support for shaderStorageImageReadWithoutFormat.
> 
>  src/amd/vulkan/radv_device.c  | 4 ++--
>  src/amd/vulkan/radv_pipeline.c| 4 +++-
>  src/compiler/spirv/nir_spirv.h| 1 +
>  src/compiler/spirv/spirv_to_nir.c | 5 -
>  4 files changed, 10 insertions(+), 4 deletions(-)
> 



signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/3] radv: Support image operations without format.

2017-02-14 Thread Jason Ekstrand 
On Tue, Feb 14, 2017 at 4:36 PM, Bas Nieuwenhuizen 
wrote:

> No regressions on CTS 1.0.2 mustpass, though I don't think there are
> tests for these extensions. I checked there were no references to the
> format in the nir->LLVM conversion though.
>

It's pretty easy to tweak the load_store CTS tests to not provide a
format.  That's what I did for testing.  It's better than nothing.


> Bas Nieuwenhuizen (3):
>   radv: Add support for shaderStorageImageWriteWithoutFormat.
>   spirv: Add support for SpvCapabilityStorageImageReadWithoutFormat.
>   radv: Add support for shaderStorageImageReadWithoutFormat.
>
>  src/amd/vulkan/radv_device.c  | 4 ++--
>  src/amd/vulkan/radv_pipeline.c| 4 +++-
>  src/compiler/spirv/nir_spirv.h| 1 +
>  src/compiler/spirv/spirv_to_nir.c | 5 -
>  4 files changed, 10 insertions(+), 4 deletions(-)
>
> --
> 2.11.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev