Re: [Mesa-dev] [PATCH 0/9] Clean up draw path state updates.

[Mathias Fröhlich]

Hi Brian,

On Tuesday, 20 March 2018 16:16:13 CET Brian Paul wrote:
> The code changes look good, AFAICT.  But some of the comments could be 
> improved, IMHO.  See other replies...
> 
> Otherwise, for the series,
> Reviewed-by: Brian Paul 

Thanks for the review!
Will incorporate the proposed changes.

best

Mathias


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/9] Clean up draw path state updates.

[Brian Paul]

On 03/15/2018 11:48 PM, mathias.froehl...@gmx.net wrote:

From: Mathias Fröhlich 

Hi Brian,

This series mostly prepares the pushdown of gl_vertex_array use into
the drivers. Once it is there we can fade that out for most of the
drivers and change that on a per driver base.
The series cleans up when to flag changes of the array state and
introduces draw as a first class citizen of struct dd_driver_functions.
The series survives piglit in radeonsi, classic swrast and i965 without
regressions as well as a run on intels CI system.

please review
best
Mathias


Hi Mathias,

The code changes look good, AFAICT.  But some of the comments could be 
improved, IMHO.  See other replies...


Otherwise, for the series,
Reviewed-by: Brian Paul 

-Brian
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev