Re: [Mesa-dev] [PATCH 00/10] intel/anv: Prepare to add Ice Lake (ICL) support

2018-02-16 Thread Anuj Phogat
On Thu, Feb 15, 2018 at 6:14 PM, Jason Ekstrand  wrote:
> I made a few fairly trivial comments but it all looks pretty good.
>
> Reviewed-by: Jason Ekstrand 
Thanks for the quick review Jason.

>
> On Thu, Feb 15, 2018 at 5:44 PM, Anuj Phogat  wrote:
>>
>> This series prepares the driver to enable Ice Lake support
>> in Vulkan driver. It wires up the build infrastructure and
>> make few ICL specific changes suggested by h/w documentation.
>> This is not everything we need to enable Vulkan on Ice Lake.
>
>
> How much is left?
>
Remaining bits are:
Compiler changes to remove line, pln and lrp
Add ICL L3 config
Separate SLM from L3
Add fp64 support
Add ICL device info
Add ICL workarounds

>>
>> Series is also available in my review branch at github.
>> https://github.com/aphogat/mesa.git
>>
>> Anuj Phogat (10):
>>   anv/icl: Add gen11 mocs defines
>>   anv/icl: Add #define genX
>>   anv/icl: Don't set ResetGatewayTimer
>>   anv/icl: Don't use SingleVertexDispatch
>>   anv/icl: Don't use DISPATCH_MODE_SIMD4X2
>>   anv/icl: Generate gen11 entry point functions
>>   anv/icl: Build anv libs for gen11
>>   anv/icl: Use gen11 functions
>>   anv/icl: Enable float blend optimization
>>   anv/icl: Add render target flush after uploading binding table
>>
>>  src/intel/Android.vulkan.mk | 21 +
>>  src/intel/Makefile.sources  |  4 
>>  src/intel/Makefile.vulkan.am|  7 ++-
>>  src/intel/vulkan/anv_blorp.c|  3 +++
>>  src/intel/vulkan/anv_device.c   |  3 +++
>>  src/intel/vulkan/anv_entrypoints_gen.py |  6 +-
>>  src/intel/vulkan/anv_private.h  | 14 ++
>>  src/intel/vulkan/genX_cmd_buffer.c  | 21 +
>>  src/intel/vulkan/genX_pipeline.c| 11 +++
>>  src/intel/vulkan/genX_state.c   |  2 +-
>>  src/intel/vulkan/meson.build|  2 +-
>>  11 files changed, 90 insertions(+), 4 deletions(-)
>>
>> --
>> 2.13.6
>>
>> ___
>> mesa-dev mailing list
>> mesa-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 00/10] intel/anv: Prepare to add Ice Lake (ICL) support

2018-02-15 Thread Jason Ekstrand
I made a few fairly trivial comments but it all looks pretty good.

Reviewed-by: Jason Ekstrand 

On Thu, Feb 15, 2018 at 5:44 PM, Anuj Phogat  wrote:

> This series prepares the driver to enable Ice Lake support
> in Vulkan driver. It wires up the build infrastructure and
> make few ICL specific changes suggested by h/w documentation.
> This is not everything we need to enable Vulkan on Ice Lake.
>

How much is left?


> Series is also available in my review branch at github.
> https://github.com/aphogat/mesa.git
>
> Anuj Phogat (10):
>   anv/icl: Add gen11 mocs defines
>   anv/icl: Add #define genX
>   anv/icl: Don't set ResetGatewayTimer
>   anv/icl: Don't use SingleVertexDispatch
>   anv/icl: Don't use DISPATCH_MODE_SIMD4X2
>   anv/icl: Generate gen11 entry point functions
>   anv/icl: Build anv libs for gen11
>   anv/icl: Use gen11 functions
>   anv/icl: Enable float blend optimization
>   anv/icl: Add render target flush after uploading binding table
>
>  src/intel/Android.vulkan.mk | 21 +
>  src/intel/Makefile.sources  |  4 
>  src/intel/Makefile.vulkan.am|  7 ++-
>  src/intel/vulkan/anv_blorp.c|  3 +++
>  src/intel/vulkan/anv_device.c   |  3 +++
>  src/intel/vulkan/anv_entrypoints_gen.py |  6 +-
>  src/intel/vulkan/anv_private.h  | 14 ++
>  src/intel/vulkan/genX_cmd_buffer.c  | 21 +
>  src/intel/vulkan/genX_pipeline.c| 11 +++
>  src/intel/vulkan/genX_state.c   |  2 +-
>  src/intel/vulkan/meson.build|  2 +-
>  11 files changed, 90 insertions(+), 4 deletions(-)
>
> --
> 2.13.6
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev