Re: [Mesa-dev] [PATCH 00/13] Misc extern C fixes

2017-02-20 Thread Emil Velikov 
On 20 February 2017 at 16:14, Brian Paul  wrote:
> On 02/16/2017 08:16 AM, Emil Velikov wrote:
>>
>> Just a bunch of extern C issues flagged by [1]. There's a few more
>> remaining such as the glsl_types C API living in nir_types.{cpp,h} but
>> that can be resolved at a later date.
>>
>> -Emil
>>
>> [1] git grep -B2 "#.*\" -- src/ | grep  "\"
>>
>
> Series, looks OK to me.  Though, one could imagine some .h files that aren't
> included by .cpp sources now being included by .cpp sources in the future.
> So, I'm not sure patches 1, 2, 13 are needed.
>
I thought about that but I doubt we'll need the extern C there anytime
soon. I'll give it a couple days more for people to shout.

> In any case,
> Reviewed-by: Brian Paul 
>
Thanks !
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 00/13] Misc extern C fixes

2017-02-20 Thread Brian Paul 

On 02/16/2017 08:16 AM, Emil Velikov wrote:

Just a bunch of extern C issues flagged by [1]. There's a few more
remaining such as the glsl_types C API living in nir_types.{cpp,h} but
that can be resolved at a later date.

-Emil

[1] git grep -B2 "#.*\" -- src/ | grep  "\"



Series, looks OK to me.  Though, one could imagine some .h files that 
aren't included by .cpp sources now being included by .cpp sources in 
the future.  So, I'm not sure patches 1, 2, 13 are needed.


In any case,
Reviewed-by: Brian Paul 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev