Re: [Mesa-dev] [PATCH 00/24] i965: Move the compiler to src/intel/compiler

[Matt Turner]

On Wed, Mar 1, 2017 at 9:00 AM, Jason Ekstrand  wrote:
> On Wed, Mar 1, 2017 at 8:40 AM, Matt Turner  wrote:
>>
>> On Tue, Feb 28, 2017 at 9:03 PM, Jason Ekstrand 
>> wrote:
>> > This little series moves the i965 back-end compiler to
>> > src/intel/compiler.
>> > It's not incredibly pretty; I didn't do as much header clean-up as
>> > perhaps
>> > could have been done.  Anything that I didn't know what to do with I
>> > moved
>> > to brw_shader or brw_program.  The second-to-last patch which shuffles
>> > the
>> > header includes around is also one big patch.  It could be split up but
>> > there didn't seem to be much of a point.
>> >
>> > Jason Ekstrand (24):
>> >   i965: Move a couple of #defines from brw_context to brw_compiler
>> >   i965: Move some helpers from brw_context.h to brw_shader.h
>> >   i965: Move brw_disassemble_inst to brw_eu.h
>> >   i965: Move some gen4 WM defines to brw_compiler.h
>> >   i965: Move assign_common_binding_table_offsets to brw_program
>> >   i965/vue_map: Stop using GLbitfield types
>>
>> I made it through these patches before I went to bed, so they are
>>
>> Reviewed-by: Matt Turner 
>>
>> >   i965: Get rid of BRW_PRIM_OFFSET
>> >   i965: Don't use MAX_SURFACES in mark_surface_used
>> >   i965/gs: Add the gl_prim_to_hw_prim table to vec4_gs_visitor.cpp
>> >   i964/gs: Move MAX_GS_INPUT_VERTICES to brw_vec4_gs_visitor.h
>> >   i965: Move SOL binding #defines to brw_compiler.h
>> >   i965: Move SHADER_TIME_STRIDE to brw_compiler.h
>> >   i965: Move brw_register_blocks to brw_fs.cpp
>> >   i965/inst: Stop using fi_type
>> >   i965: Move BRW_MAX_DRAW_BUFFERS to brw_compiler.h
>> >   i965: Move BRW_ATTRIB_WA_* defines to brw_compiler.h
>> >   i965: Make mark_surface_used a static inline in brw_compiler.h
>> >   i965: Move channel_expressions and vector_splitting to brw_program.h
>> >   i965: Move image uniform setup to brw_nir_uniforms.cpp
>> >   i965: Move a bunch of pre-compile and link stuff to brw_program.h
>> >   i965: Add a header for brw_vec4_vs_visitor
>> >   i965: Delete brw_do_cubemap_normalize
>>
>> I see Ken reviewed these at 1:42am, so I won't bother.
>>
>> >   i965: Reduce cross-pollination between the DRI driver and compiler
>> >   i965: Move the back-end compiler to src/intel/compiler
>>
>> Like I said on IRC, I'd rather hold this until IVB/fp64 has landed.
>> They've done enough irritating work to have to go through an
>> unnecessary rebase.
>
>
> Hold off on the move or the header shuffling?  I don't think the header
> shuffling will affect them.  I'm more than happy to hold off on the move.

Just the move. Sorry for the confusion.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 00/24] i965: Move the compiler to src/intel/compiler

[Jason Ekstrand]

On Wed, Mar 1, 2017 at 8:40 AM, Matt Turner  wrote:

> On Tue, Feb 28, 2017 at 9:03 PM, Jason Ekstrand 
> wrote:
> > This little series moves the i965 back-end compiler to
> src/intel/compiler.
> > It's not incredibly pretty; I didn't do as much header clean-up as
> perhaps
> > could have been done.  Anything that I didn't know what to do with I
> moved
> > to brw_shader or brw_program.  The second-to-last patch which shuffles
> the
> > header includes around is also one big patch.  It could be split up but
> > there didn't seem to be much of a point.
> >
> > Jason Ekstrand (24):
> >   i965: Move a couple of #defines from brw_context to brw_compiler
> >   i965: Move some helpers from brw_context.h to brw_shader.h
> >   i965: Move brw_disassemble_inst to brw_eu.h
> >   i965: Move some gen4 WM defines to brw_compiler.h
> >   i965: Move assign_common_binding_table_offsets to brw_program
> >   i965/vue_map: Stop using GLbitfield types
>
> I made it through these patches before I went to bed, so they are
>
> Reviewed-by: Matt Turner 
>
> >   i965: Get rid of BRW_PRIM_OFFSET
> >   i965: Don't use MAX_SURFACES in mark_surface_used
> >   i965/gs: Add the gl_prim_to_hw_prim table to vec4_gs_visitor.cpp
> >   i964/gs: Move MAX_GS_INPUT_VERTICES to brw_vec4_gs_visitor.h
> >   i965: Move SOL binding #defines to brw_compiler.h
> >   i965: Move SHADER_TIME_STRIDE to brw_compiler.h
> >   i965: Move brw_register_blocks to brw_fs.cpp
> >   i965/inst: Stop using fi_type
> >   i965: Move BRW_MAX_DRAW_BUFFERS to brw_compiler.h
> >   i965: Move BRW_ATTRIB_WA_* defines to brw_compiler.h
> >   i965: Make mark_surface_used a static inline in brw_compiler.h
> >   i965: Move channel_expressions and vector_splitting to brw_program.h
> >   i965: Move image uniform setup to brw_nir_uniforms.cpp
> >   i965: Move a bunch of pre-compile and link stuff to brw_program.h
> >   i965: Add a header for brw_vec4_vs_visitor
> >   i965: Delete brw_do_cubemap_normalize
>
> I see Ken reviewed these at 1:42am, so I won't bother.
>
> >   i965: Reduce cross-pollination between the DRI driver and compiler
> >   i965: Move the back-end compiler to src/intel/compiler
>
> Like I said on IRC, I'd rather hold this until IVB/fp64 has landed.
> They've done enough irritating work to have to go through an
> unnecessary rebase.
>

Hold off on the move or the header shuffling?  I don't think the header
shuffling will affect them.  I'm more than happy to hold off on the move.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 00/24] i965: Move the compiler to src/intel/compiler

[Matt Turner]

On Tue, Feb 28, 2017 at 9:03 PM, Jason Ekstrand  wrote:
> This little series moves the i965 back-end compiler to src/intel/compiler.
> It's not incredibly pretty; I didn't do as much header clean-up as perhaps
> could have been done.  Anything that I didn't know what to do with I moved
> to brw_shader or brw_program.  The second-to-last patch which shuffles the
> header includes around is also one big patch.  It could be split up but
> there didn't seem to be much of a point.
>
> Jason Ekstrand (24):
>   i965: Move a couple of #defines from brw_context to brw_compiler
>   i965: Move some helpers from brw_context.h to brw_shader.h
>   i965: Move brw_disassemble_inst to brw_eu.h
>   i965: Move some gen4 WM defines to brw_compiler.h
>   i965: Move assign_common_binding_table_offsets to brw_program
>   i965/vue_map: Stop using GLbitfield types

I made it through these patches before I went to bed, so they are

Reviewed-by: Matt Turner 

>   i965: Get rid of BRW_PRIM_OFFSET
>   i965: Don't use MAX_SURFACES in mark_surface_used
>   i965/gs: Add the gl_prim_to_hw_prim table to vec4_gs_visitor.cpp
>   i964/gs: Move MAX_GS_INPUT_VERTICES to brw_vec4_gs_visitor.h
>   i965: Move SOL binding #defines to brw_compiler.h
>   i965: Move SHADER_TIME_STRIDE to brw_compiler.h
>   i965: Move brw_register_blocks to brw_fs.cpp
>   i965/inst: Stop using fi_type
>   i965: Move BRW_MAX_DRAW_BUFFERS to brw_compiler.h
>   i965: Move BRW_ATTRIB_WA_* defines to brw_compiler.h
>   i965: Make mark_surface_used a static inline in brw_compiler.h
>   i965: Move channel_expressions and vector_splitting to brw_program.h
>   i965: Move image uniform setup to brw_nir_uniforms.cpp
>   i965: Move a bunch of pre-compile and link stuff to brw_program.h
>   i965: Add a header for brw_vec4_vs_visitor
>   i965: Delete brw_do_cubemap_normalize

I see Ken reviewed these at 1:42am, so I won't bother.

>   i965: Reduce cross-pollination between the DRI driver and compiler
>   i965: Move the back-end compiler to src/intel/compiler

Like I said on IRC, I'd rather hold this until IVB/fp64 has landed.
They've done enough irritating work to have to go through an
unnecessary rebase.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 00/24] i965: Move the compiler to src/intel/compiler

[Kenneth Graunke]

On Tuesday, February 28, 2017 9:03:12 PM PST Jason Ekstrand wrote:
> This little series moves the i965 back-end compiler to src/intel/compiler.
> It's not incredibly pretty; I didn't do as much header clean-up as perhaps
> could have been done.  Anything that I didn't know what to do with I moved
> to brw_shader or brw_program.  The second-to-last patch which shuffles the
> header includes around is also one big patch.  It could be split up but
> there didn't seem to be much of a point.
> 
> Jason Ekstrand (24):
>   i965: Move a couple of #defines from brw_context to brw_compiler
>   i965: Move some helpers from brw_context.h to brw_shader.h
>   i965: Move brw_disassemble_inst to brw_eu.h
>   i965: Move some gen4 WM defines to brw_compiler.h
>   i965: Move assign_common_binding_table_offsets to brw_program
>   i965/vue_map: Stop using GLbitfield types
>   i965: Get rid of BRW_PRIM_OFFSET
>   i965: Don't use MAX_SURFACES in mark_surface_used
>   i965/gs: Add the gl_prim_to_hw_prim table to vec4_gs_visitor.cpp
>   i964/gs: Move MAX_GS_INPUT_VERTICES to brw_vec4_gs_visitor.h
>   i965: Move SOL binding #defines to brw_compiler.h
>   i965: Move SHADER_TIME_STRIDE to brw_compiler.h
>   i965: Move brw_register_blocks to brw_fs.cpp
>   i965/inst: Stop using fi_type
>   i965: Move BRW_MAX_DRAW_BUFFERS to brw_compiler.h
>   i965: Move BRW_ATTRIB_WA_* defines to brw_compiler.h
>   i965: Make mark_surface_used a static inline in brw_compiler.h
>   i965: Move channel_expressions and vector_splitting to brw_program.h
>   i965: Move image uniform setup to brw_nir_uniforms.cpp
>   i965: Move a bunch of pre-compile and link stuff to brw_program.h
>   i965: Add a header for brw_vec4_vs_visitor
>   i965: Delete brw_do_cubemap_normalize
>   i965: Reduce cross-pollination between the DRI driver and compiler
>   i965: Move the back-end compiler to src/intel/compiler

Assuming you take my suggestion on patch 21...patches 1-22 are:
Reviewed-by: Kenneth Graunke 

and patch 23 is:
Acked-by: Kenneth Graunke 

I believe Matt asked you to hold off on moving the compiler earlier
today, so I'm a bit surprised to see this.  It probably makes sense to
land the precursor patches - I doubt they'll conflict too badly with
any of the outstanding work.  But please get an ack from him before
pushing anything.


signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 00/24] i965: Move the compiler to src/intel/compiler

[Jason Ekstrand]

For those of you who like branches:

https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/move-compiler

On Tue, Feb 28, 2017 at 9:03 PM, Jason Ekstrand 
wrote:

> This little series moves the i965 back-end compiler to src/intel/compiler.
> It's not incredibly pretty; I didn't do as much header clean-up as perhaps
> could have been done.  Anything that I didn't know what to do with I moved
> to brw_shader or brw_program.  The second-to-last patch which shuffles the
> header includes around is also one big patch.  It could be split up but
> there didn't seem to be much of a point.
>
> Jason Ekstrand (24):
>   i965: Move a couple of #defines from brw_context to brw_compiler
>   i965: Move some helpers from brw_context.h to brw_shader.h
>   i965: Move brw_disassemble_inst to brw_eu.h
>   i965: Move some gen4 WM defines to brw_compiler.h
>   i965: Move assign_common_binding_table_offsets to brw_program
>   i965/vue_map: Stop using GLbitfield types
>   i965: Get rid of BRW_PRIM_OFFSET
>   i965: Don't use MAX_SURFACES in mark_surface_used
>   i965/gs: Add the gl_prim_to_hw_prim table to vec4_gs_visitor.cpp
>   i964/gs: Move MAX_GS_INPUT_VERTICES to brw_vec4_gs_visitor.h
>   i965: Move SOL binding #defines to brw_compiler.h
>   i965: Move SHADER_TIME_STRIDE to brw_compiler.h
>   i965: Move brw_register_blocks to brw_fs.cpp
>   i965/inst: Stop using fi_type
>   i965: Move BRW_MAX_DRAW_BUFFERS to brw_compiler.h
>   i965: Move BRW_ATTRIB_WA_* defines to brw_compiler.h
>   i965: Make mark_surface_used a static inline in brw_compiler.h
>   i965: Move channel_expressions and vector_splitting to brw_program.h
>   i965: Move image uniform setup to brw_nir_uniforms.cpp
>   i965: Move a bunch of pre-compile and link stuff to brw_program.h
>   i965: Add a header for brw_vec4_vs_visitor
>   i965: Delete brw_do_cubemap_normalize
>   i965: Reduce cross-pollination between the DRI driver and compiler
>   i965: Move the back-end compiler to src/intel/compiler
>
>  src/intel/Makefile.am  |   2 +
>  src/intel/Makefile.compiler.am | 116 
>  src/intel/Makefile.sources |  89 
>  src/intel/blorp/blorp_priv.h   |   2 +-
>  src/intel/compiler/.gitignore  |   1 +
>  .../dri/i965 => intel/compiler}/brw_cfg.cpp|   0
>  .../drivers/dri/i965 => intel/compiler}/brw_cfg.h  |   0
>  .../dri/i965 => intel/compiler}/brw_compiler.c |   3 +-
>  .../dri/i965 => intel/compiler}/brw_compiler.h | 116 +++-
>  .../compiler}/brw_dead_control_flow.cpp|   0
>  .../compiler}/brw_dead_control_flow.h  |   0
>  .../dri/i965 => intel/compiler}/brw_disasm.c   |   3 +-
>  .../drivers/dri/i965 => intel/compiler}/brw_eu.c   |   3 +-
>  .../drivers/dri/i965 => intel/compiler}/brw_eu.h   |   2 +
>  .../dri/i965 => intel/compiler}/brw_eu_compact.c   |   3 +-
>  .../dri/i965 => intel/compiler}/brw_eu_emit.c  |   1 -
>  .../dri/i965 => intel/compiler}/brw_eu_util.c  |   1 -
>  .../dri/i965 => intel/compiler}/brw_eu_validate.c  |   0
>  .../drivers/dri/i965 => intel/compiler}/brw_fs.cpp |  15 +-
>  .../drivers/dri/i965 => intel/compiler}/brw_fs.h   |   3 -
>  .../dri/i965 => intel/compiler}/brw_fs_builder.h   |   1 -
>  .../compiler}/brw_fs_cmod_propagation.cpp  |   0
>  .../compiler}/brw_fs_combine_constants.cpp |   0
>  .../compiler}/brw_fs_copy_propagation.cpp  |   0
>  .../dri/i965 => intel/compiler}/brw_fs_cse.cpp |   0
>  .../compiler}/brw_fs_dead_code_eliminate.cpp   |   0
>  .../i965 => intel/compiler}/brw_fs_generator.cpp   |   0
>  .../compiler}/brw_fs_live_variables.cpp|   0
>  .../compiler}/brw_fs_live_variables.h  |   0
>  .../i965 => intel/compiler}/brw_fs_lower_d2x.cpp   |   0
>  .../i965 => intel/compiler}/brw_fs_lower_pack.cpp  |   0
>  .../dri/i965 => intel/compiler}/brw_fs_nir.cpp |   0
>  .../compiler}/brw_fs_reg_allocate.cpp  |   0
>  .../compiler}/brw_fs_register_coalesce.cpp |   0
>  .../compiler}/brw_fs_saturate_propagation.cpp  |   0
>  .../compiler}/brw_fs_sel_peephole.cpp  |   0
>  .../compiler}/brw_fs_surface_builder.cpp   |   0
>  .../compiler}/brw_fs_surface_builder.h |   1 -
>  .../i965 => intel/compiler}/brw_fs_validate.cpp|   0
>  .../dri/i965 => intel/compiler}/brw_fs_visitor.cpp |   0
>  .../drivers/dri/i965 => intel/compiler}/brw_inst.h |  13 +-
>  .../compiler}/brw_interpolation_map.c  |   1 -
>  .../dri/i965 => intel/compiler}/brw_ir_allocator.h |   0
>  .../dri/i965 => intel/compiler}/brw_ir_fs.h|   0
>  .../dri/i965 => intel/compiler}/brw_ir_vec4.h  |   1 -
>  .../drivers/dri/i965 => intel/compiler}/brw_nir.c  |   1 +
>  .../drivers/dri/i965 => intel/compiler}/brw_nir.h  |   0
>  .../compiler}/brw_nir_analyze_boolean_resolves.c   |   0
>