Re: [Mesa-dev] [PATCH 1/2] i965/gen10: Don't set Smooth Point Enable in 3DSTATE_SF if num_samples > 1
On Fri, Oct 27, 2017 at 2:50 PM, Matt Turner wrote: > On Fri, Oct 27, 2017 at 10:50 AM, Anuj Phogat wrote: >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c >> b/src/mesa/drivers/dri/i965/genX_state_upload.c >> index 4ccfd48919..b6e800aa90 100644 >> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c >> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c >> @@ -1626,6 +1626,16 @@ genX(upload_sf)(struct brw_context *brw) >> sf.SmoothPointEnable = true; >> #endif >> >> +#if GEN_GEN == 10 >> + /* _NEW_MULTISAMPLE >> + * Smooth Point Enable bit MUST not be set when NUM_MULTISAMPLES > 1. >> + */ >> + const bool multisampled_fbo = >> + _mesa_geometric_samples(ctx->DrawBuffer) > 1; > > Indent this line. Fixed locally. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/2] i965/gen10: Don't set Smooth Point Enable in 3DSTATE_SF if num_samples > 1
On Fri, Oct 27, 2017 at 2:44 PM, Kenneth Graunke wrote: > On Friday, October 27, 2017 10:50:23 AM PDT Anuj Phogat wrote: >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c >> b/src/mesa/drivers/dri/i965/genX_state_upload.c >> index 4ccfd48919..b6e800aa90 100644 >> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c >> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c >> @@ -1626,6 +1626,16 @@ genX(upload_sf)(struct brw_context *brw) >> sf.SmoothPointEnable = true; >> #endif >> >> +#if GEN_GEN == 10 >> + /* _NEW_MULTISAMPLE >> + * Smooth Point Enable bit MUST not be set when NUM_MULTISAMPLES > 1. >> + */ >> + const bool multisampled_fbo = >> + _mesa_geometric_samples(ctx->DrawBuffer) > 1; >> + if (multisampled_fbo) >> + sf.SmoothPointEnable = false; >> +#endif >> + >> #if GEN_IS_G4X || GEN_GEN >= 5 >>sf.AALineDistanceMode = AALINEDISTANCE_TRUE; >> #endif >> > > In both patches...accessing ctx->DrawBuffer requires _NEW_BUFFERS, but > doesn't need _NEW_MULTISAMPLE. Right. Fixed locally. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/2] i965/gen10: Don't set Smooth Point Enable in 3DSTATE_SF if num_samples > 1
On Fri, Oct 27, 2017 at 10:50 AM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c > b/src/mesa/drivers/dri/i965/genX_state_upload.c > index 4ccfd48919..b6e800aa90 100644 > --- a/src/mesa/drivers/dri/i965/genX_state_upload.c > +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c > @@ -1626,6 +1626,16 @@ genX(upload_sf)(struct brw_context *brw) > sf.SmoothPointEnable = true; > #endif > > +#if GEN_GEN == 10 > + /* _NEW_MULTISAMPLE > + * Smooth Point Enable bit MUST not be set when NUM_MULTISAMPLES > 1. > + */ > + const bool multisampled_fbo = > + _mesa_geometric_samples(ctx->DrawBuffer) > 1; Indent this line. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/2] i965/gen10: Don't set Smooth Point Enable in 3DSTATE_SF if num_samples > 1
On Friday, October 27, 2017 10:50:23 AM PDT Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c > b/src/mesa/drivers/dri/i965/genX_state_upload.c > index 4ccfd48919..b6e800aa90 100644 > --- a/src/mesa/drivers/dri/i965/genX_state_upload.c > +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c > @@ -1626,6 +1626,16 @@ genX(upload_sf)(struct brw_context *brw) > sf.SmoothPointEnable = true; > #endif > > +#if GEN_GEN == 10 > + /* _NEW_MULTISAMPLE > + * Smooth Point Enable bit MUST not be set when NUM_MULTISAMPLES > 1. > + */ > + const bool multisampled_fbo = > + _mesa_geometric_samples(ctx->DrawBuffer) > 1; > + if (multisampled_fbo) > + sf.SmoothPointEnable = false; > +#endif > + > #if GEN_IS_G4X || GEN_GEN >= 5 >sf.AALineDistanceMode = AALINEDISTANCE_TRUE; > #endif > In both patches...accessing ctx->DrawBuffer requires _NEW_BUFFERS, but doesn't need _NEW_MULTISAMPLE. signature.asc Description: This is a digitally signed message part. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev