Re: [Mesa-dev] [PATCH 1/4] Whitespace cleanup
On 09.03.2015 18:06, Giuseppe Bilotta wrote: > On Mon, Mar 9, 2015 at 5:01 AM, Michel Dänzer wrote: >> The shortlog of patch 4 should be prefixed by gallium: as well. > > Duh, I forgot the prefix everywhere. And the signoff line. > > Specifically about the last patch, the one that actually touches > clover, is there a criteria for when to use gallium: and when to use > clover: as prefix? I've seen either being used when looking at the > log, sometimes even both at the same time. A change which touches only clover code should have "clover:" or "st/clover:" as the prefix. Maybe some of the changes you saw were more general changes involving other parts of Gallium as well. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/4] Whitespace cleanup
On Mon, Mar 9, 2015 at 5:01 AM, Michel Dänzer wrote: > The shortlog of patch 4 should be prefixed by gallium: as well. Duh, I forgot the prefix everywhere. And the signoff line. Specifically about the last patch, the one that actually touches clover, is there a criteria for when to use gallium: and when to use clover: as prefix? I've seen either being used when looking at the log, sometimes even both at the same time. (Just so that I can try and get it right on the first submission --hahah-- for the next patchset). -- Giuseppe "Oblomov" Bilotta ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/4] Whitespace cleanup
On 07.03.2015 16:56, Giuseppe Bilotta wrote:
> ---
> src/gallium/include/pipe/p_screen.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/include/pipe/p_screen.h
> b/src/gallium/include/pipe/p_screen.h
> index ac88506..4018f8a 100644
> --- a/src/gallium/include/pipe/p_screen.h
> +++ b/src/gallium/include/pipe/p_screen.h
> @@ -147,7 +147,7 @@ struct pipe_screen {
> */
> boolean (*can_create_resource)(struct pipe_screen *screen,
>const struct pipe_resource *templat);
> -
> +
> /**
> * Create a new texture object, using the given template info.
> */
>
The shortlog should be something like
gallium: Remove trailing whitespace from p_screen.h
instead of just "Whitespace cleanup". With that fixed,
Reviewed-by: Michel Dänzer
The shortlog of patch 4 should be prefixed by gallium: as well. With
that fixed, it's
Acked-by: Michel Dänzer
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
