Re: [Mesa-dev] [PATCH 1/7] svga: Use __asm__ instead of asm

[Brian Paul]

On 10/27/2017 05:21 AM, Emil Velikov wrote:

On 27 October 2017 at 00:57, Dylan Baker  wrote:

Which allows the code to be compiled with c99 instead of gnu99.

A little history. This code is guarded by #ifdef __GNUC__, so it's only
compiled with autotools on *nix, SCons with MSVC wont hit that code.
However, meson is going to build both MSVC and GCC/Clang paths. As such
it makes sense to not have to override the std for gcc/clang, but ensure
that it's not set to gnu99 when building with MSVC when there's a
straightforward code change that allows removing the need for gnu99.


I'm afraid that most of the buildsystem details are off. Patch makes
sense regardless :-)

With a more generic commit message (one example below), the commit is
Reviewed-by: Emil Velikov 

Replace the GNU specific keyword asm with __asm_.
This allows us to remove the explicit request for GNU extensions aka -std=gnu99


Sounds good.

I tested with MinGW too.

Reviewed-by: Brian Paul 
Tested-by: Brian Paul 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/7] svga: Use __asm__ instead of asm

[Emil Velikov]

On 27 October 2017 at 00:57, Dylan Baker  wrote:
> Which allows the code to be compiled with c99 instead of gnu99.
>
> A little history. This code is guarded by #ifdef __GNUC__, so it's only
> compiled with autotools on *nix, SCons with MSVC wont hit that code.
> However, meson is going to build both MSVC and GCC/Clang paths. As such
> it makes sense to not have to override the std for gcc/clang, but ensure
> that it's not set to gnu99 when building with MSVC when there's a
> straightforward code change that allows removing the need for gnu99.
>
I'm afraid that most of the buildsystem details are off. Patch makes
sense regardless :-)

With a more generic commit message (one example below), the commit is
Reviewed-by: Emil Velikov 

Replace the GNU specific keyword asm with __asm_.
This allows us to remove the explicit request for GNU extensions aka -std=gnu99

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev