Re: [Mesa-dev] [PATCH 11/43] intel/gensml: Suffix KSP0 fields on Iron Lake

2017-05-16 Thread Jason Ekstrand 
On Tue, May 16, 2017 at 4:07 PM, Matt Turner  wrote:

> On Tue, May 16, 2017 at 3:45 PM, Jason Ekstrand 
> wrote:
> > Iron Lake introduced the multiple KSP thing and so you have KSP0-3.
> > However, the genxml didn't have an index on the first "Kernel Start
> > Pointer" or "GRF Register Count".  Add one to match gen6+.
> > ---
> >  src/intel/genxml/gen5.xml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/intel/genxml/gen5.xml b/src/intel/genxml/gen5.xml
> > index 87377df..a521737 100644
> > --- a/src/intel/genxml/gen5.xml
> > +++ b/src/intel/genxml/gen5.xml
> > @@ -864,8 +864,8 @@
> >
> >
> >
> > - type="offset"/>
> > -
> > + type="offset"/>
>
> I removed the brackets from the Kernel Start Pointer names in commit
> 3443bd45a3. Please just add 0 and not [0]
>

So you did!  I'll make it just 0.  I'll strip the brackets off the GRF
register counts while I'm at it.


> With that,
>
> Reviewed-by: Matt Turner 
>

Thanks!
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 11/43] intel/gensml: Suffix KSP0 fields on Iron Lake

2017-05-16 Thread Nanley Chery 
The title says gensml instead of genxml.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 11/43] intel/gensml: Suffix KSP0 fields on Iron Lake

2017-05-16 Thread Matt Turner 
On Tue, May 16, 2017 at 3:45 PM, Jason Ekstrand  wrote:
> Iron Lake introduced the multiple KSP thing and so you have KSP0-3.
> However, the genxml didn't have an index on the first "Kernel Start
> Pointer" or "GRF Register Count".  Add one to match gen6+.
> ---
>  src/intel/genxml/gen5.xml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/intel/genxml/gen5.xml b/src/intel/genxml/gen5.xml
> index 87377df..a521737 100644
> --- a/src/intel/genxml/gen5.xml
> +++ b/src/intel/genxml/gen5.xml
> @@ -864,8 +864,8 @@
>
>
>
> -
> -
> +

I removed the brackets from the Kernel Start Pointer names in commit
3443bd45a3. Please just add 0 and not [0]

With that,

Reviewed-by: Matt Turner 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev