Re: [Mesa-dev] [PATCH 2/2] gallium/util: use new util_vasprintf() function

[Brian Paul]

On 09/27/2017 11:18 AM, Nicolai Hähnle wrote:

Didn't you send this already? It looks familiar, even in the v2.


Yeah, but I neglected to cc my coworkers.



Anyway, both patches:

Reviewed-by: Nicolai Hähnle 


Thanks!
-Brian




On 27.09.2017 16:01, Brian Paul wrote:

---
  src/gallium/auxiliary/util/u_log.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/gallium/auxiliary/util/u_log.c
b/src/gallium/auxiliary/util/u_log.c
index 359b3e1..dacbe05 100644
--- a/src/gallium/auxiliary/util/u_log.c
+++ b/src/gallium/auxiliary/util/u_log.c
@@ -24,6 +24,7 @@
  #include "u_log.h"
  #include "u_memory.h"
+#include "util/u_string.h"
  struct page_entry {
 const struct u_log_chunk_type *type;
@@ -129,7 +130,7 @@ u_log_printf(struct u_log_context *ctx, const char
*fmt, ...)
 char *str = NULL;
 va_start(va, fmt);
-   int ret = vasprintf(, fmt, va);
+   int ret = util_vasprintf(, fmt, va);
 va_end(va);
 if (ret >= 0) {






___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] gallium/util: use new util_vasprintf() function

[Nicolai Hähnle]

Didn't you send this already? It looks familiar, even in the v2.

Anyway, both patches:

Reviewed-by: Nicolai Hähnle 


On 27.09.2017 16:01, Brian Paul wrote:

---
  src/gallium/auxiliary/util/u_log.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/gallium/auxiliary/util/u_log.c 
b/src/gallium/auxiliary/util/u_log.c
index 359b3e1..dacbe05 100644
--- a/src/gallium/auxiliary/util/u_log.c
+++ b/src/gallium/auxiliary/util/u_log.c
@@ -24,6 +24,7 @@
  #include "u_log.h"
  
  #include "u_memory.h"

+#include "util/u_string.h"
  
  struct page_entry {

 const struct u_log_chunk_type *type;
@@ -129,7 +130,7 @@ u_log_printf(struct u_log_context *ctx, const char *fmt, 
...)
 char *str = NULL;
  
 va_start(va, fmt);

-   int ret = vasprintf(, fmt, va);
+   int ret = util_vasprintf(, fmt, va);
 va_end(va);
  
 if (ret >= 0) {





--
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] gallium/util: use new util_vasprintf() function

[Nicolai Hähnle]

Thanks :)

Both patches:

Reviewed-by: Nicolai Hähnle 


On 25.09.2017 23:08, Brian Paul wrote:

---
  src/gallium/auxiliary/util/u_log.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/gallium/auxiliary/util/u_log.c 
b/src/gallium/auxiliary/util/u_log.c
index 359b3e1..dacbe05 100644
--- a/src/gallium/auxiliary/util/u_log.c
+++ b/src/gallium/auxiliary/util/u_log.c
@@ -24,6 +24,7 @@
  #include "u_log.h"
  
  #include "u_memory.h"

+#include "util/u_string.h"
  
  struct page_entry {

 const struct u_log_chunk_type *type;
@@ -129,7 +130,7 @@ u_log_printf(struct u_log_context *ctx, const char *fmt, 
...)
 char *str = NULL;
  
 va_start(va, fmt);

-   int ret = vasprintf(, fmt, va);
+   int ret = util_vasprintf(, fmt, va);
 va_end(va);
  
 if (ret >= 0) {





--
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev