Re: [Mesa-dev] [PATCH 4/4] anv: Put everything about queries in genX_query.c

2017-02-20 Thread Jason Ekstrand 
On Mon, Feb 20, 2017 at 10:35 AM, Emil Velikov 
wrote:

> On 18 February 2017 at 23:59, Jason Ekstrand  wrote:
> > ---
> >  src/intel/vulkan/Makefile.sources  |   5 +-
> >  src/intel/vulkan/anv_query.c   | 171 -
> Won't this lead to this [albeit trivial] code built 4 times instead of
> once ? Worth mentioning in the commit message (build time should be
> the same afaict).
>

Yes it would and I did think about that.  I briefly considered just picking
an arbitrary gen and only building the 3 common functions once but I
figured that was probably more hassle than it was worth.


> Regardless, I've verified that nothing sneaked in during the move and
> the makefile changes seem good.
> For 3 and 4:
> Reviewed-by: Emil Velikov 
>
> -Emil
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/4] anv: Put everything about queries in genX_query.c

2017-02-20 Thread Emil Velikov 
On 18 February 2017 at 23:59, Jason Ekstrand  wrote:
> ---
>  src/intel/vulkan/Makefile.sources  |   5 +-
>  src/intel/vulkan/anv_query.c   | 171 -
Won't this lead to this [albeit trivial] code built 4 times instead of
once ? Worth mentioning in the commit message (build time should be
the same afaict).

Regardless, I've verified that nothing sneaked in during the move and
the makefile changes seem good.
For 3 and 4:
Reviewed-by: Emil Velikov 

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev