Re: [Mesa-dev] [PATCH v3 2/6] st/va: skeleton VAAPI state tracker
Hi Emil, Any comments on V4 Thanks, Leo -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Liu, Leo Sent: Monday, September 29, 2014 12:30 PM To: Emil Velikov Cc: mesa-dev@lists.freedesktop.org; Koenig, Christian Subject: Re: [Mesa-dev] [PATCH v3 2/6] st/va: skeleton VAAPI state tracker Hi Emil, Thanks for the explanation. V4 has been sent, please review. Thanks, Leo -Original Message- From: Emil Velikov [mailto:emil.l.veli...@gmail.com] Sent: Monday, September 29, 2014 12:27 PM To: Liu, Leo Cc: mesa-dev@lists.freedesktop.org; Koenig, Christian Subject: Re: [Mesa-dev] [PATCH v3 2/6] st/va: skeleton VAAPI state tracker Hi Leo, [...] It seems that you've dropped the sym file. Is that intentional, can we get it back please ? I will get it back. What's the purpose of this sym file? Thanks. It can be used for two purposes - version/tag exported symbols, manager exported/private symbols. We use the latter, otherwise our libraries will export functions which they should not. Mostly llvm symbols plus a few other which cannot be easily fixed otherwise. +dnl Directory for VA libs + +AC_ARG_WITH([va-libdir], +[AS_HELP_STRING([--with-va-libdir=DIR], +[directory for the VA libraries @:@default=`pkg-config +libva -- variable=driverdir`@:@])], +[VA_LIB_INSTALL_DIR=$withval], +[VA_LIB_INSTALL_DIR=`pkg-config libva --variable=driverdir`]) +AC_SUBST([VA_LIB_INSTALL_DIR]) + The above hunk has silently changed since v2 and I'm not sure this one is better. Also there is a discussion about mesa's use of the above pkg-config to set the destination/install dir. I'll amend mesa at a later stage once a decision is made :) So, Can I just keep it like this for now? I meant the complete opposite, but don't bother. Most likely I'll redo this in a day or so. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v3 2/6] st/va: skeleton VAAPI state tracker
On 01/10/14 14:00, Liu, Leo wrote: Hi Emil, Any comments on V4 It actually hurts me that I have to write the following: Is it too unusual to ./configure (or perhaps even make) prior to this email/sending out the patch? I realise that mesa is big and slow but spending 10-20 seconds (configure) and 1-2 minutes(build) is as bad as it might look. Considering it does not break the build I have no objections. Cheers, Emil Thanks, Leo ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v3 2/6] st/va: skeleton VAAPI state tracker
On Mon, Sep 29, 2014 at 12:30 PM, Liu, Leo leo@amd.com wrote: Hi Emil, Thanks for the explanation. V4 has been sent, please review. V4 is: Reviewed-by: Alex Deucher alexander.deuc...@amd.com Thanks, Leo -Original Message- From: Emil Velikov [mailto:emil.l.veli...@gmail.com] Sent: Monday, September 29, 2014 12:27 PM To: Liu, Leo Cc: mesa-dev@lists.freedesktop.org; Koenig, Christian Subject: Re: [Mesa-dev] [PATCH v3 2/6] st/va: skeleton VAAPI state tracker Hi Leo, [...] It seems that you've dropped the sym file. Is that intentional, can we get it back please ? I will get it back. What's the purpose of this sym file? Thanks. It can be used for two purposes - version/tag exported symbols, manager exported/private symbols. We use the latter, otherwise our libraries will export functions which they should not. Mostly llvm symbols plus a few other which cannot be easily fixed otherwise. +dnl Directory for VA libs + +AC_ARG_WITH([va-libdir], +[AS_HELP_STRING([--with-va-libdir=DIR], +[directory for the VA libraries @:@default=`pkg-config +libva -- variable=driverdir`@:@])], +[VA_LIB_INSTALL_DIR=$withval], +[VA_LIB_INSTALL_DIR=`pkg-config libva --variable=driverdir`]) +AC_SUBST([VA_LIB_INSTALL_DIR]) + The above hunk has silently changed since v2 and I'm not sure this one is better. Also there is a discussion about mesa's use of the above pkg-config to set the destination/install dir. I'll amend mesa at a later stage once a decision is made :) So, Can I just keep it like this for now? I meant the complete opposite, but don't bother. Most likely I'll redo this in a day or so. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v3 2/6] st/va: skeleton VAAPI state tracker
Hi Emil, Thanks for the explanation. V4 has been sent, please review. Thanks, Leo -Original Message- From: Emil Velikov [mailto:emil.l.veli...@gmail.com] Sent: Monday, September 29, 2014 12:27 PM To: Liu, Leo Cc: mesa-dev@lists.freedesktop.org; Koenig, Christian Subject: Re: [Mesa-dev] [PATCH v3 2/6] st/va: skeleton VAAPI state tracker Hi Leo, [...] It seems that you've dropped the sym file. Is that intentional, can we get it back please ? I will get it back. What's the purpose of this sym file? Thanks. It can be used for two purposes - version/tag exported symbols, manager exported/private symbols. We use the latter, otherwise our libraries will export functions which they should not. Mostly llvm symbols plus a few other which cannot be easily fixed otherwise. +dnl Directory for VA libs + +AC_ARG_WITH([va-libdir], +[AS_HELP_STRING([--with-va-libdir=DIR], +[directory for the VA libraries @:@default=`pkg-config +libva -- variable=driverdir`@:@])], +[VA_LIB_INSTALL_DIR=$withval], +[VA_LIB_INSTALL_DIR=`pkg-config libva --variable=driverdir`]) +AC_SUBST([VA_LIB_INSTALL_DIR]) + The above hunk has silently changed since v2 and I'm not sure this one is better. Also there is a discussion about mesa's use of the above pkg-config to set the destination/install dir. I'll amend mesa at a later stage once a decision is made :) So, Can I just keep it like this for now? I meant the complete opposite, but don't bother. Most likely I'll redo this in a day or so. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v3 2/6] st/va: skeleton VAAPI state tracker
Hi Leo, [...] It seems that you've dropped the sym file. Is that intentional, can we get it back please ? I will get it back. What's the purpose of this sym file? Thanks. It can be used for two purposes - version/tag exported symbols, manager exported/private symbols. We use the latter, otherwise our libraries will export functions which they should not. Mostly llvm symbols plus a few other which cannot be easily fixed otherwise. +dnl Directory for VA libs + +AC_ARG_WITH([va-libdir], +[AS_HELP_STRING([--with-va-libdir=DIR], +[directory for the VA libraries @:@default=`pkg-config libva -- variable=driverdir`@:@])], +[VA_LIB_INSTALL_DIR=$withval], +[VA_LIB_INSTALL_DIR=`pkg-config libva --variable=driverdir`]) +AC_SUBST([VA_LIB_INSTALL_DIR]) + The above hunk has silently changed since v2 and I'm not sure this one is better. Also there is a discussion about mesa's use of the above pkg-config to set the destination/install dir. I'll amend mesa at a later stage once a decision is made :) So, Can I just keep it like this for now? I meant the complete opposite, but don't bother. Most likely I'll redo this in a day or so. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v3 2/6] st/va: skeleton VAAPI state tracker
Hi Leo, On 26/09/14 21:13, Leo Liu wrote: From: Christian König christian.koe...@amd.com This patch adds a skeleton VA-API state tracker, which is filled with live in the subsequent patches. v2: fixes in configure.ac and va state_tracker Makefile.am s/state_tracker Makefile.am/target Makefile.am/ v3: configure.ac: generate a marco for link to xcb auto-dectecting VA version rebase with upstream changes state-trackers/va/Makefile.am: pass symbol for auto-detecting VA version targets/va/Makefile.am rebase with omx/Makefile.am use macro VA_DRIVER_INIT_FUNC for auto-detect The changelog is rather difficult to read. Can I suggest something like - Do not link against libva. - Detect libva version, and correctly set driver entrypoint name. - Rebase(cleanup) targets/va/Makefile.am Rather than setting up the whole function name in configure.ac can't we just pass the version number ? VDPAU is doing it and seems to be what Gwenole was suggesting. It seems that you've dropped the sym file. Is that intentional, can we get it back please ? +dnl Directory for VA libs + +AC_ARG_WITH([va-libdir], +[AS_HELP_STRING([--with-va-libdir=DIR], +[directory for the VA libraries @:@default=`pkg-config libva --variable=driverdir`@:@])], +[VA_LIB_INSTALL_DIR=$withval], +[VA_LIB_INSTALL_DIR=`pkg-config libva --variable=driverdir`]) +AC_SUBST([VA_LIB_INSTALL_DIR]) + The above hunk has silently changed since v2 and I'm not sure this one is better. Also there is a discussion about mesa's use of the above pkg-config to set the destination/install dir. I'll amend mesa at a later stage once a decision is made :) diff --git a/src/gallium/state_trackers/va/Makefile.am b/src/gallium/state_trackers/va/Makefile.am new file mode 100644 index 000..b6d3f9a --- /dev/null +++ b/src/gallium/state_trackers/va/Makefile.am [...] +AM_CFLAGS = \ + $(GALLIUM_CFLAGS) \ + $(VISIBILITY_CFLAGS) \ + $(VA_CFLAGS) +AM_CFLAGS += -DVA_DRIVER_INIT_FUNC=$(VA_DRIVER_INIT_FUNC) + Just merge the two ? Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v3 2/6] st/va: skeleton VAAPI state tracker
Hi Emil, -Original Message- From: Emil Velikov [mailto:emil.l.veli...@gmail.com] Sent: Sunday, September 28, 2014 4:43 PM To: Liu, Leo; mesa-dev@lists.freedesktop.org Cc: emil.l.veli...@gmail.com; Koenig, Christian Subject: Re: [Mesa-dev] [PATCH v3 2/6] st/va: skeleton VAAPI state tracker Hi Leo, On 26/09/14 21:13, Leo Liu wrote: From: Christian König christian.koe...@amd.com This patch adds a skeleton VA-API state tracker, which is filled with live in the subsequent patches. v2: fixes in configure.ac and va state_tracker Makefile.am s/state_tracker Makefile.am/target Makefile.am/ v3: configure.ac: generate a marco for link to xcb auto-dectecting VA version rebase with upstream changes state-trackers/va/Makefile.am: pass symbol for auto-detecting VA version targets/va/Makefile.am rebase with omx/Makefile.am use macro VA_DRIVER_INIT_FUNC for auto-detect The changelog is rather difficult to read. Can I suggest something like - Do not link against libva. - Detect libva version, and correctly set driver entrypoint name. - Rebase(cleanup) targets/va/Makefile.am This's better. Rather than setting up the whole function name in configure.ac can't we just pass the version number ? VDPAU is doing it and seems to be what Gwenole was suggesting. This also makes sense. It seems that you've dropped the sym file. Is that intentional, can we get it back please ? I will get it back. What's the purpose of this sym file? Thanks. +dnl Directory for VA libs + +AC_ARG_WITH([va-libdir], +[AS_HELP_STRING([--with-va-libdir=DIR], +[directory for the VA libraries @:@default=`pkg-config libva -- variable=driverdir`@:@])], +[VA_LIB_INSTALL_DIR=$withval], +[VA_LIB_INSTALL_DIR=`pkg-config libva --variable=driverdir`]) +AC_SUBST([VA_LIB_INSTALL_DIR]) + The above hunk has silently changed since v2 and I'm not sure this one is better. Also there is a discussion about mesa's use of the above pkg-config to set the destination/install dir. I'll amend mesa at a later stage once a decision is made :) So, Can I just keep it like this for now? diff --git a/src/gallium/state_trackers/va/Makefile.am b/src/gallium/state_trackers/va/Makefile.am new file mode 100644 index 000..b6d3f9a --- /dev/null +++ b/src/gallium/state_trackers/va/Makefile.am [...] +AM_CFLAGS = \ +$(GALLIUM_CFLAGS) \ +$(VISIBILITY_CFLAGS) \ +$(VA_CFLAGS) +AM_CFLAGS += -DVA_DRIVER_INIT_FUNC=$(VA_DRIVER_INIT_FUNC) + Just merge the two ? Sure. Thanks, Leo Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
